From: Andrew Morton <akpm@linux-foundation.org>
To: Sergey Senozhatsky <senozhatsky@chromium.org>
Cc: Yosry Ahmed <yosry.ahmed@linux.dev>,
Nhat Pham <nphamcs@gmail.com>, Minchan Kim <minchan@kernel.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Brian Geffon <bgeffon@google.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCHv2 2/2] zsmalloc: simplify read begin/end logic
Date: Wed, 7 Jan 2026 10:17:05 -0800 [thread overview]
Message-ID: <20260107101705.0469e87ffc60120120500e76@linux-foundation.org> (raw)
In-Reply-To: <20260107052145.3586917-2-senozhatsky@chromium.org>
On Wed, 7 Jan 2026 14:21:45 +0900 Sergey Senozhatsky <senozhatsky@chromium.org> wrote:
> From: Yosry Ahmed <yosry.ahmed@linux.dev>
>
> When we switched from using class->size (for spans detection)
> to actual compressed object size, we had to compensate for
> the fact that class->size implicitly took inlined handle
> into consideration. In fact, instead of adjusting the size
> of compressed object (adding handle offset for non-huge size
> classes), we can move some lines around and simplify the
> code: there are already paths in read_begin/end that compensate
> for inlined object handle offset.
Updated, thanks.
> Signed-off-by: Yosry Ahmed <yosry.ahmed@linux.dev>
> ---
This patch should have had your Signed-off-by: also, as you were on the
delivery path. I have made that change to the mm.gt copy.
next prev parent reply other threads:[~2026-01-07 18:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-07 5:21 [PATCHv2 1/2] zsmalloc: use actual object size to detect spans Sergey Senozhatsky
2026-01-07 5:21 ` [PATCHv2 2/2] zsmalloc: simplify read begin/end logic Sergey Senozhatsky
2026-01-07 18:17 ` Andrew Morton [this message]
2026-01-08 1:14 ` Sergey Senozhatsky
2026-01-07 19:03 ` Yosry Ahmed
2026-01-08 1:17 ` Sergey Senozhatsky
2026-01-07 18:57 ` [PATCHv2 1/2] zsmalloc: use actual object size to detect spans Yosry Ahmed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260107101705.0469e87ffc60120120500e76@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=bgeffon@google.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=nphamcs@gmail.com \
--cc=senozhatsky@chromium.org \
--cc=yosry.ahmed@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox