linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Boudewijn van der Heide <boudewijn@delta-utec.com>
To: Liam.Howlett@oracle.com
Cc: boudewijn@delta-utec.com, akpm@linux-foundation.org,
	aliceryhl@google.com, andrewjballance@gmail.com,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	maple-tree@lists.infradead.org
Subject: [PATCH v2] maple_tree: Add lockdep assertion in mas_dup_alloc()
Date: Tue,  6 Jan 2026 22:07:57 +0100	[thread overview]
Message-ID: <20260106210757.465586-1-boudewijn@delta-utec.com> (raw)
In-Reply-To: <20260103165758.74094-1-boudewijn@delta-utec.com>

The __mt_dup() function requires callers to hold the appropriate write
lock when duplicating a maple tree. Without proper locking, concurrent
modifications during duplication could access invalid node slots.

Add a lockdep assertion to catch such API misuse during development.
This is API hardening rather than a bug fix - all in-tree callers
already follow the proper locking rules as documented above __mt_dup().

Signed-off-by: Boudewijn van der Heide <boudewijn@delta-utec.com>
---
Changes in v2:
    - Replaced runtime deadnode check with a lockdep assertion
v1:
    https://lore.kernel.org/lkml/20260103165758.74094-1-boudewijn@delta-utec.com/

diff --git a/lib/maple_tree.c b/lib/maple_tree.c
index 5aa4c9500018..3b4357f16352 100644
--- a/lib/maple_tree.c
+++ b/lib/maple_tree.c
@@ -6248,6 +6248,8 @@ static inline void mas_dup_alloc(struct ma_state *mas, struct ma_state *new_mas,
 	void __rcu **new_slots;
 	unsigned long val;
 
+	lockdep_assert(mt_write_locked(mas->tree));
+
 	/* Allocate memory for child nodes. */
 	type = mte_node_type(mas->node);
 	new_slots = ma_slots(new_node, type);
--
2.47.3



      parent reply	other threads:[~2026-01-06 21:08 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-03 16:57 [PATCH] maple_tree: Add dead node check " Boudewijn van der Heide
2026-01-03 18:32 ` Andrew Morton
2026-01-03 20:06   ` Boudewijn van der Heide
2026-01-06  1:33     ` Andrew Morton
2026-01-06  2:49       ` Matthew Wilcox
2026-01-06  3:40         ` Andrew Morton
2026-01-06 13:24         ` Boudewijn van der Heide
2026-01-06 16:01           ` Liam R. Howlett
2026-01-06 16:48             ` Boudewijn van der Heide
2026-01-06 18:29             ` Matthew Wilcox
2026-01-06 20:07               ` Liam R. Howlett
2026-01-06 21:07 ` Boudewijn van der Heide [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260106210757.465586-1-boudewijn@delta-utec.com \
    --to=boudewijn@delta-utec.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=aliceryhl@google.com \
    --cc=andrewjballance@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=maple-tree@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox