linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Boudewijn van der Heide <boudewijn@delta-utec.com>
To: liam.howlett@oracle.com
Cc: akpm@linux-foundation.org, aliceryhl@google.com,
	andrewjballance@gmail.com, boudewijn@delta-utec.com,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	maple-tree@lists.infradead.org, willy@infradead.org
Subject: Re: [PATCH] maple_tree: Add dead node check in mas_dup_alloc()
Date: Tue,  6 Jan 2026 17:48:44 +0100	[thread overview]
Message-ID: <20260106164844.280106-1-boudewijn@delta-utec.com> (raw)
In-Reply-To: <vaz4cykqkaa6qksfp6nsnta4rkzqpvaorzdsgy5orapkwx6mil@knfau4tgxmup>

> > > Surely this should just be a lockdep assertion that the appropriate
> > > locks are held?
> > >
> > Just to confirm: do you want me to remove the original runtime check entirely
> > and replace it with a lockdep_assert(), or do you want both?
> > If it's only the assertion,

> Please do not include any runtime checks in this change - Just the
> lockdep_assert().

> > that would mean that production builds won't enforce the check, right?
> >
> > For v2, should I add a Fixes: line and Cc: stable,
> > or should i leave it out?

> This does not need to be backported and does not fix anything.  It's an
> attempt to protect the user from shooting their own foot off by using
> the interface incorrectly.

> The fact that no one in the tree uses it incorrectly means that any
> backport would be for the benefit of out-of-tree drivers, which we do
> not support.

Thanks for the help and clarification! I will send v2 with just the assertion,
as suggested.

Thanks,
Boudewijn


  reply	other threads:[~2026-01-06 16:49 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-03 16:57 Boudewijn van der Heide
2026-01-03 18:32 ` Andrew Morton
2026-01-03 20:06   ` Boudewijn van der Heide
2026-01-06  1:33     ` Andrew Morton
2026-01-06  2:49       ` Matthew Wilcox
2026-01-06  3:40         ` Andrew Morton
2026-01-06 13:24         ` Boudewijn van der Heide
2026-01-06 16:01           ` Liam R. Howlett
2026-01-06 16:48             ` Boudewijn van der Heide [this message]
2026-01-06 18:29             ` Matthew Wilcox
2026-01-06 20:07               ` Liam R. Howlett
2026-01-06 21:07 ` [PATCH v2] maple_tree: Add lockdep assertion " Boudewijn van der Heide

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260106164844.280106-1-boudewijn@delta-utec.com \
    --to=boudewijn@delta-utec.com \
    --cc=akpm@linux-foundation.org \
    --cc=aliceryhl@google.com \
    --cc=andrewjballance@gmail.com \
    --cc=liam.howlett@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=maple-tree@lists.infradead.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox