* [akpm-mm:mm-new 224/226] include/trace/events/vmscan.h:238:68: error: invalid use of undefined type 'struct mem_cgroup'
@ 2026-01-06 21:41 kernel test robot
2026-01-06 21:52 ` Sid Kumar
0 siblings, 1 reply; 3+ messages in thread
From: kernel test robot @ 2026-01-06 21:41 UTC (permalink / raw)
To: Thomas Ballasi
Cc: oe-kbuild-all, David Hildenbrand, Andrew Morton,
Linux Memory Management List
tree: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-new
head: d51d3f6765d29ab5cdc6a59ad832017e660d5add
commit: b84bca52c8e661aa7da507a03cc3f6831fef2edf [224/226] mm: vmscan: add cgroup IDs to vmscan tracepoints
config: i386-randconfig-011-20260107 (https://download.01.org/0day-ci/archive/20260107/202601070540.h0lMglk1-lkp@intel.com/config)
compiler: gcc-13 (Debian 13.3.0-16) 13.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260107/202601070540.h0lMglk1-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202601070540.h0lMglk1-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from include/trace/define_trace.h:132,
from include/trace/events/vmscan.h:554,
from mm/vmscan.c:73:
include/trace/events/vmscan.h: In function 'do_trace_event_raw_event_mm_shrink_slab_start':
>> include/trace/events/vmscan.h:238:68: error: invalid use of undefined type 'struct mem_cgroup'
238 | __entry->memcg_id = sc->memcg ? cgroup_id(sc->memcg->css.cgroup) : 0;
| ^~
include/trace/trace_events.h:427:11: note: in definition of macro '__DECLARE_EVENT_CLASS'
427 | { assign; } \
| ^~~~~~
include/trace/trace_events.h:435:23: note: in expansion of macro 'PARAMS'
435 | PARAMS(assign), PARAMS(print)) \
| ^~~~~~
include/trace/trace_events.h:40:9: note: in expansion of macro 'DECLARE_EVENT_CLASS'
40 | DECLARE_EVENT_CLASS(name, \
| ^~~~~~~~~~~~~~~~~~~
include/trace/trace_events.h:44:30: note: in expansion of macro 'PARAMS'
44 | PARAMS(assign), \
| ^~~~~~
include/trace/events/vmscan.h:206:1: note: in expansion of macro 'TRACE_EVENT'
206 | TRACE_EVENT(mm_shrink_slab_start,
| ^~~~~~~~~~~
include/trace/events/vmscan.h:228:9: note: in expansion of macro 'TP_fast_assign'
228 | TP_fast_assign(
| ^~~~~~~~~~~~~~
include/trace/events/vmscan.h: In function 'do_trace_event_raw_event_mm_shrink_slab_end':
include/trace/events/vmscan.h:280:56: error: invalid use of undefined type 'struct mem_cgroup'
280 | __entry->memcg_id = cgroup_id(sc->memcg->css.cgroup);
| ^~
include/trace/trace_events.h:427:11: note: in definition of macro '__DECLARE_EVENT_CLASS'
427 | { assign; } \
| ^~~~~~
include/trace/trace_events.h:435:23: note: in expansion of macro 'PARAMS'
435 | PARAMS(assign), PARAMS(print)) \
| ^~~~~~
include/trace/trace_events.h:40:9: note: in expansion of macro 'DECLARE_EVENT_CLASS'
40 | DECLARE_EVENT_CLASS(name, \
| ^~~~~~~~~~~~~~~~~~~
include/trace/trace_events.h:44:30: note: in expansion of macro 'PARAMS'
44 | PARAMS(assign), \
| ^~~~~~
include/trace/events/vmscan.h:254:1: note: in expansion of macro 'TRACE_EVENT'
254 | TRACE_EVENT(mm_shrink_slab_end,
| ^~~~~~~~~~~
include/trace/events/vmscan.h:272:9: note: in expansion of macro 'TP_fast_assign'
272 | TP_fast_assign(
| ^~~~~~~~~~~~~~
In file included from include/trace/define_trace.h:133:
include/trace/events/vmscan.h: In function 'do_perf_trace_mm_shrink_slab_start':
>> include/trace/events/vmscan.h:238:68: error: invalid use of undefined type 'struct mem_cgroup'
238 | __entry->memcg_id = sc->memcg ? cgroup_id(sc->memcg->css.cgroup) : 0;
| ^~
include/trace/perf.h:51:11: note: in definition of macro '__DECLARE_EVENT_CLASS'
51 | { assign; } \
| ^~~~~~
include/trace/perf.h:67:23: note: in expansion of macro 'PARAMS'
67 | PARAMS(assign), PARAMS(print)) \
| ^~~~~~
include/trace/trace_events.h:40:9: note: in expansion of macro 'DECLARE_EVENT_CLASS'
40 | DECLARE_EVENT_CLASS(name, \
| ^~~~~~~~~~~~~~~~~~~
include/trace/trace_events.h:44:30: note: in expansion of macro 'PARAMS'
44 | PARAMS(assign), \
| ^~~~~~
include/trace/events/vmscan.h:206:1: note: in expansion of macro 'TRACE_EVENT'
206 | TRACE_EVENT(mm_shrink_slab_start,
| ^~~~~~~~~~~
include/trace/events/vmscan.h:228:9: note: in expansion of macro 'TP_fast_assign'
228 | TP_fast_assign(
| ^~~~~~~~~~~~~~
include/trace/events/vmscan.h: In function 'do_perf_trace_mm_shrink_slab_end':
include/trace/events/vmscan.h:280:56: error: invalid use of undefined type 'struct mem_cgroup'
280 | __entry->memcg_id = cgroup_id(sc->memcg->css.cgroup);
| ^~
include/trace/perf.h:51:11: note: in definition of macro '__DECLARE_EVENT_CLASS'
51 | { assign; } \
| ^~~~~~
include/trace/perf.h:67:23: note: in expansion of macro 'PARAMS'
67 | PARAMS(assign), PARAMS(print)) \
| ^~~~~~
include/trace/trace_events.h:40:9: note: in expansion of macro 'DECLARE_EVENT_CLASS'
40 | DECLARE_EVENT_CLASS(name, \
| ^~~~~~~~~~~~~~~~~~~
include/trace/trace_events.h:44:30: note: in expansion of macro 'PARAMS'
44 | PARAMS(assign), \
| ^~~~~~
include/trace/events/vmscan.h:254:1: note: in expansion of macro 'TRACE_EVENT'
254 | TRACE_EVENT(mm_shrink_slab_end,
| ^~~~~~~~~~~
include/trace/events/vmscan.h:272:9: note: in expansion of macro 'TP_fast_assign'
272 | TP_fast_assign(
| ^~~~~~~~~~~~~~
vim +238 include/trace/events/vmscan.h
205
206 TRACE_EVENT(mm_shrink_slab_start,
207 TP_PROTO(struct shrinker *shr, struct shrink_control *sc,
208 long nr_objects_to_shrink, unsigned long cache_items,
209 unsigned long long delta, unsigned long total_scan,
210 int priority),
211
212 TP_ARGS(shr, sc, nr_objects_to_shrink, cache_items, delta, total_scan,
213 priority),
214
215 TP_STRUCT__entry(
216 __field(struct shrinker *, shr)
217 __field(void *, shrink)
218 __field(long, nr_objects_to_shrink)
219 __field(unsigned long, gfp_flags)
220 __field(unsigned long, cache_items)
221 __field(unsigned long long, delta)
222 __field(unsigned long, total_scan)
223 __field(int, priority)
224 __field(int, nid)
225 __field(unsigned short, memcg_id)
226 ),
227
228 TP_fast_assign(
229 __entry->shr = shr;
230 __entry->shrink = shr->scan_objects;
231 __entry->nr_objects_to_shrink = nr_objects_to_shrink;
232 __entry->gfp_flags = (__force unsigned long)sc->gfp_mask;
233 __entry->cache_items = cache_items;
234 __entry->delta = delta;
235 __entry->total_scan = total_scan;
236 __entry->priority = priority;
237 __entry->nid = sc->nid;
> 238 __entry->memcg_id = sc->memcg ? cgroup_id(sc->memcg->css.cgroup) : 0;
239 ),
240
241 TP_printk("%pS %p: nid: %d memcg_id: %u objects to shrink %ld gfp_flags %s cache items %ld delta %lld total_scan %ld priority %d",
242 __entry->shrink,
243 __entry->shr,
244 __entry->nid,
245 __entry->memcg_id,
246 __entry->nr_objects_to_shrink,
247 show_gfp_flags(__entry->gfp_flags),
248 __entry->cache_items,
249 __entry->delta,
250 __entry->total_scan,
251 __entry->priority)
252 );
253
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [akpm-mm:mm-new 224/226] include/trace/events/vmscan.h:238:68: error: invalid use of undefined type 'struct mem_cgroup' 2026-01-06 21:41 [akpm-mm:mm-new 224/226] include/trace/events/vmscan.h:238:68: error: invalid use of undefined type 'struct mem_cgroup' kernel test robot @ 2026-01-06 21:52 ` Sid Kumar 2026-01-06 23:08 ` Andrew Morton 0 siblings, 1 reply; 3+ messages in thread From: Sid Kumar @ 2026-01-06 21:52 UTC (permalink / raw) To: kernel test robot, Thomas Ballasi Cc: oe-kbuild-all, David Hildenbrand, Andrew Morton, Linux Memory Management List On 1/6/26 3:41 PM, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-new > head: d51d3f6765d29ab5cdc6a59ad832017e660d5add > commit: b84bca52c8e661aa7da507a03cc3f6831fef2edf [224/226] mm: vmscan: add cgroup IDs to vmscan tracepoints > config: i386-randconfig-011-20260107 (https://download.01.org/0day-ci/archive/20260107/202601070540.h0lMglk1-lkp@intel.com/config) > compiler: gcc-13 (Debian 13.3.0-16) 13.3.0 > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260107/202601070540.h0lMglk1-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot <lkp@intel.com> > | Closes: https://lore.kernel.org/oe-kbuild-all/202601070540.h0lMglk1-lkp@intel.com/ > > All errors (new ones prefixed by >>): > > In file included from include/trace/define_trace.h:132, > from include/trace/events/vmscan.h:554, > from mm/vmscan.c:73: > include/trace/events/vmscan.h: In function 'do_trace_event_raw_event_mm_shrink_slab_start': >>> include/trace/events/vmscan.h:238:68: error: invalid use of undefined type 'struct mem_cgroup' > 238 | __entry->memcg_id = sc->memcg ? cgroup_id(sc->memcg->css.cgroup) : 0; I ran into the same issue when trying to build mm-new with # CONFIG_MEMCG is not set The below diff allowed me to build, but not sure if the correct fix: diff --git a/include/trace/events/vmscan.h b/include/trace/events/vmscan.h index d438abfa03eb..7b8af2a9688a 100644 --- a/include/trace/events/vmscan.h +++ b/include/trace/events/vmscan.h @@ -245,7 +245,9 @@ TRACE_EVENT(mm_shrink_slab_start, __entry->priority = priority; __entry->nid = sc->nid; __entry->pid = current->pid; +#ifdef CONFIG_MEMCG __entry->memcg_id = sc->memcg ? cgroup_id(sc->memcg->css.cgroup) : 0; +#endif /* CONFIG_MEMCG */ ), TP_printk("%pS %p: nid: %d pid: %d memcg_id: %u objects to shrink %ld gfp_flags %s cache items %ld delta %lld total_scan %ld priority %d %s", @@ -290,7 +292,10 @@ TRACE_EVENT(mm_shrink_slab_end, __entry->nid = sc->nid; __entry->retval = shrinker_retval; __entry->pid = current->pid; +#ifdef CONFIG_MEMCG __entry->memcg_id = cgroup_id(sc->memcg->css.cgroup); +#endif /* CONFIG_MEMCG */ ), TP_printk("%pS %p: nid: %d pid: %d memcg_id: %u unused scan count %ld new scan count %ld total_scan %ld last shrinker return val %d %s", > | ^~ > include/trace/trace_events.h:427:11: note: in definition of macro '__DECLARE_EVENT_CLASS' > 427 | { assign; } \ > | ^~~~~~ > include/trace/trace_events.h:435:23: note: in expansion of macro 'PARAMS' > 435 | PARAMS(assign), PARAMS(print)) \ > | ^~~~~~ > include/trace/trace_events.h:40:9: note: in expansion of macro 'DECLARE_EVENT_CLASS' > 40 | DECLARE_EVENT_CLASS(name, \ > | ^~~~~~~~~~~~~~~~~~~ > include/trace/trace_events.h:44:30: note: in expansion of macro 'PARAMS' > 44 | PARAMS(assign), \ > | ^~~~~~ > include/trace/events/vmscan.h:206:1: note: in expansion of macro 'TRACE_EVENT' > 206 | TRACE_EVENT(mm_shrink_slab_start, > | ^~~~~~~~~~~ > include/trace/events/vmscan.h:228:9: note: in expansion of macro 'TP_fast_assign' > 228 | TP_fast_assign( > | ^~~~~~~~~~~~~~ > include/trace/events/vmscan.h: In function 'do_trace_event_raw_event_mm_shrink_slab_end': > include/trace/events/vmscan.h:280:56: error: invalid use of undefined type 'struct mem_cgroup' > 280 | __entry->memcg_id = cgroup_id(sc->memcg->css.cgroup); > | ^~ > include/trace/trace_events.h:427:11: note: in definition of macro '__DECLARE_EVENT_CLASS' > 427 | { assign; } \ > | ^~~~~~ > include/trace/trace_events.h:435:23: note: in expansion of macro 'PARAMS' > 435 | PARAMS(assign), PARAMS(print)) \ > | ^~~~~~ > include/trace/trace_events.h:40:9: note: in expansion of macro 'DECLARE_EVENT_CLASS' > 40 | DECLARE_EVENT_CLASS(name, \ > | ^~~~~~~~~~~~~~~~~~~ > include/trace/trace_events.h:44:30: note: in expansion of macro 'PARAMS' > 44 | PARAMS(assign), \ > | ^~~~~~ > include/trace/events/vmscan.h:254:1: note: in expansion of macro 'TRACE_EVENT' > 254 | TRACE_EVENT(mm_shrink_slab_end, > | ^~~~~~~~~~~ > include/trace/events/vmscan.h:272:9: note: in expansion of macro 'TP_fast_assign' > 272 | TP_fast_assign( > | ^~~~~~~~~~~~~~ > In file included from include/trace/define_trace.h:133: > include/trace/events/vmscan.h: In function 'do_perf_trace_mm_shrink_slab_start': >>> include/trace/events/vmscan.h:238:68: error: invalid use of undefined type 'struct mem_cgroup' > 238 | __entry->memcg_id = sc->memcg ? cgroup_id(sc->memcg->css.cgroup) : 0; > | ^~ > include/trace/perf.h:51:11: note: in definition of macro '__DECLARE_EVENT_CLASS' > 51 | { assign; } \ > | ^~~~~~ > include/trace/perf.h:67:23: note: in expansion of macro 'PARAMS' > 67 | PARAMS(assign), PARAMS(print)) \ > | ^~~~~~ > include/trace/trace_events.h:40:9: note: in expansion of macro 'DECLARE_EVENT_CLASS' > 40 | DECLARE_EVENT_CLASS(name, \ > | ^~~~~~~~~~~~~~~~~~~ > include/trace/trace_events.h:44:30: note: in expansion of macro 'PARAMS' > 44 | PARAMS(assign), \ > | ^~~~~~ > include/trace/events/vmscan.h:206:1: note: in expansion of macro 'TRACE_EVENT' > 206 | TRACE_EVENT(mm_shrink_slab_start, > | ^~~~~~~~~~~ > include/trace/events/vmscan.h:228:9: note: in expansion of macro 'TP_fast_assign' > 228 | TP_fast_assign( > | ^~~~~~~~~~~~~~ > include/trace/events/vmscan.h: In function 'do_perf_trace_mm_shrink_slab_end': > include/trace/events/vmscan.h:280:56: error: invalid use of undefined type 'struct mem_cgroup' > 280 | __entry->memcg_id = cgroup_id(sc->memcg->css.cgroup); > | ^~ > include/trace/perf.h:51:11: note: in definition of macro '__DECLARE_EVENT_CLASS' > 51 | { assign; } \ > | ^~~~~~ > include/trace/perf.h:67:23: note: in expansion of macro 'PARAMS' > 67 | PARAMS(assign), PARAMS(print)) \ > | ^~~~~~ > include/trace/trace_events.h:40:9: note: in expansion of macro 'DECLARE_EVENT_CLASS' > 40 | DECLARE_EVENT_CLASS(name, \ > | ^~~~~~~~~~~~~~~~~~~ > include/trace/trace_events.h:44:30: note: in expansion of macro 'PARAMS' > 44 | PARAMS(assign), \ > | ^~~~~~ > include/trace/events/vmscan.h:254:1: note: in expansion of macro 'TRACE_EVENT' > 254 | TRACE_EVENT(mm_shrink_slab_end, > | ^~~~~~~~~~~ > include/trace/events/vmscan.h:272:9: note: in expansion of macro 'TP_fast_assign' > 272 | TP_fast_assign( > | ^~~~~~~~~~~~~~ > > > vim +238 include/trace/events/vmscan.h > > 205 > 206 TRACE_EVENT(mm_shrink_slab_start, > 207 TP_PROTO(struct shrinker *shr, struct shrink_control *sc, > 208 long nr_objects_to_shrink, unsigned long cache_items, > 209 unsigned long long delta, unsigned long total_scan, > 210 int priority), > 211 > 212 TP_ARGS(shr, sc, nr_objects_to_shrink, cache_items, delta, total_scan, > 213 priority), > 214 > 215 TP_STRUCT__entry( > 216 __field(struct shrinker *, shr) > 217 __field(void *, shrink) > 218 __field(long, nr_objects_to_shrink) > 219 __field(unsigned long, gfp_flags) > 220 __field(unsigned long, cache_items) > 221 __field(unsigned long long, delta) > 222 __field(unsigned long, total_scan) > 223 __field(int, priority) > 224 __field(int, nid) > 225 __field(unsigned short, memcg_id) > 226 ), > 227 > 228 TP_fast_assign( > 229 __entry->shr = shr; > 230 __entry->shrink = shr->scan_objects; > 231 __entry->nr_objects_to_shrink = nr_objects_to_shrink; > 232 __entry->gfp_flags = (__force unsigned long)sc->gfp_mask; > 233 __entry->cache_items = cache_items; > 234 __entry->delta = delta; > 235 __entry->total_scan = total_scan; > 236 __entry->priority = priority; > 237 __entry->nid = sc->nid; > > 238 __entry->memcg_id = sc->memcg ? cgroup_id(sc->memcg->css.cgroup) : 0; > 239 ), > 240 > 241 TP_printk("%pS %p: nid: %d memcg_id: %u objects to shrink %ld gfp_flags %s cache items %ld delta %lld total_scan %ld priority %d", > 242 __entry->shrink, > 243 __entry->shr, > 244 __entry->nid, > 245 __entry->memcg_id, > 246 __entry->nr_objects_to_shrink, > 247 show_gfp_flags(__entry->gfp_flags), > 248 __entry->cache_items, > 249 __entry->delta, > 250 __entry->total_scan, > 251 __entry->priority) > 252 ); > 253 > ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [akpm-mm:mm-new 224/226] include/trace/events/vmscan.h:238:68: error: invalid use of undefined type 'struct mem_cgroup' 2026-01-06 21:52 ` Sid Kumar @ 2026-01-06 23:08 ` Andrew Morton 0 siblings, 0 replies; 3+ messages in thread From: Andrew Morton @ 2026-01-06 23:08 UTC (permalink / raw) To: Sid Kumar Cc: kernel test robot, Thomas Ballasi, oe-kbuild-all, David Hildenbrand, Linux Memory Management List On Tue, 6 Jan 2026 15:52:09 -0600 Sid Kumar <sidhartha.kumar@oracle.com> wrote: > On 1/6/26 3:41 PM, kernel test robot wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-new > > head: d51d3f6765d29ab5cdc6a59ad832017e660d5add > > commit: b84bca52c8e661aa7da507a03cc3f6831fef2edf [224/226] mm: vmscan: add cgroup IDs to vmscan tracepoints > > config: i386-randconfig-011-20260107 (https://download.01.org/0day-ci/archive/20260107/202601070540.h0lMglk1-lkp@intel.com/config) > > compiler: gcc-13 (Debian 13.3.0-16) 13.3.0 > > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260107/202601070540.h0lMglk1-lkp@intel.com/reproduce) > > > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > > the same patch/commit), kindly add following tags > > | Reported-by: kernel test robot <lkp@intel.com> > > | Closes: https://lore.kernel.org/oe-kbuild-all/202601070540.h0lMglk1-lkp@intel.com/ > > > > All errors (new ones prefixed by >>): > > > > In file included from include/trace/define_trace.h:132, > > from include/trace/events/vmscan.h:554, > > from mm/vmscan.c:73: > > include/trace/events/vmscan.h: In function 'do_trace_event_raw_event_mm_shrink_slab_start': > >>> include/trace/events/vmscan.h:238:68: error: invalid use of undefined type 'struct mem_cgroup' > > 238 | __entry->memcg_id = sc->memcg ? cgroup_id(sc->memcg->css.cgroup) : 0; > > > I ran into the same issue when trying to build mm-new with # > CONFIG_MEMCG is not set > > The below diff allowed me to build, but not sure if the correct fix: Thanks. The series seems to have a few issues so I'll drop it for now. tracing-add-__event_in_irq-helpers.patch mm-vmscan-add-cgroup-ids-to-vmscan-tracepoints.patch mm-vmscan-add-pids-to-vmscan-tracepoints.patch ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-01-06 23:08 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2026-01-06 21:41 [akpm-mm:mm-new 224/226] include/trace/events/vmscan.h:238:68: error: invalid use of undefined type 'struct mem_cgroup' kernel test robot 2026-01-06 21:52 ` Sid Kumar 2026-01-06 23:08 ` Andrew Morton
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox