Re: [PATCH v3 0/2] mm: vmscan: add PID and cgroup ID to vmscan tracepoints

[Steven Rostedt <rostedt@goodmis.org>]

On Mon, 5 Jan 2026 18:06:40 -0800
Andrew Morton <akpm@linux-foundation.org> wrote:

> On Mon,  5 Jan 2026 08:04:21 -0800 Thomas Ballasi <tballasi@linux.microsoft.com> wrote:
> 
> > Changes in v3:
> > - Swapped multiple field entries to prevent a hole in the ring buffer
> > - Replaced in_task() with __event_in_irq
> > - Replaced mem_cgroup_id(memcg) with cgroup_id(memcg->css.cgroup)
> > - Rebased the tree to latest 6.18  
> 
> x86_64 allmodconfig;
> 
> 
> In file included from ./include/trace/define_trace.h:132,
>                  from ./include/trace/events/vmscan.h:569,
>                  from mm/vmscan.c:73:
> ./include/trace/events/vmscan.h: In function 'trace_raw_output_mm_vmscan_direct_reclaim_begin_template':
> ./include/trace/events/vmscan.h:140:17: error: implicit declaration of function '__event_in_irq' [-Wimplicit-function-declaration]
>   140 | +               __event_in_irq() ? "(in-irq)" : "")
>       |                 ^~~~~~~~~~~~~~
> ./include/trace/trace_events.h:219:34: note: in definition of macro 'DECLARE_EVENT_CLASS'
>   219 |         trace_event_printf(iter, print);                                \
>       |                                  ^~~~~
> ./include/trace/events/vmscan.h:135:9: note: in expansion of macro 'TP_printk'
>   135 |         TP_printk("order=%d gfp_flags=%s pid=%d memcg_id=%u %s",
>       |         ^~~~~~~~~
> make[3]: *** [scripts/Makefile.build:287: mm/vmscan.o] Error 1
> make[2]: *** [scripts/Makefile.build:556: mm] Error 2
> make[1]: *** [/usr/src/25/Makefile:2054: .] Error 2
> make: *** [Makefile:248: __sub-make] Error 2

This is dependent on my patch:

  https://lore.kernel.org/all/20251229163515.3d1b0bba@gandalf.local.home/

Where I said you can take this patch. But I don't see it as part of the
series.

  https://lore.kernel.org/all/20251229163634.5aad205d@gandalf.local.home/

-- Steve