From: Andrew Morton <akpm@linux-foundation.org>
To: Joanne Koong <joannelkoong@gmail.com>
Cc: david@redhat.com, miklos@szeredi.hu, linux-mm@kvack.org,
athul.krishna.kr@protonmail.com, j.neuschaefer@gmx.net,
carnil@debian.org, linux-fsdevel@vger.kernel.org,
stable@vger.kernel.org, Bernd Schubert <bschubert@ddn.com>
Subject: Re: [PATCH v3 1/1] fs/writeback: skip AS_NO_DATA_INTEGRITY mappings in wait_sb_inodes()
Date: Mon, 5 Jan 2026 17:48:24 -0800 [thread overview]
Message-ID: <20260105174824.5ea19dc45b79e29e0219e6a3@linux-foundation.org> (raw)
In-Reply-To: <20260105211737.4105620-2-joannelkoong@gmail.com>
On Mon, 5 Jan 2026 13:17:27 -0800 Joanne Koong <joannelkoong@gmail.com> wrote:
> Above the while() loop in wait_sb_inodes(), we document that we must
> wait for all pages under writeback for data integrity. Consequently, if
> a mapping, like fuse, traditionally does not have data integrity
> semantics, there is no need to wait at all; we can simply skip these
> inodes.
>
> This restores fuse back to prior behavior where syncs are no-ops. This
> fixes a user regression where if a system is running a faulty fuse
> server that does not reply to issued write requests, this causes
> wait_sb_inodes() to wait forever.
>
> Fixes: 0c58a97f919c ("fuse: remove tmp folio for writebacks and internal rb tree")
> Reported-by: Athul Krishna <athul.krishna.kr@protonmail.com>
> Reported-by: J. Neuschäfer <j.neuschaefer@gmx.net>
> Cc: stable@vger.kernel.org
> Signed-off-by: Joanne Koong <joannelkoong@gmail.com>
> Reviewed-by: Bernd Schubert <bschubert@ddn.com>
> Tested-by: J. Neuschäfer <j.neuschaefer@gmx.net>
Thanks.
> fs/fs-writeback.c | 7 ++++++-
> fs/fuse/file.c | 4 +++-
> include/linux/pagemap.h | 11 +++++++++++
> 3 files changed, 20 insertions(+), 2 deletions(-)
I'll queue this in mm.git's mm-hotfixes branches for a 6.19-rcX merge.
prev parent reply other threads:[~2026-01-06 1:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-05 21:17 [PATCH v3 0/1] " Joanne Koong
2026-01-05 21:17 ` [PATCH v3 1/1] " Joanne Koong
2026-01-06 1:48 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260105174824.5ea19dc45b79e29e0219e6a3@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=athul.krishna.kr@protonmail.com \
--cc=bschubert@ddn.com \
--cc=carnil@debian.org \
--cc=david@redhat.com \
--cc=j.neuschaefer@gmx.net \
--cc=joannelkoong@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=miklos@szeredi.hu \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox