From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E092CC27C53 for ; Fri, 7 Jun 2024 04:38:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1B01D6B0092; Fri, 7 Jun 2024 00:38:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 13AE26B0095; Fri, 7 Jun 2024 00:38:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F1BB06B0098; Fri, 7 Jun 2024 00:38:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D088D6B0092 for ; Fri, 7 Jun 2024 00:38:42 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 7D52F16165F for ; Fri, 7 Jun 2024 04:38:42 +0000 (UTC) X-FDA: 82202836884.17.E7D2F1E Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf20.hostedemail.com (Postfix) with ESMTP id 8788D1C0017 for ; Fri, 7 Jun 2024 04:38:39 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf20.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717735120; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BaONp1hIJDu+D+nrL1FdRteNqPjq9pFLkM5Gt9XVP0A=; b=SDUuxWwbhF1NqSqQIZvjQKYHuxyWM3mVpvI5mGnQOh1ZycTB0tfSRmW3RqL+yF05NrOMLo 3rrfYcTXmkGJ7eUR4ex/o9IK8cxUR9WpQ2CPkPVCmRP+S40aLj20SWVIpUJtlrE5Dmdydo 4GbPM6CoNoIlHnaB+lGiw9wUxRBWhqk= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf20.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717735120; a=rsa-sha256; cv=none; b=YoKooKqPMZubCzpSF9rWp7HJGoGjK+hLxpQCOiXNinW1CUbniJhTykhJirEerRoWwK7xy+ s/5X31MsVp1m676zNIWgZei62E71caRisERoDI11IhF/Ap+Dd8UWNtTMOkjGqQY5q2JwI3 8RTmIxqgTk+t79egQZSmp2ay+M1Cje0= Received: from mail.maildlp.com (unknown [172.19.163.252]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4VwSyy4JZBzwRv6; Fri, 7 Jun 2024 12:34:34 +0800 (CST) Received: from dggpemf100008.china.huawei.com (unknown [7.185.36.138]) by mail.maildlp.com (Postfix) with ESMTPS id 873A618007E; Fri, 7 Jun 2024 12:38:33 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemf100008.china.huawei.com (7.185.36.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Fri, 7 Jun 2024 12:38:33 +0800 Message-ID: <20253c7b-fdf9-47db-a388-ab34b8658a2a@huawei.com> Date: Fri, 7 Jun 2024 12:38:32 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 01/13] mm/memory-failure: simplify put_ref_page() Content-Language: en-US To: Miaohe Lin CC: , , , , , , References: <20240606063247.712575-1-linmiaohe@huawei.com> <20240606063247.712575-2-linmiaohe@huawei.com> From: Kefeng Wang In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpemf100008.china.huawei.com (7.185.36.138) X-Rspamd-Queue-Id: 8788D1C0017 X-Stat-Signature: jk1a8m1c9pxije7hk8kfbssaq6wzap1n X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1717735119-868995 X-HE-Meta: U2FsdGVkX19nWDLXRIyENJvLgLxu1XXqPYKo4OYM5dY7hbSH4mV9yQOcqTGC9W3gK537cnJmOdtNGjROQMCyiNXreH/0gIOzyUD7/A2etviEn5cd9v0bILfjBuA2gW11ckdbhJNTRhBwFq7mSK2MYcqKLoX7B36Tg8rWBtDUXoEcxfEeCSauTP85/pApNhADtWm4bleitFvimoBXrDNTFaecqLjoo1lj0FZF4AR8AIPPyAdZm5z2qTKRCgqL5HVkm9f2Y5i275NxbRG+RASPixpAEGsL9Z5Ex60Ivi8X/r2UjpVo9X4UzeeG1paqbS8VbW0nB20RaTz0BckW8nKGgbywwafCWdDZWwAbarLVtB8rlt8UL2sd3zblja3Ox+8Lyo3Z1s/NZwVZZohfDUrUWo36j9kPkzFlZib8QGHsUSQjFFw7Io6Wp9F/3O+fGQPBOen0iTek51H/X8e7HXagGBCDj5VKGw6/WT9zYRz4tAmxZBDotF10G1TwRSpANfi6uPPPQIFiuPnipGyCkfhVd/7k2E2kZBjehAbxAhj1e7Ea70nV3fw8FgjfE0lSiIqL91uiz12Py5cnzXtlM9x8QtpKsRGg/DIwssRBD1gXeLJetbnSjCNXX08QpzuI9NLidR68TsGlDSGhHUEHyrDefQVitwtA4dOg87jUkJ+jfGoVlK/IiCBiXTlcjcaRbqPYEl1Jw9cxMQPSuyKFXbyXcgHnV4mTHPYkwyDUWQx/+yS9s7f1SjrPH1VFgg4Ed3nijCgYSKTFbmubPTDWW2yE7IoZwPO3KQFVlPXmKuopdYaIRVlQWMT27DxhnmxVBORkC8HRb7eOR5wm6PVbMeJdoWKa5sw2cbu7rl9xemHfyYWSlqq3CV1clwZwXEJfJJ8IS60q8C7Vctt1DAtHviJGm4VgD26irrJJr3grpMMiJgPpGMZAwHQNT2rLW22Vca3NL2HQ7rtCLUVYf/7Zohz qw1P58og m4WjjmiOUnzS+3e8CB+H2kqlRK88YOHh+U+8tGOV4KyAj7XbfqM3VvuWbLUILRUb7LXRv2Xg/1NM2cyPdKL6zigE74yDXjBAx+slQEBXGo9eC0woPaaaRsG5SzJwhFy/jI02d/sye+BhBVf2BNArRdaGBfVUEOrhjJO5nuCZgKl/cdyF/yiDGbrU23AVovQF2InfY0Z5/xa/r3nJl/9unLP30yxgr2JG+6b5ov8cNvDYZMIRLV2g1rSrSMdDpSn7m2xL1exCcVNIZwRKe2SU/On5iqLixMVDawph5XHc/OotBd3VvuByDLQWLjJ+0gVLzJ5ZpDaohtzRNxzrfWYjAIXG8AA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/6/7 11:28, Miaohe Lin wrote: > On 2024/6/6 14:46, Kefeng Wang wrote: >> >> >> On 2024/6/6 14:32, Miaohe Lin wrote: >>> Remove unneeded page != NULL check. pfn_to_page() won't return NULL. >>> No functional change intended. >>> >>> Signed-off-by: Miaohe Lin >>> --- >>>   mm/memory-failure.c | 6 +----- >>>   1 file changed, 1 insertion(+), 5 deletions(-) >>> >>> diff --git a/mm/memory-failure.c b/mm/memory-failure.c >>> index f679b579d45d..2e6038c73119 100644 >>> --- a/mm/memory-failure.c >>> +++ b/mm/memory-failure.c >>> @@ -2120,14 +2120,10 @@ static inline unsigned long folio_free_raw_hwp(struct folio *folio, bool flag) >>>   /* Drop the extra refcount in case we come from madvise() */ >>>   static void put_ref_page(unsigned long pfn, int flags) >> >> Since all calllers have a valid page，better to pass the page instead of pfn? > > Seems not. put_ref_page() called above memory_failure_dev_pagemap() seems don't have a valid page yet. > Also page might be NULL when calling put_ref_page() in soft_offline_page(). So it should be better to > still pass pfn. Or am I miss something? Yes, missing it, please ignore it > > Thanks. > . >