From: SeongJae Park <sj@kernel.org>
To: Asier Gutierrez <gutierrez.asier@huawei-partners.com>
Cc: SeongJae Park <sj@kernel.org>,
akpm@linux-foundation.org, damon@lists.linux.dev,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
wangkefeng.wang@huawei.com, artem.kuzin@huawei.com,
stepanov.anatoly@huawei.com
Subject: Re: [RFC PATCH v1] mm: improve call_controls_lock
Date: Mon, 29 Dec 2025 07:22:49 -0800 [thread overview]
Message-ID: <20251229152250.78975-1-sj@kernel.org> (raw)
In-Reply-To: <20251229145533.2437293-1-gutierrez.asier@huawei-partners.com>
Hello Asier,
Thank you for sending this patch!
On Mon, 29 Dec 2025 14:55:32 +0000 Asier Gutierrez <gutierrez.asier@huawei-partners.com> wrote:
> This is a minor patch set for a call_controls_lock synchronization improvement.
Please break description lines to not exceed 75 characters per line.
>
> Spinlocks are faster than mutexes, even when the mutex takes the fast
> path. Hence, this patch replaces the mutex call_controls_lock with a spinlock.
But call_controls_lock is not being used on performance critical part.
Actually, most of DAMON code is not performance critical. I really appreciate
your patch, but I have to say I don't think this change is really needed now.
Please let me know if I'm missing something.
>
> Initial benchmarking shows the following results
>
>
> # bpftrace -e 'kprobe:kdamond_call { @start[tid] = nsecs; }
Commit log shouldn't start with '#'. Please consider indenting the above
command and below outputs of it.
Thanks,
SJ
[...]
next prev parent reply other threads:[~2025-12-29 15:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-29 14:55 Asier Gutierrez
2025-12-29 15:22 ` SeongJae Park [this message]
2025-12-30 9:02 ` Gutierrez Asier
2025-12-31 5:01 ` SeongJae Park
2025-12-31 2:15 ` JaeJoon Jung
2025-12-31 4:59 ` SeongJae Park
2025-12-31 6:10 ` JaeJoon Jung
2025-12-31 7:51 ` JaeJoon Jung
2025-12-31 15:32 ` SeongJae Park
2026-01-01 1:11 ` JaeJoon Jung
2026-01-01 2:00 ` SeongJae Park
2026-01-01 2:34 ` JaeJoon Jung
2026-01-01 1:07 ` JaeJoon Jung
2026-01-01 1:51 ` SeongJae Park
2026-01-01 2:29 ` JaeJoon Jung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251229152250.78975-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=artem.kuzin@huawei.com \
--cc=damon@lists.linux.dev \
--cc=gutierrez.asier@huawei-partners.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=stepanov.anatoly@huawei.com \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox