From: Andrew Morton <akpm@linux-foundation.org>
To: wale zhang <wale.zhang.ftd@gmail.com>
Cc: Barry Song <21cnbao@gmail.com>,
lorenzo.stoakes@oracle.com, chrisl@kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH 1/1] mm,swapops: Fix compile error on set_pmd_migration_entry.
Date: Sun, 28 Dec 2025 13:37:42 -0800 [thread overview]
Message-ID: <20251228133742.a1f90fc552d346c4c43aad8b@linux-foundation.org> (raw)
In-Reply-To: <CAHrEdeuRtROkAN0zNdaYG_GBkSeW=-3kP3xBiQV1w51vGSc6Ew@mail.gmail.com>
On Sat, 27 Dec 2025 17:58:40 +0800 wale zhang <wale.zhang.ftd@gmail.com> wrote:
> > No. You still don’t understand my point. The BUILD_BUG means this
> > code will never have a chance to be compiled under any possible
> > kernel configuration. That makes it dead code. If there is any
> > kernel .config in which it can be built, then we should fix it.
> >
> > This set_pmd_migration_entry() has no chance of ever being built.
>
> Hello Barry,
>
Please share the .config which was used to trigger this build error.
(It is strange to have this should-never-be-compiled code. Why not just
delete it and let the compiler/linker report the error.)
next prev parent reply other threads:[~2025-12-28 21:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-25 9:40 Wale Zhang
2025-12-25 10:22 ` Barry Song
2025-12-26 11:45 ` wale zhang
2025-12-26 18:43 ` Barry Song
2025-12-27 7:51 ` wale zhang
2025-12-27 8:16 ` Barry Song
2025-12-27 9:58 ` wale zhang
2025-12-27 11:25 ` Barry Song
2025-12-28 21:37 ` Andrew Morton [this message]
2025-12-28 22:07 ` Barry Song
2025-12-29 11:37 ` wale zhang
2025-12-30 5:00 ` Matthew Wilcox
2025-12-30 8:05 ` wale zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251228133742.a1f90fc552d346c4c43aad8b@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=21cnbao@gmail.com \
--cc=chrisl@kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=wale.zhang.ftd@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox