From: 李喆 <lizhe.67@bytedance.com>
To: <muchun.song@linux.dev>, <osalvador@suse.de>, <david@kernel.org>,
<akpm@linux-foundation.org>, <fvdl@google.com>
Cc: <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
<lizhe.67@bytedance.com>
Subject: [PATCH 5/8] mm/hugetlb: simplify function hugetlb_sysfs_add_hstate()
Date: Thu, 25 Dec 2025 16:20:56 +0800 [thread overview]
Message-ID: <20251225082059.1632-6-lizhe.67@bytedance.com> (raw)
In-Reply-To: <20251225082059.1632-1-lizhe.67@bytedance.com>
From: Li Zhe <lizhe.67@bytedance.com>
The third parameter of hugetlb_sysfs_add_hstate() is currently an array
of struct kobject *, yet the function only ever uses a single element.
This patch narrows the argument to a pointer to that specific member,
eliminating the unused array.
Signed-off-by: Li Zhe <lizhe.67@bytedance.com>
---
mm/hugetlb_sysfs.c | 27 +++++++++++++--------------
1 file changed, 13 insertions(+), 14 deletions(-)
diff --git a/mm/hugetlb_sysfs.c b/mm/hugetlb_sysfs.c
index 8c3e433209c3..87dcd3038abc 100644
--- a/mm/hugetlb_sysfs.c
+++ b/mm/hugetlb_sysfs.c
@@ -304,31 +304,30 @@ static const struct attribute_group hstate_demote_attr_group = {
};
static int hugetlb_sysfs_add_hstate(struct hstate *h, struct kobject *parent,
- struct kobject **hstate_kobjs,
+ struct kobject **hstate_kobj,
const struct attribute_group *hstate_attr_group)
{
int retval;
- int hi = hstate_index(h);
- hstate_kobjs[hi] = kobject_create_and_add(h->name, parent);
- if (!hstate_kobjs[hi])
+ *hstate_kobj = kobject_create_and_add(h->name, parent);
+ if (!*hstate_kobj)
return -ENOMEM;
- retval = sysfs_create_group(hstate_kobjs[hi], hstate_attr_group);
+ retval = sysfs_create_group(*hstate_kobj, hstate_attr_group);
if (retval) {
- kobject_put(hstate_kobjs[hi]);
- hstate_kobjs[hi] = NULL;
+ kobject_put(*hstate_kobj);
+ *hstate_kobj = NULL;
return retval;
}
if (h->demote_order) {
- retval = sysfs_create_group(hstate_kobjs[hi],
+ retval = sysfs_create_group(*hstate_kobj,
&hstate_demote_attr_group);
if (retval) {
pr_warn("HugeTLB unable to create demote interfaces for %s\n", h->name);
- sysfs_remove_group(hstate_kobjs[hi], hstate_attr_group);
- kobject_put(hstate_kobjs[hi]);
- hstate_kobjs[hi] = NULL;
+ sysfs_remove_group(*hstate_kobj, hstate_attr_group);
+ kobject_put(*hstate_kobj);
+ *hstate_kobj = NULL;
return retval;
}
}
@@ -562,8 +561,8 @@ void hugetlb_register_node(struct node *node)
for_each_hstate(h) {
err = hugetlb_sysfs_add_hstate(h, nhs->hugepages_kobj,
- nhs->hstate_kobjs,
- &per_node_hstate_attr_group);
+ &nhs->hstate_kobjs[hstate_index(h)],
+ &per_node_hstate_attr_group);
if (err) {
pr_err("HugeTLB: Unable to add hstate %s for node %d\n",
h->name, node->dev.id);
@@ -610,7 +609,7 @@ void __init hugetlb_sysfs_init(void)
for_each_hstate(h) {
err = hugetlb_sysfs_add_hstate(h, hugepages_kobj,
- hstate_kobjs, &hstate_attr_group);
+ &hstate_kobjs[hstate_index(h)], &hstate_attr_group);
if (err)
pr_err("HugeTLB: Unable to add hstate %s\n", h->name);
}
--
2.20.1
next prev parent reply other threads:[~2025-12-25 8:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-25 8:20 [PATCH 0/8] Introduce a huge-page pre-zeroing mechanism 李喆
2025-12-25 8:20 ` [PATCH 1/8] mm/hugetlb: add pre-zeroed framework 李喆
2025-12-26 9:24 ` Raghavendra K T
2025-12-26 9:48 ` Li Zhe
2025-12-25 8:20 ` [PATCH 2/8] mm/hugetlb: convert to prep_account_new_hugetlb_folio() 李喆
2025-12-25 8:20 ` [PATCH 3/8] mm/hugetlb: move the huge folio to the end of the list during enqueue 李喆
2025-12-25 8:20 ` [PATCH 4/8] mm/hugetlb: introduce per-node sysfs interface "zeroable_hugepages" 李喆
2025-12-26 18:51 ` Frank van der Linden
2025-12-29 12:25 ` Li Zhe
2025-12-29 18:57 ` Frank van der Linden
2025-12-30 2:41 ` Li Zhe
2025-12-25 8:20 ` 李喆 [this message]
2025-12-25 8:20 ` [PATCH 6/8] mm/hugetlb: relocate the per-hstate struct kobject pointer 李喆
2025-12-25 8:20 ` [PATCH 7/8] mm/hugetlb: add epoll support for interface "zeroable_hugepages" 李喆
2025-12-25 8:20 ` [PATCH 8/8] mm/hugetlb: limit event generation frequency of function do_zero_free_notify() 李喆
2025-12-26 18:32 ` [PATCH 0/8] Introduce a huge-page pre-zeroing mechanism Frank van der Linden
2025-12-26 21:42 ` Frank van der Linden
2025-12-29 12:28 ` Li Zhe
2025-12-27 7:21 ` Mateusz Guzik
2025-12-29 12:31 ` Li Zhe
2025-12-28 21:44 ` Andrew Morton
2025-12-29 12:34 ` Li Zhe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251225082059.1632-6-lizhe.67@bytedance.com \
--to=lizhe.67@bytedance.com \
--cc=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=fvdl@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=muchun.song@linux.dev \
--cc=osalvador@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox