From: SeongJae Park <sj@kernel.org>
To: Shu Anzai <shu17az@gmail.com>
Cc: SeongJae Park <sj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
damon@lists.linux.dev, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/5] mm/damon/tests/core-kunit: remove a redundant test case and add a new test case in damos_test_commit_quota_goal()
Date: Tue, 23 Dec 2025 21:35:12 -0800 [thread overview]
Message-ID: <20251224053513.82011-1-sj@kernel.org> (raw)
In-Reply-To: <20251224042200.2061847-6-shu17az@gmail.com>
On Wed, 24 Dec 2025 04:22:00 +0000 Shu Anzai <shu17az@gmail.com> wrote:
> Remove a redundant test case from damos_test_commit_quota_goal()
> as it is already covered. Instead, add a new test for
> DAMOS_QUOTA_SOME_MEM_PSI_US, which was previously not tested.
>
> Signed-off-by: Shu Anzai <shu17az@gmail.com>
> ---
> mm/damon/tests/core-kunit.h | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/mm/damon/tests/core-kunit.h b/mm/damon/tests/core-kunit.h
> index 36622a2c11f1..4bf1d172436b 100644
> --- a/mm/damon/tests/core-kunit.h
> +++ b/mm/damon/tests/core-kunit.h
> @@ -601,9 +601,10 @@ static void damos_test_commit_quota_goal(struct kunit *test)
> });
> damos_test_commit_quota_goal_for(test, &dst,
> &(struct damos_quota_goal) {
> - .metric = DAMOS_QUOTA_USER_INPUT,
> - .target_value = 789,
> - .current_value = 12,
> + .metric = DAMOS_QUOTA_SOME_MEM_PSI_US,
> + .target_value = 234,
> + .current_value = 345,
> + .last_psi_total = 567,
> });
> }
>
> --
> 2.43.0
Reviewed-by: SeongJae Park <sj@kernel.org>
Thanks,
SJ
next prev parent reply other threads:[~2025-12-24 5:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-24 4:21 [PATCH v2 0/5] mm/damon/tests/core-kunit: extend existing test scenarios Shu Anzai
2025-12-24 4:21 ` [PATCH v2 1/5] mm/damon/tests/core-kunit: verify the 'age' field in damon_test_split_at() Shu Anzai
2025-12-24 5:26 ` SeongJae Park
2025-12-24 4:21 ` [PATCH v2 2/5] mm/damon/tests/core-kunit: verify the 'age' and 'nr_accesses_bp' fields in damon_test_merge_two() Shu Anzai
2025-12-24 5:27 ` SeongJae Park
2025-12-24 4:21 ` [PATCH v2 3/5] mm/damon/tests/core-kunit: add a test case for region merge size limit in damon_test_merge_regions_of() Shu Anzai
2025-12-24 5:29 ` SeongJae Park
2025-12-24 4:21 ` [PATCH v2 4/5] mm/damon/tests/core-kunit: add test cases for multiple regions in damon_test_split_regions_of() Shu Anzai
2025-12-24 5:34 ` SeongJae Park
2025-12-24 15:31 ` SeongJae Park
2025-12-24 4:22 ` [PATCH v2 5/5] mm/damon/tests/core-kunit: remove a redundant test case and add a new test case in damos_test_commit_quota_goal() Shu Anzai
2025-12-24 5:35 ` SeongJae Park [this message]
2025-12-24 5:38 ` [PATCH v2 0/5] mm/damon/tests/core-kunit: extend existing test scenarios SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251224053513.82011-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shu17az@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox