linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Mark Brown <broonie@kernel.org>,
	linux-mm@kvack.org
Subject: [PATCH v1 5/5] tsacct: Skip all kernel threads
Date: Sun, 21 Dec 2025 18:29:26 -0500	[thread overview]
Message-ID: <20251221232926.450602-6-mathieu.desnoyers@efficios.com> (raw)
In-Reply-To: <20251221232926.450602-1-mathieu.desnoyers@efficios.com>

When we hit acct_account_cputime within a irq handler over a kthread
that happens to use a userspace mm, we end up summing up the mm's RSS
into the tsk acct_rss_mem1, which eventually decays.

I don't see a good rationale behind tracking the mm's rss in that way
when a kthread use a userspace mm temporarily through use_mm.

It causes issues with init_mm and efi_mm which only partially initialize
their mm_struct.

Skip all kernel threads in acct_account_cputime(), not just those that
happen to have a NULL mm.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Mark Brown <broonie@kernel.org>
Cc: linux-mm@kvack.org
---
 kernel/tsacct.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/tsacct.c b/kernel/tsacct.c
index 6ea2f6363b90..3ef149b1245d 100644
--- a/kernel/tsacct.c
+++ b/kernel/tsacct.c
@@ -125,7 +125,7 @@ static void __acct_update_integrals(struct task_struct *tsk,
 {
 	u64 time, delta;
 
-	if (!likely(tsk->mm))
+	if (!tsk->mm || (tsk->flags & PF_KTHREAD))
 		return;
 
 	time = stime + utime;
-- 
2.39.5



  parent reply	other threads:[~2025-12-21 23:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-21 23:29 [PATCH v1 0/5] MM_CID and HPCC mm_struct static init fixes Mathieu Desnoyers
2025-12-21 23:29 ` [PATCH v1 1/5] mm: Add missing static initializer for init_mm::mm_cid.lock Mathieu Desnoyers
2025-12-21 23:29 ` [PATCH v1 2/5] mm: Rename cpu_bitmap field to flexible_array Mathieu Desnoyers
2025-12-21 23:29 ` [PATCH v1 3/5] mm: Take into account mm_cid size for mm_struct static definitions Mathieu Desnoyers
2025-12-21 23:29 ` [PATCH v1 4/5] mm: Take into account hierarchical percpu tree items for static mm_struct definitions Mathieu Desnoyers
2025-12-21 23:29 ` Mathieu Desnoyers [this message]
2025-12-23  1:59 ` [PATCH v1 0/5] MM_CID and HPCC mm_struct static init fixes Andrew Morton
2025-12-24 16:37   ` Mathieu Desnoyers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251221232926.450602-6-mathieu.desnoyers@efficios.com \
    --to=mathieu.desnoyers@efficios.com \
    --cc=akpm@linux-foundation.org \
    --cc=broonie@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox