linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Chunyu Hu <chuhu@redhat.com>
To: akpm@linux-foundation.org, david@kernel.org, shuah@kernel.org,
	linux-mm@kvack.org
Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
	lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com,
	vbabka@suse.cz, rppt@kernel.org, surenb@google.com,
	mhocko@suse.com, chuhu@redhat.com,
	Luiz Capitulino <luizcap@redhat.com>
Subject: [PATCH v2 1/5] selftests/mm: fix va_high_addr_switch.sh return value
Date: Sun, 21 Dec 2025 12:00:21 +0800	[thread overview]
Message-ID: <20251221040025.3159990-1-chuhu@redhat.com> (raw)

Patch series "Fix va_high_addr_switch.sh test failure - again", v2.

The series address several issues exist for the va_high_addr_switch test:
1) the test return value is ignored in va_high_addr_switch.sh.
2) the va_high_addr_switch test requires 6 hugepages not 5.
3) the reurn value of the first test in va_high_addr_switch.c can be
   overridden by the second test.
4) the nr_hugepages setup in run_vmtests.sh for arm64 can be done in
   va_high_addr_switch.sh too.
5) update a comment for check_test_requirements.

Changes in v2:
 - shorten the comment in for hugepages setup in v1
 - add a new patch to fix the return value overridden issue in
   va_high_addr_switch.c
 - fix a code comment for check_test_requirements.
 - update the series summary in patch 1
 - add reviewed-by from Luiz Capitulino on patch 1 and patch 3

This patch: (of 5)

The return value should be return value of va_high_addr_switch, otherwise
a test failure would be silently ignored.

Reviewed-by: Luiz Capitulino <luizcap@redhat.com>
Fixes: d9d957bd7b61 ("selftests/mm: alloc hugepages in va_high_addr_switch test")
CC: Luiz Capitulino <luizcap@redhat.com>
Signed-off-by: Chunyu Hu <chuhu@redhat.com>
---
Chunyu Hu (5):
  selftests/mm: fix va_high_addr_switch.sh return value
  selftests/mm: allocate 6 hugepages in va_high_addr_switch.sh
  selftests/mm: remove arm64 nr_hugepages setup for va_high_addr_switch
    test
  selftests/mm: va_high_addr_switch return fail when either test failed
  selftests/mm: fix comment for check_test_requirements

 tools/testing/selftests/mm/run_vmtests.sh         |  8 --------
 tools/testing/selftests/mm/va_high_addr_switch.c  | 10 +++++++---
 tools/testing/selftests/mm/va_high_addr_switch.sh | 12 +++++++-----
 3 files changed, 14 insertions(+), 16 deletions(-)

According to the doc below, I don't add the cover letter, not sure if cover
letter is preferred, and if that's the case, the doc need an update.
https://www.ozlabs.org/~akpm/stuff/tpp.txt
---
 tools/testing/selftests/mm/va_high_addr_switch.sh | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/testing/selftests/mm/va_high_addr_switch.sh b/tools/testing/selftests/mm/va_high_addr_switch.sh
index a7d4b02b21dd..f89fe078a8e6 100755
--- a/tools/testing/selftests/mm/va_high_addr_switch.sh
+++ b/tools/testing/selftests/mm/va_high_addr_switch.sh
@@ -114,4 +114,6 @@ save_nr_hugepages
 # 4 keep_mapped pages, and one for tmp usage
 setup_nr_hugepages 5
 ./va_high_addr_switch --run-hugetlb
+retcode=$?
 restore_nr_hugepages
+exit $retcode
-- 
2.49.0



             reply	other threads:[~2025-12-21  4:00 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-21  4:00 Chunyu Hu [this message]
2025-12-21  4:00 ` [PATCH v2 2/5] selftests/mm: allocate 6 hugepages in va_high_addr_switch.sh Chunyu Hu
2025-12-21  4:00   ` [PATCH v2 3/5] selftests/mm: remove arm64 nr_hugepages setup for va_high_addr_switch test Chunyu Hu
2025-12-21  4:00     ` [PATCH v2 4/5] selftests/mm: va_high_addr_switch return fail when either test failed Chunyu Hu
2025-12-21  4:00       ` [PATCH v2 5/5] selftests/mm: fix comment for check_test_requirements Chunyu Hu
2025-12-22 19:37         ` Luiz Capitulino
2025-12-22 19:36       ` [PATCH v2 4/5] selftests/mm: va_high_addr_switch return fail when either test failed Luiz Capitulino
2025-12-23  2:46         ` Chunyu Hu
2025-12-23  2:56           ` Andrew Morton
2025-12-23  3:04             ` Chunyu Hu
2025-12-22 19:34   ` [PATCH v2 2/5] selftests/mm: allocate 6 hugepages in va_high_addr_switch.sh Luiz Capitulino
2025-12-21 18:57 ` [PATCH v2 1/5] selftests/mm: fix va_high_addr_switch.sh return value Andrew Morton
2025-12-22  4:32   ` Chunyu Hu
2025-12-23  1:15     ` SeongJae Park
2025-12-23  2:54       ` Chunyu Hu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251221040025.3159990-1-chuhu@redhat.com \
    --to=chuhu@redhat.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=david@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=luizcap@redhat.com \
    --cc=mhocko@suse.com \
    --cc=rppt@kernel.org \
    --cc=shuah@kernel.org \
    --cc=surenb@google.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox