From: Andrew Morton <akpm@linux-foundation.org>
To: SeongJae Park <sj@kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
damon@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH 12/12] mm/damon/core: add trace point for damos stat per apply interval
Date: Wed, 17 Dec 2025 18:29:15 -0800 [thread overview]
Message-ID: <20251217182915.5284d66b58ac7b744b8dcf7f@linux-foundation.org> (raw)
In-Reply-To: <20251217235219.2750-1-sj@kernel.org>
On Wed, 17 Dec 2025 15:52:18 -0800 SeongJae Park <sj@kernel.org> wrote:
> On Wed, 17 Dec 2025 17:48:51 -0500 Steven Rostedt <rostedt@goodmis.org> wrote:
>
> > On Tue, 16 Dec 2025 00:01:25 -0800
> > SeongJae Park <sj@kernel.org> wrote:
> >
> > > + TP_printk("ctx_idx=%u scheme_idx=%u nr_tried=%lu sz_tried=%lu "
> > > + "nr_applied=%lu sz_tried=%lu sz_ops_filter_passed=%lu "
> > > + "qt_exceeds=%lu nr_snapshots=%lu",
> >
> > Nit, but it's been stated that strings should not be broken up because of
> > the column limit.
screw the rules
> --- a/include/trace/events/damon.h
> +++ b/include/trace/events/damon.h
> @@ -40,9 +40,7 @@ TRACE_EVENT(damos_stat_after_apply_interval,
> __entry->nr_snapshots = stat->nr_snapshots;
> ),
>
> - TP_printk("ctx_idx=%u scheme_idx=%u nr_tried=%lu sz_tried=%lu "
> - "nr_applied=%lu sz_tried=%lu sz_ops_filter_passed=%lu "
> - "qt_exceeds=%lu nr_snapshots=%lu",
> + TP_printk("ctx_idx=%u scheme_idx=%u nr_tried=%lu sz_tried=%lu nr_applied=%lu sz_tried=%lu sz_ops_filter_passed=%lu qt_exceeds=%lu nr_snapshots=%lu",
> __entry->context_idx, __entry->scheme_idx,
> __entry->nr_tried, __entry->sz_tried,
> __entry->nr_applied, __entry->sz_applied,
because that's just crazy. Let's use some judgment here!
next prev parent reply other threads:[~2025-12-18 2:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-16 8:01 [PATCH 00/12] mm/damon: introduce {,max_}nr_snapshots and tracepoint for damos stats SeongJae Park
2025-12-16 8:01 ` [PATCH 01/12] mm/damon/core: introduce nr_snapshots damos stat SeongJae Park
2025-12-16 8:01 ` [PATCH 02/12] mm/damon/sysfs-schemes: introduce nr_snapshots damos stat file SeongJae Park
2025-12-16 8:01 ` [PATCH 03/12] Docs/mm/damon/design: update for nr_snapshots damos stat SeongJae Park
2025-12-16 8:01 ` [PATCH 04/12] Docs/admin-guide/mm/damon/usage: " SeongJae Park
2025-12-16 8:01 ` [PATCH 05/12] Docs/ABI/damon: " SeongJae Park
2025-12-16 8:01 ` [PATCH 06/12] mm/damon: update damos kerneldoc for stat field SeongJae Park
2025-12-16 8:01 ` [PATCH 07/12] mm/damon/core: implement max_nr_snapshots SeongJae Park
2025-12-16 8:01 ` [PATCH 08/12] mm/damon/sysfs-schemes: implement max_nr_snapshots file SeongJae Park
2025-12-16 8:01 ` [PATCH 09/12] Docs/mm/damon/design: update for max_nr_snapshots SeongJae Park
2025-12-16 8:01 ` [PATCH 10/12] Docs/admin-guide/mm/damon/usage: " SeongJae Park
2025-12-16 8:01 ` [PATCH 11/12] Docs/ABI/damon: " SeongJae Park
2025-12-16 8:01 ` [PATCH 12/12] mm/damon/core: add trace point for damos stat per apply interval SeongJae Park
2025-12-17 22:48 ` Steven Rostedt
2025-12-17 23:52 ` SeongJae Park
2025-12-18 2:29 ` Andrew Morton [this message]
2025-12-18 3:04 ` SeongJae Park
2025-12-18 17:29 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251217182915.5284d66b58ac7b744b8dcf7f@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox