linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Joshua Hahn <joshua.hahnjy@gmail.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Daniel Palmer <daniel@0x0f.com>,
	Brendan Jackman <jackmanb@google.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Michal Hocko <mhocko@suse.com>,
	Suren Baghdasaryan <surenb@google.com>,
	Vlastimil Babka <vbabka@suse.cz>, Zi Yan <ziy@nvidia.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	kernel-team@meta.com
Subject: Re: [PATCH v3] mm/page_alloc: prevent reporting pcp->batch = 0
Date: Tue, 16 Dec 2025 06:42:21 -0800	[thread overview]
Message-ID: <20251216144222.2982594-1-joshua.hahnjy@gmail.com> (raw)
In-Reply-To: <aUFt6Q7TIbFV9v95@casper.infradead.org>

On Tue, 16 Dec 2025 14:34:17 +0000 Matthew Wilcox <willy@infradead.org> wrote:

> On Tue, Dec 16, 2025 at 06:27:53AM -0800, Joshua Hahn wrote:
> >  	batch = min(zone_managed_pages(zone) >> 12, SZ_256K / PAGE_SIZE);
> > -	if (batch < 1)
> > +	if (batch <= 1)
> >  		batch = 1;
> >  
> 
> This seems like a no-op to me.  Did you send the right patch?

Hello Matthew,

Thank you for the quick catch, you're totally right. In the original patch [1]
it is also supposed to just return 1 there, but I think I got flustered when
I initially got the bug report and forgot to include that [2]. Sorry for the
mistake, I'll send out a new version with the correct fix.

Thanks again, I hope you have a great day!
Joshua

[1] https://lore.kernel.org/all/20251009192933.3756712-3-joshua.hahnjy@gmail.com/
[2] https://lore.kernel.org/all/20251212015330.1874521-1-joshua.hahnjy@gmail.com/


      reply	other threads:[~2025-12-16 14:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-16 14:27 Joshua Hahn
2025-12-16 14:34 ` Matthew Wilcox
2025-12-16 14:42   ` Joshua Hahn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251216144222.2982594-1-joshua.hahnjy@gmail.com \
    --to=joshua.hahnjy@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=daniel@0x0f.com \
    --cc=hannes@cmpxchg.org \
    --cc=jackmanb@google.com \
    --cc=kernel-team@meta.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=surenb@google.com \
    --cc=vbabka@suse.cz \
    --cc=willy@infradead.org \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox