linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Brodsky <kevin.brodsky@arm.com>
To: linux-mm@kvack.org, linux-kselftest@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
	Kevin Brodsky <kevin.brodsky@arm.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	David Hildenbrand <david@kernel.org>,
	Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
	Mark Brown <broonie@kernel.org>,
	Ryan Roberts <ryan.roberts@arm.com>,
	Shuah Khan <shuah@kernel.org>, Usama Anjum <Usama.Anjum@arm.com>
Subject: [PATCH 4/4] selftests/mm: fix exit code in pagemap_ioctl
Date: Tue, 16 Dec 2025 14:26:33 +0000	[thread overview]
Message-ID: <20251216142633.2401447-5-kevin.brodsky@arm.com> (raw)
In-Reply-To: <20251216142633.2401447-1-kevin.brodsky@arm.com>

pagemap_ioctl always reports success, whether the tests succeeded or
not. Call ksft_finished() to report the right status.

While at it also fix the exit code in unexpected situations:

- Report SKIP if userfaultfd isn't available (in line with other
  tests)

- Report FAIL if we failed to open /proc/self/pagemap (returning
  -EINVAL from main() is meaningless)

Cc: Usama Anjum <Usama.Anjum@arm.com>
Signed-off-by: Kevin Brodsky <kevin.brodsky@arm.com>
---
 tools/testing/selftests/mm/pagemap_ioctl.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/testing/selftests/mm/pagemap_ioctl.c b/tools/testing/selftests/mm/pagemap_ioctl.c
index 67a7a3705604..aeedb96dfffb 100644
--- a/tools/testing/selftests/mm/pagemap_ioctl.c
+++ b/tools/testing/selftests/mm/pagemap_ioctl.c
@@ -1553,7 +1553,7 @@ int main(int __attribute__((unused)) argc, char *argv[])
 	ksft_print_header();
 
 	if (init_uffd())
-		ksft_exit_pass();
+		ksft_exit_skip("Failed to initialize userfaultfd\n");
 
 	ksft_set_plan(117);
 
@@ -1562,7 +1562,7 @@ int main(int __attribute__((unused)) argc, char *argv[])
 
 	pagemap_fd = open(PAGEMAP, O_RDONLY);
 	if (pagemap_fd < 0)
-		return -EINVAL;
+		ksft_exit_fail_msg("Failed to open " PAGEMAP "\n");
 
 	/* 1. Sanity testing */
 	sanity_tests_sd();
@@ -1734,5 +1734,5 @@ int main(int __attribute__((unused)) argc, char *argv[])
 	zeropfn_tests();
 
 	close(pagemap_fd);
-	ksft_exit_pass();
+	ksft_finished();
 }
-- 
2.51.2



  parent reply	other threads:[~2025-12-16 14:26 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-16 14:26 [PATCH 0/4] Various mm kselftests improvements/fixes Kevin Brodsky
2025-12-16 14:26 ` [PATCH 1/4] selftests/mm: remove flaky header check Kevin Brodsky
2025-12-17  3:18   ` Yunsheng Lin
2025-12-17  9:58     ` Kevin Brodsky
2025-12-18  7:21       ` Yunsheng Lin
2025-12-17 10:04   ` Mark Brown
2025-12-18 13:24     ` Kevin Brodsky
2025-12-18 14:25       ` Mark Brown
2025-12-29 15:40         ` Kevin Brodsky
2025-12-16 14:26 ` [PATCH 2/4] selftests/mm: pass down full CC and CFLAGS to check_config.sh Kevin Brodsky
2025-12-18  8:04   ` David Hildenbrand (Red Hat)
2025-12-16 14:26 ` [PATCH 3/4] selftests/mm: fix faulting-in code in pagemap_ioctl test Kevin Brodsky
2025-12-16 14:56   ` Ryan Roberts
2025-12-16 15:11     ` Kevin Brodsky
2025-12-18  8:05     ` David Hildenbrand (Red Hat)
2025-12-18 13:18       ` Kevin Brodsky
2025-12-19  8:29         ` David Hildenbrand (Red Hat)
2025-12-29 11:46           ` Kevin Brodsky
2025-12-16 14:26 ` Kevin Brodsky [this message]
2025-12-16 14:58   ` [PATCH 4/4] selftests/mm: fix exit code in pagemap_ioctl Ryan Roberts
2025-12-17 10:08   ` Mark Brown
2025-12-18 13:20     ` Kevin Brodsky
2025-12-18  8:07   ` David Hildenbrand (Red Hat)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251216142633.2401447-5-kevin.brodsky@arm.com \
    --to=kevin.brodsky@arm.com \
    --cc=Usama.Anjum@arm.com \
    --cc=akpm@linux-foundation.org \
    --cc=broonie@kernel.org \
    --cc=david@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=ryan.roberts@arm.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox