From: Andrew Morton <akpm@linux-foundation.org>
To: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: Weilin Tong <tongweilin@linux.alibaba.com>,
Hugh Dickins <hughd@google.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/shmem: add mTHP swpout fallback statistics in shmem_writeout()
Date: Tue, 16 Dec 2025 11:36:19 -0800 [thread overview]
Message-ID: <20251216113619.af93c4c37f8e880a14516a2f@linux-foundation.org> (raw)
In-Reply-To: <3c86d612-aab7-4e80-bc6a-3ccf2bab9c34@arm.com>
On Tue, 16 Dec 2025 12:04:02 +0530 Anshuman Khandual <anshuman.khandual@arm.com> wrote:
> > --- a/mm/shmem.c
> > +++ b/mm/shmem.c
> > @@ -1593,11 +1593,23 @@ int shmem_writeout(struct folio *folio, struct swap_iocb **plug,
> > }
> >
> > if (split) {
> > + int order;
> > +
>
> Could this be moved up near the 'nr_pages' declaration instead ?
It could, but I think it's good practice to restrict the scope of
things to "no more than necessary"?
prev parent reply other threads:[~2025-12-16 19:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-15 2:46 Weilin Tong
2025-12-16 6:34 ` Anshuman Khandual
2025-12-16 12:21 ` Weilin Tong
2025-12-16 19:36 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251216113619.af93c4c37f8e880a14516a2f@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tongweilin@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox