linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: SeongJae Park <sj@kernel.org>
To: JaeJoon Jung <rgbi3307@gmail.com>
Cc: SeongJae Park <sj@kernel.org>, damon@lists.linux.dev, linux-mm@kvack.org
Subject: Re: [PATCH] mm/damon: modified damon_call_control from static to kmalloc
Date: Thu, 11 Dec 2025 19:46:12 -0800	[thread overview]
Message-ID: <20251212034613.41033-1-sj@kernel.org> (raw)
In-Reply-To: <CAHOvCC6ixeLQeTJANkAvQhRviLyr7=xNBs-_jeKEo+qF6E3qAg@mail.gmail.com>

On Thu, 11 Dec 2025 17:13:09 +0900 JaeJoon Jung <rgbi3307@gmail.com> wrote:

> On Thu, 11 Dec 2025 at 16:54, SeongJae Park <sj@kernel.org> wrote:
> >
> > On Thu, 11 Dec 2025 16:38:46 +0900 JaeJoon Jung <rgbi3307@gmail.com> wrote:
> >
> > > On Thu, 11 Dec 2025 at 15:04, SeongJae Park <sj@kernel.org> wrote:
> > [...]
> > > > Sounds good.  Would you mind sending a patch for that?
> > >
> > > Would you like me to send you the patch with only the comments corrected?
> >
> > I was just asking your preferrence, and seems you have no strong one.  I will
> > do that on my own unless you mind.
> 
> I have been argued the following so far:
> "I proposed unifying them into kmalloc()/kfree() methods and
> removing the dealloc_on_cancel."

Based on your previous email [1], I understand you argue this patch is better
to be merged as-is, though you agree it has the pros and the cons.  And
therefore you are letting me to make the final decision.

I was implicitly saying I show the cons more than the pros, so don't want to
merge this as is.  Sorry if it was too implicit.  Hope now my opinion is
clearly reached out to you.

I also suggested making the comment better, and you agreed it but I understand
you are not interested in making that change.  I will do it.

So, all is well and no more action from your side is required.

> I apologize for not being able to respond promptly and smoothly
> this week due to a busy my external lecture schedule.

No worry, take your time.

[1] https://lore.kernel.org/CAHOvCC6bJLf=LuBpm90n5poz8Sqhz9wjXtk5ypbPwkvhb1ptag@mail.gmail.com


Thanks,
SJ

[...]


  reply	other threads:[~2025-12-12  3:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-06 22:47 JaeJoon Jung
2025-12-07  2:36 ` SeongJae Park
2025-12-09 12:20   ` JaeJoon Jung
2025-12-10  2:54     ` SeongJae Park
2025-12-11  3:29       ` JaeJoon Jung
2025-12-11  6:04         ` SeongJae Park
2025-12-11  7:38           ` JaeJoon Jung
2025-12-11  7:54             ` SeongJae Park
2025-12-11  8:13               ` JaeJoon Jung
2025-12-12  3:46                 ` SeongJae Park [this message]
2025-12-12  7:30                   ` JaeJoon Jung

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251212034613.41033-1-sj@kernel.org \
    --to=sj@kernel.org \
    --cc=damon@lists.linux.dev \
    --cc=linux-mm@kvack.org \
    --cc=rgbi3307@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox