From: Samuel Holland <samuel.holland@sifive.com>
To: Andrew Morton <akpm@linux-foundation.org>,
"Liam R . Howlett" <Liam.Howlett@oracle.com>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
David Hildenbrand <david@kernel.org>,
Vlastimil Babka <vbabka@suse.cz>, Jann Horn <jannh@google.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Ryan Roberts <ryan.roberts@arm.com>,
Anshuman Khandual <anshuman.khandual@arm.com>,
Gavin Shan <gshan@redhat.com>, Zi Yan <ziy@nvidia.com>,
Samuel Holland <samuel.holland@sifive.com>
Subject: [PATCH 2/2] mm/madvise: Use set_pte() to write page tables
Date: Thu, 11 Dec 2025 00:11:12 -0800 [thread overview]
Message-ID: <20251211081117.1126521-3-samuel.holland@sifive.com> (raw)
In-Reply-To: <20251211081117.1126521-1-samuel.holland@sifive.com>
Generic code must always use the architecture-provided helper function
to write page tables.
Fixes: 662df3e5c376 ("mm: madvise: implement lightweight guard page mechanism")
Signed-off-by: Samuel Holland <samuel.holland@sifive.com>
---
mm/madvise.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/madvise.c b/mm/madvise.c
index b617b1be0f535..4da9c32f8738a 100644
--- a/mm/madvise.c
+++ b/mm/madvise.c
@@ -1114,7 +1114,7 @@ static int guard_install_set_pte(unsigned long addr, unsigned long next,
unsigned long *nr_pages = (unsigned long *)walk->private;
/* Simply install a PTE marker, this causes segfault on access. */
- *ptep = make_pte_marker(PTE_MARKER_GUARD);
+ set_pte(ptep, make_pte_marker(PTE_MARKER_GUARD));
(*nr_pages)++;
return 0;
--
2.47.2
next prev parent reply other threads:[~2025-12-11 8:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-11 8:11 [PATCH 0/2] mm: Always use set_pXX() helpers " Samuel Holland
2025-12-11 8:11 ` [PATCH 1/2] mm/debug_vm_pgtable: Use set_pXd() " Samuel Holland
2025-12-11 9:36 ` Ryan Roberts
2025-12-15 10:33 ` Lorenzo Stoakes
2025-12-12 0:48 ` kernel test robot
2025-12-12 12:11 ` kernel test robot
2025-12-11 8:11 ` Samuel Holland [this message]
2025-12-11 9:43 ` [PATCH 2/2] mm/madvise: Use set_pte() " Ryan Roberts
2025-12-15 10:37 ` Lorenzo Stoakes
2025-12-15 10:57 ` Ryan Roberts
2025-12-16 10:16 ` Lorenzo Stoakes
2025-12-11 23:40 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251211081117.1126521-3-samuel.holland@sifive.com \
--to=samuel.holland@sifive.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=david@kernel.org \
--cc=gshan@redhat.com \
--cc=jannh@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=ryan.roberts@arm.com \
--cc=vbabka@suse.cz \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox