linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Wei Yang <richard.weiyang@gmail.com>
To: akpm@linux-foundation.org, david@kernel.org,
	lorenzo.stoakes@oracle.com, ziy@nvidia.com,
	baolin.wang@linux.alibaba.com, Liam.Howlett@oracle.com,
	npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com,
	baohua@kernel.org, lance.yang@linux.dev, linmiaohe@huawei.com,
	nao.horiguchi@gmail.com
Cc: linux-mm@kvack.org, Wei Yang <richard.weiyang@gmail.com>
Subject: [RFC Patch  04/11] mm/memory-failure: convert try_to_split_thp_page() to use split_folio_to_order()
Date: Mon,  8 Dec 2025 14:36:09 +0000	[thread overview]
Message-ID: <20251208143616.20797-5-richard.weiyang@gmail.com> (raw)
In-Reply-To: <20251208143616.20797-1-richard.weiyang@gmail.com>

The function try_to_split_thp_page() currently uses the page-style
split_huge_page_to_order() API to split a huge page.

Since the returned page is immediately unlocked after the split
completes, the specific locking behavior of split_huge_page_to_order()
(returning the page locked) is irrelevant here.

This allows us to replace the call with the folio-style equivalent,
split_folio_to_order(). This conversion improves code consistency
by adopting the modern folio API throughout the THP splitting
logic.

Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
Cc: Zi Yan <ziy@nvidia.com>
---
 include/linux/huge_mm.h | 6 ++++++
 mm/memory-failure.c     | 7 ++++---
 2 files changed, 10 insertions(+), 3 deletions(-)

diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h
index 3e01184cf274..872b4ed2a477 100644
--- a/include/linux/huge_mm.h
+++ b/include/linux/huge_mm.h
@@ -647,6 +647,12 @@ static inline int split_folio_to_list(struct folio *folio, struct list_head *lis
 	return -EINVAL;
 }
 
+static inline int split_folio_to_order(struct folio *folio, int new_order)
+{
+	VM_WARN_ON_ONCE_FOLIO(1, folio);
+	return -EINVAL;
+}
+
 static inline int try_folio_split_to_order(struct folio *folio,
 		struct page *page, unsigned int new_order)
 {
diff --git a/mm/memory-failure.c b/mm/memory-failure.c
index fbc5a01260c8..600666491f52 100644
--- a/mm/memory-failure.c
+++ b/mm/memory-failure.c
@@ -1665,11 +1665,12 @@ static int identify_page_state(unsigned long pfn, struct page *p,
 static int try_to_split_thp_page(struct page *page, unsigned int new_order,
 		bool release)
 {
+	struct folio *folio = page_folio(page);
 	int ret;
 
-	lock_page(page);
-	ret = split_huge_page_to_order(page, new_order);
-	unlock_page(page);
+	folio_lock(folio);
+	ret = split_folio_to_order(folio, new_order);
+	folio_unlock(folio);
 
 	if (ret && release)
 		put_page(page);
-- 
2.34.1



  parent reply	other threads:[~2025-12-08 14:36 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-08 14:36 [RFC Patch 00/11] Convert huge page split API to folio-style Wei Yang
2025-12-08 14:36 ` [RFC Patch 01/11] mm/huge_memory: relocate fundamental folio split comment to __folio_split() Wei Yang
2025-12-08 14:36 ` [RFC Patch 02/11] mm/huge_memory: remove split_folio_to_list_to_order() helper Wei Yang
2025-12-08 14:36 ` [RFC Patch 03/11] mm/huge_memory: convert try_folio_split_to_order() to use split_folio_to_order() Wei Yang
2025-12-08 14:36 ` Wei Yang [this message]
2025-12-08 14:36 ` [RFC Patch 05/11] mm/huge_memory: remove unused function split_huge_page_to_order() Wei Yang
2025-12-08 14:36 ` [RFC Patch 06/11] mm/huge_memory: introduce __split_folio_and_update_stats() to consolidate split task Wei Yang
2025-12-08 14:36 ` [RFC Patch 07/11] mm/huge_memory: separate uniform/non uniform split logic in __split_unmapped_folio() Wei Yang
2025-12-08 14:36 ` [RFC Patch 08/11] mm/huge_memory: restrict @split_at check to non-uniform splits Wei Yang
2025-12-08 14:36 ` [RFC Patch 09/11] mm/huge_memory: introduce folio_split_uniform() helper for uniform splitting Wei Yang
2025-12-08 14:36 ` [RFC Patch 10/11] mm/huge_memory: convert folio split helpers to use folio_split_uniform() Wei Yang
2025-12-08 14:36 ` [RFC Patch 11/11] mm/huge_memory: simplify split_huge_page() by calling __folio_split() directly Wei Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251208143616.20797-5-richard.weiyang@gmail.com \
    --to=richard.weiyang@gmail.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=baohua@kernel.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=david@kernel.org \
    --cc=dev.jain@arm.com \
    --cc=lance.yang@linux.dev \
    --cc=linmiaohe@huawei.com \
    --cc=linux-mm@kvack.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=nao.horiguchi@gmail.com \
    --cc=npache@redhat.com \
    --cc=ryan.roberts@arm.com \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox