From: Boris Brezillon <boris.brezillon@collabora.com>
To: "Loïc Molinari" <loic.molinari@collabora.com>
Cc: "Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Jani Nikula" <jani.nikula@linux.intel.com>,
"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Tvrtko Ursulin" <tursulin@ursulin.net>,
"Rob Herring" <robh@kernel.org>,
"Steven Price" <steven.price@arm.com>,
"Liviu Dudau" <liviu.dudau@arm.com>,
"Melissa Wen" <mwen@igalia.com>,
"Maíra Canal" <mcanal@igalia.com>,
"Hugh Dickins" <hughd@google.com>,
"Baolin Wang" <baolin.wang@linux.alibaba.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Al Viro" <viro@zeniv.linux.org.uk>,
"Mikołaj Wasiak" <mikolaj.wasiak@intel.com>,
"Christian Brauner" <brauner@kernel.org>,
"Nitin Gote" <nitin.r.gote@intel.com>,
"Andi Shyti" <andi.shyti@linux.intel.com>,
"Jonathan Corbet" <corbet@lwn.net>,
"Christopher Healy" <healych@amazon.com>,
"Matthew Wilcox" <willy@infradead.org>,
"Bagas Sanjaya" <bagasdotme@gmail.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
intel-gfx@lists.freedesktop.org, linux-mm@kvack.org,
linux-doc@vger.kernel.org, kernel@collabora.com
Subject: Re: [PATCH v13 00/10] drm: Reduce page tables overhead with THP
Date: Mon, 8 Dec 2025 12:29:41 +0100 [thread overview]
Message-ID: <20251208122941.61bea21d@fedora> (raw)
In-Reply-To: <20251205182231.194072-1-loic.molinari@collabora.com>
On Fri, 5 Dec 2025 19:22:21 +0100
Loïc Molinari <loic.molinari@collabora.com> wrote:
> This series aims to reduce the page tables overhead of DRM drivers for
> builds with CONFIG_TRANSPARENT_HUGEPAGE enabled and either the sysfs
> knob '/sys/kernel/mm/transparent_hugepage/shmem_enabled' appropriately
> set or drivers using a dedicated huge tmpfs mount point.
>
> It starts by checking whether a faulty address in the page fault
> handler is part of a huge page in order to attempt a PMD sized PFN
> insertion into the VMA. It then introduces a dedicated
> get_unmapped_area file operation on the DRM file descriptor for GEM
> objects to get the best virtual address alignment for the underlying
> shmem buffers.
>
> The remaining commits propose shmem helpers to create and release huge
> tmpfs mount points and adapt the i915 and V3D drivers. The helpers are
> then used to optionally enable Transparent Hugepage for Panfrost and
> Panthor.
>
> For Panthor on a Rock 5B, this series makes the first memcpy() to an
> entire BO object mapped in userspace about twice as fast with
> Transparent Hugepage enabled.
>
> Implementing a fault-around handler using the arm64 contiguous page
> hint (contptes) could also greatly help reduce page tables overhead
> for small pages by mapping several contiguous pages around a faulty
> address at once. This will be proposed in another patch series.
>
> Loïc Molinari (10):
> drm/shmem-helper: Simplify page offset calculation in fault handler
> drm/shmem-helper: Map huge pages in fault handler
> drm/gem: Introduce drm_gem_get_unmapped_area() fop
> drm/gem: Add huge tmpfs mountpoint helpers
> drm/i915: Use huge tmpfs mountpoint helpers
> drm/v3d: Use huge tmpfs mountpoint helpers
> drm/gem: Get rid of *_with_mnt helpers
> drm/panthor: Introduce huge tmpfs mountpoint option
> drm/panfrost: Introduce huge tmpfs mountpoint option
> Documentation/gpu/drm-mm: Add THP paragraph to GEM mapping section
Queued to drm-misc-next.
>
> Documentation/gpu/drm-mm.rst | 29 ++-
> drivers/gpu/drm/drm_gem.c | 202 +++++++++++++-----
> drivers/gpu/drm/drm_gem_shmem_helper.c | 77 +++----
> drivers/gpu/drm/i915/Makefile | 3 +-
> .../gpu/drm/i915/gem/i915_gem_object_types.h | 9 +-
> drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 58 +++--
> drivers/gpu/drm/i915/gem/i915_gemfs.c | 71 ------
> drivers/gpu/drm/i915/gem/i915_gemfs.h | 14 --
> .../gpu/drm/i915/gem/selftests/huge_pages.c | 15 +-
> drivers/gpu/drm/i915/i915_drv.h | 5 -
> drivers/gpu/drm/panfrost/panfrost_device.c | 3 +
> drivers/gpu/drm/panfrost/panfrost_drv.c | 6 +
> drivers/gpu/drm/panfrost/panfrost_drv.h | 9 +
> drivers/gpu/drm/panfrost/panfrost_gem.c | 18 ++
> drivers/gpu/drm/panfrost/panfrost_gem.h | 2 +
> drivers/gpu/drm/panthor/panthor_device.c | 3 +
> drivers/gpu/drm/panthor/panthor_drv.c | 7 +
> drivers/gpu/drm/panthor/panthor_drv.h | 9 +
> drivers/gpu/drm/panthor/panthor_gem.c | 18 ++
> drivers/gpu/drm/panthor/panthor_gem.h | 2 +
> drivers/gpu/drm/v3d/Makefile | 3 +-
> drivers/gpu/drm/v3d/v3d_bo.c | 6 +-
> drivers/gpu/drm/v3d/v3d_drv.c | 2 +-
> drivers/gpu/drm/v3d/v3d_drv.h | 11 +-
> drivers/gpu/drm/v3d/v3d_gem.c | 21 +-
> drivers/gpu/drm/v3d/v3d_gemfs.c | 62 ------
> include/drm/drm_device.h | 15 ++
> include/drm/drm_gem.h | 40 +++-
> include/drm/drm_gem_shmem_helper.h | 3 -
> 29 files changed, 420 insertions(+), 303 deletions(-)
> delete mode 100644 drivers/gpu/drm/i915/gem/i915_gemfs.c
> delete mode 100644 drivers/gpu/drm/i915/gem/i915_gemfs.h
> create mode 100644 drivers/gpu/drm/panfrost/panfrost_drv.h
> create mode 100644 drivers/gpu/drm/panthor/panthor_drv.h
> delete mode 100644 drivers/gpu/drm/v3d/v3d_gemfs.c
>
prev parent reply other threads:[~2025-12-08 11:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-05 18:22 Loïc Molinari
2025-12-05 18:22 ` [PATCH v13 01/10] drm/shmem-helper: Simplify page offset calculation in fault handler Loïc Molinari
2025-12-05 18:22 ` [PATCH v13 02/10] drm/shmem-helper: Map huge pages " Loïc Molinari
2025-12-05 18:22 ` [PATCH v13 03/10] drm/gem: Introduce drm_gem_get_unmapped_area() fop Loïc Molinari
2025-12-05 18:22 ` [PATCH v13 04/10] drm/gem: Add huge tmpfs mountpoint helpers Loïc Molinari
2025-12-05 18:22 ` [PATCH v13 05/10] drm/i915: Use " Loïc Molinari
2025-12-08 7:46 ` Tvrtko Ursulin
2025-12-05 18:22 ` [PATCH v13 06/10] drm/v3d: " Loïc Molinari
2025-12-05 18:22 ` [PATCH v13 07/10] drm/gem: Get rid of *_with_mnt helpers Loïc Molinari
2025-12-07 14:15 ` Maíra Canal
2025-12-05 18:22 ` [PATCH v13 08/10] drm/panthor: Introduce huge tmpfs mountpoint option Loïc Molinari
2025-12-05 18:22 ` [PATCH v13 09/10] drm/panfrost: " Loïc Molinari
2025-12-05 18:22 ` [PATCH v13 10/10] Documentation/gpu/drm-mm: Add THP paragraph to GEM mapping section Loïc Molinari
2025-12-08 11:29 ` Boris Brezillon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251208122941.61bea21d@fedora \
--to=boris.brezillon@collabora.com \
--cc=airlied@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andi.shyti@linux.intel.com \
--cc=bagasdotme@gmail.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=brauner@kernel.org \
--cc=corbet@lwn.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=healych@amazon.com \
--cc=hughd@google.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=kernel@collabora.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liviu.dudau@arm.com \
--cc=loic.molinari@collabora.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mcanal@igalia.com \
--cc=mikolaj.wasiak@intel.com \
--cc=mripard@kernel.org \
--cc=mwen@igalia.com \
--cc=nitin.r.gote@intel.com \
--cc=robh@kernel.org \
--cc=rodrigo.vivi@intel.com \
--cc=simona@ffwll.ch \
--cc=steven.price@arm.com \
--cc=tursulin@ursulin.net \
--cc=tzimmermann@suse.de \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox