From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E5118D2F7C8 for ; Fri, 5 Dec 2025 09:12:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A745C6B0146; Fri, 5 Dec 2025 04:12:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9D7746B0149; Fri, 5 Dec 2025 04:12:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 89DC66B0146; Fri, 5 Dec 2025 04:12:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 68C896B0146 for ; Fri, 5 Dec 2025 04:12:33 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 36AB91A0489 for ; Fri, 5 Dec 2025 09:12:33 +0000 (UTC) X-FDA: 84184851786.21.C3AD8A9 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) by imf07.hostedemail.com (Postfix) with ESMTP id 5F75D40007 for ; Fri, 5 Dec 2025 09:12:31 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=oKcvmC8I; spf=pass (imf07.hostedemail.com: domain of loic.molinari@collabora.com designates 148.251.105.195 as permitted sender) smtp.mailfrom=loic.molinari@collabora.com; dmarc=pass (policy=none) header.from=collabora.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1764925951; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1dIn5+bV+xuuN5pf2pBN5XY3NHAdsfBqozQcNkp54MM=; b=wEnHRIY+Lm9y0bJvaDnhnqwRY2vZFRGYf57l2ltdsXU3Xq3GO04bMdOxQeGBQWCU9DlAsk k0dWt3DMm6hHi4UdRwEi5boW7KUf7mgjz4tDU8BgrTlgLetmhoSrcpYvg3f58pUXsxbaFa vmLRVYLpNMIU2qlL+zT+VOweX7BqxLc= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=oKcvmC8I; spf=pass (imf07.hostedemail.com: domain of loic.molinari@collabora.com designates 148.251.105.195 as permitted sender) smtp.mailfrom=loic.molinari@collabora.com; dmarc=pass (policy=none) header.from=collabora.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1764925951; a=rsa-sha256; cv=none; b=pdEer6dG3e+BF9kbHbzLzJJyMfAGHQnFZYv465KCspA3go3mHBTGpL4qp2sZwUo+6mIGFR SYnQ5HE0vmOOc/z1RV8h4KTQl1OqjgS+J+FEMeeOnp/s6gIQb2NlnO1cYTBFlXXNm32ZMh yN3Dx5WrQ4MRBrps8hh1MVEX5tZDsFQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1764925950; bh=wOROUdGmrTopYn8Lks6qkkQ2zPA2SCtrzeNGfh6cEHk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oKcvmC8IgVExoG/NBS7efLcTohNajM9txyiS0IVpiAD2ROl5ERO424Ait3ziZ6DXR X+S5S9/ZbiTrpTYoKkg9YjBLxQhQMSaMlxg2fx9sSH/5MujCdCeZxKdwyO39Rwl8kO HW5HCvHXUr6p6keSDbxIoySYA7LuNxYdArDGt8XIOUQR+1Ua0AmH2dRpEsO4feraAi t3TpyhXB7ZijCH6wyqeWTc2lhQh3fkp6XSxagQof2E/yBgHhx1gCd2sEYs7QDN5Qd5 JmlD0QbDQ16FzJlsWI+FG9n5eC5Y/8kIhjDpN2w0NOwvZhyxMkYBDre3eED500QVZh pl9UYCQRUxbHg== Received: from debian-rockchip-rock5b-rk3588.. (unknown [IPv6:2a01:e0a:5e3:6100:826d:bc07:e98c:84a]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: loicmolinari) by bali.collaboradmins.com (Postfix) with ESMTPSA id 41CCE17E368E; Fri, 5 Dec 2025 10:12:29 +0100 (CET) From: =?UTF-8?q?Lo=C3=AFc=20Molinari?= To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Boris Brezillon , Rob Herring , Steven Price , Liviu Dudau , Melissa Wen , =?UTF-8?q?Ma=C3=ADra=20Canal?= , Hugh Dickins , Baolin Wang , Andrew Morton , =?UTF-8?q?Lo=C3=AFc=20Molinari?= , Al Viro , =?UTF-8?q?Miko=C5=82aj=20Wasiak?= , Christian Brauner , Nitin Gote , Andi Shyti , Jonathan Corbet , Christopher Healy , Matthew Wilcox , Bagas Sanjaya Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, kernel@collabora.com Subject: [PATCH v12 08/10] drm/panthor: Introduce huge tmpfs mountpoint option Date: Fri, 5 Dec 2025 10:12:14 +0100 Message-ID: <20251205091216.150968-9-loic.molinari@collabora.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251205091216.150968-1-loic.molinari@collabora.com> References: <20251205091216.150968-1-loic.molinari@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 5F75D40007 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: uwwkhdb8smp8btnafdebrh1ckpx141ox X-HE-Tag: 1764925951-98469 X-HE-Meta: U2FsdGVkX19NalCO1dayI09H/hnf5Uz7YG+W8SHFW340iO1ujCgbWI9+6fjkx7kIromWLibr6/GXHjmn2cJVgNqAzAWmvd2tyBBYfC9Ue/I97P/lPddxe9oGfv30iUZI/o10gjIO1i9A4qah0J77WlsV/BOUnrMQJd226d45f+3XNA9RkjzDVXUx15ZApme5nvNvCNzKDW2i2O9toJbVf1XsDCYwKG/j4AkQsxYOOFDND3Scwy3G5rzzXvGg4qaWu8ZradrKudVy6kcIXHSRp+DRu9qdUWayY3b8LRWm68jE52fKYOXzg05GQe4tPwrEgSbuxuixWCYfNwlDyeCjhAXONX/ee6JnrNmj5PGmZBAc15pXtw14jwgCSCP3Oj4WiMEngF8M5rPe7x071ontIDAHpQCbWXJ71GmT5J7pD/mqbsDnyyTwY8oP8cjTbjQbFFseDEZM1wOrsH+Vj9YQb3OAOZBo36YF79hfCHN3K34iIXZ8ie+n2MfZmTkwCK4qiqyaZ5wd+tS2YPKdnXRZxjTwbWuRGPn79psWB+hHVB+VXCdB2aSxnzdCCJ8NR2oQZdD7CIvP9dUwUjTlVECBio7o37pvvUQT/bEtfJTq3odvgTGYEWg4Ek/gjPAEcUrvau8hAm5VcpPuelCaXPl9o8UZf2In9RtU1FjR8T4r1SY1WdKIkIhMP7KgnS/4SmS4ArJfWk1YcXZtzhXAgyDRMhIItGwb3uqQc0zPom3zsdKI9IQBLaApdFb73H5dNNBalYV14qVpF4JmpUa7heaNJOs/pHsVQjjKdAhoGkEvkqIwAlWOHE7QlzWGOOn6Rlm0nmCnxyN9jUT3M+uXc488dtAzNq0zB5F2UI9JqHFFXzsDQ3CHIFTs+yEXjH9F6S4v1cVOc1yl4dtNwjqtHtB3ph5NJLKvsDZa8rj3OgGaAbjoXY9oM8E/SrcvzjY15jWtq0/nLKs4jtehAEFFcx/ d2sG5/Tg PF09SdsEBXoisQGa8G8FhtfK9yNMXknqALDC5N5uyz+EZdpQJze5cESw4pKgZOeJdD8h8LdRNNQDoDtDEKGaR6LBZqoy9B0QACcMqJvKnt7PjwCrzVE7NmU1loRoKPDgGpdONexmPM2PO5VYjKj1EiysiEZIDnFw8F1EBYKTBR371oO9ctRViD50e/ioLxuvmWUHu/aeDZO3dmw3jOBBb7SjqGC7DNDbPCU5CR7OeoNKA5BUorDqf2oGScs5ybAcDCxi8UvEKbfzIJDfQPbEXWNmyOOnQQICWTaECQXn3q1ohqhvzYC87Cotm90C/yIedoTQUiy4wRTeGyqbfpmubjBelbX9uU4ihk3U0hYW01LTYDRZZtMMYs5gTLFZjkE916hi7MgG+4RcqXXftynAw5pNzwUZsS4zeUfKlKU86cX5+xWJRqmRWWiNVzA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Introduce the 'panthor.transparent_hugepage' boolean module parameter (false by default). When the parameter is set to true, a new tmpfs mountpoint is created and mounted using the 'huge=within_size' option. It's then used at GEM object creation instead of the default 'shm_mnt' mountpoint in order to enable Transparent Hugepage (THP) for the object (without having to rely on a system wide parameter). v3: - use huge tmpfs mountpoint in drm_device v4: - fix builds with CONFIG_TRANSPARENT_HUGEPAGE=n - clean up mountpoint creation error handling - print negative error value v5: - use drm_gem_has_huge_tmp() helper - get rid of CONFIG_TRANSPARENT_HUGEPAGE ifdefs v9: - replace drm_gem_has_huge_tmp() by drm_gem_get_huge_tmp() v11: - enable 'panthor.transparent_hugepage' by default Signed-off-by: Loïc Molinari Reviewed-by: Boris Brezillon --- drivers/gpu/drm/panthor/panthor_device.c | 3 +++ drivers/gpu/drm/panthor/panthor_drv.c | 7 +++++++ drivers/gpu/drm/panthor/panthor_drv.h | 9 +++++++++ drivers/gpu/drm/panthor/panthor_gem.c | 18 ++++++++++++++++++ drivers/gpu/drm/panthor/panthor_gem.h | 2 ++ 5 files changed, 39 insertions(+) create mode 100644 drivers/gpu/drm/panthor/panthor_drv.h diff --git a/drivers/gpu/drm/panthor/panthor_device.c b/drivers/gpu/drm/panthor/panthor_device.c index e133b1e0ad6d..2979ee0e52c2 100644 --- a/drivers/gpu/drm/panthor/panthor_device.c +++ b/drivers/gpu/drm/panthor/panthor_device.c @@ -18,6 +18,7 @@ #include "panthor_devfreq.h" #include "panthor_device.h" #include "panthor_fw.h" +#include "panthor_gem.h" #include "panthor_gpu.h" #include "panthor_hw.h" #include "panthor_mmu.h" @@ -294,6 +295,8 @@ int panthor_device_init(struct panthor_device *ptdev) if (ret) goto err_unplug_fw; + panthor_gem_init(ptdev); + /* ~3 frames */ pm_runtime_set_autosuspend_delay(ptdev->base.dev, 50); pm_runtime_use_autosuspend(ptdev->base.dev); diff --git a/drivers/gpu/drm/panthor/panthor_drv.c b/drivers/gpu/drm/panthor/panthor_drv.c index d1d4c50da5bf..0e7ab6f5ba89 100644 --- a/drivers/gpu/drm/panthor/panthor_drv.c +++ b/drivers/gpu/drm/panthor/panthor_drv.c @@ -1559,6 +1559,7 @@ static const struct file_operations panthor_drm_driver_fops = { .read = drm_read, .llseek = noop_llseek, .mmap = panthor_mmap, + .get_unmapped_area = drm_gem_get_unmapped_area, .show_fdinfo = drm_show_fdinfo, .fop_flags = FOP_UNSIGNED_OFFSET, }; @@ -1626,6 +1627,12 @@ static const struct drm_driver panthor_drm_driver = { #endif }; +#ifdef CONFIG_TRANSPARENT_HUGEPAGE +bool panthor_transparent_hugepage = true; +module_param_named(transparent_hugepage, panthor_transparent_hugepage, bool, 0400); +MODULE_PARM_DESC(transparent_hugepage, "Use a dedicated tmpfs mount point with Transparent Hugepage enabled (true = default)"); +#endif + static int panthor_probe(struct platform_device *pdev) { struct panthor_device *ptdev; diff --git a/drivers/gpu/drm/panthor/panthor_drv.h b/drivers/gpu/drm/panthor/panthor_drv.h new file mode 100644 index 000000000000..79dccd289881 --- /dev/null +++ b/drivers/gpu/drm/panthor/panthor_drv.h @@ -0,0 +1,9 @@ +// SPDX-License-Identifier: GPL-2.0 or MIT +/* Copyright 2025 Amazon.com, Inc. or its affiliates */ + +#ifndef __PANTHOR_DRV_H__ +#define __PANTHOR_DRV_H__ + +extern bool panthor_transparent_hugepage; + +#endif diff --git a/drivers/gpu/drm/panthor/panthor_gem.c b/drivers/gpu/drm/panthor/panthor_gem.c index 10d255cccc09..7ae07a9bc996 100644 --- a/drivers/gpu/drm/panthor/panthor_gem.c +++ b/drivers/gpu/drm/panthor/panthor_gem.c @@ -1,6 +1,7 @@ // SPDX-License-Identifier: GPL-2.0 or MIT /* Copyright 2019 Linaro, Ltd, Rob Herring */ /* Copyright 2023 Collabora ltd. */ +/* Copyright 2025 Amazon.com, Inc. or its affiliates */ #include #include @@ -12,10 +13,27 @@ #include #include "panthor_device.h" +#include "panthor_drv.h" #include "panthor_fw.h" #include "panthor_gem.h" #include "panthor_mmu.h" +void panthor_gem_init(struct panthor_device *ptdev) +{ + int err; + + if (IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE) && + !panthor_transparent_hugepage) + return; + + err = drm_gem_huge_mnt_create(&ptdev->base, "within_size"); + if (drm_gem_get_huge_mnt(&ptdev->base)) + drm_info(&ptdev->base, "Using Transparent Hugepage\n"); + else if (err) + drm_warn(&ptdev->base, "Can't use Transparent Hugepage (%d)\n", + err); +} + #ifdef CONFIG_DEBUG_FS static void panthor_gem_debugfs_bo_init(struct panthor_gem_object *bo) { diff --git a/drivers/gpu/drm/panthor/panthor_gem.h b/drivers/gpu/drm/panthor/panthor_gem.h index 80c6e24112d0..2eefe9104e5e 100644 --- a/drivers/gpu/drm/panthor/panthor_gem.h +++ b/drivers/gpu/drm/panthor/panthor_gem.h @@ -136,6 +136,8 @@ struct panthor_gem_object *to_panthor_bo(struct drm_gem_object *obj) return container_of(to_drm_gem_shmem_obj(obj), struct panthor_gem_object, base); } +void panthor_gem_init(struct panthor_device *ptdev); + struct drm_gem_object *panthor_gem_create_object(struct drm_device *ddev, size_t size); int -- 2.47.3