From: Gary Guo <gary@garyguo.net>
To: Alice Ryhl <aliceryhl@google.com>
Cc: rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Dave Ertman" <david.m.ertman@intel.com>,
"Ira Weiny" <ira.weiny@intel.com>,
"Leon Romanovsky" <leon@kernel.org>,
"Peter Zijlstra" <peterz@infradead.org>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Elle Rhumsaa" <elle@weathered-steel.dev>,
"Carlos Llamas" <cmllamas@google.com>,
"Yury Norov" <yury.norov@gmail.com>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
linux-block@vger.kernel.org,
"FUJITA Tomonori" <fujita.tomonori@gmail.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Michael Turquette" <mturquette@baylibre.com>,
"Stephen Boyd" <sboyd@kernel.org>,
linux-clk@vger.kernel.org, "Benno Lossin" <lossin@kernel.org>,
"Danilo Krummrich" <dakr@kernel.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Viresh Kumar" <viresh.kumar@linaro.org>,
linux-pm@vger.kernel.org, "Paul Moore" <paul@paul-moore.com>,
"Serge Hallyn" <sergeh@kernel.org>,
linux-security-module@vger.kernel.org,
"Daniel Almeida" <daniel.almeida@collabora.com>,
"Abdiel Janulgue" <abdiel.janulgue@gmail.com>,
"Robin Murphy" <robin.murphy@arm.com>,
"Lyude Paul" <lyude@redhat.com>,
"Alexander Viro" <viro@zeniv.linux.org.uk>,
"Christian Brauner" <brauner@kernel.org>,
"Jan Kara" <jack@suse.cz>,
linux-fsdevel@vger.kernel.org,
"Josh Poimboeuf" <jpoimboe@kernel.org>,
"Jason Baron" <jbaron@akamai.com>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Ard Biesheuvel" <ardb@kernel.org>,
"Brendan Higgins" <brendan.higgins@linux.dev>,
"David Gow" <davidgow@google.com>, "Rae Moar" <rmoar@google.com>,
linux-kselftest@vger.kernel.org,
"Andrew Morton" <akpm@linux-foundation.org>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
"Andrew Ballance" <andrewjballance@gmail.com>,
maple-tree@lists.infradead.org, linux-mm@kvack.org,
"Lorenzo Stoakes" <lorenzo.stoakes@oracle.com>,
"Uladzislau Rezki" <urezki@gmail.com>,
"Vitaly Wool" <vitaly.wool@konsulko.se>,
"Rob Herring" <robh@kernel.org>,
"Saravana Kannan" <saravanak@google.com>,
devicetree@vger.kernel.org, "Bjorn Helgaas" <bhelgaas@google.com>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
linux-pci@vger.kernel.org, "Remo Senekowitsch" <remo@buenzli.dev>,
"Paul E. McKenney" <paulmck@kernel.org>,
rcu@vger.kernel.org, "Will Deacon" <will@kernel.org>,
"Fiona Behrens" <me@kloenk.dev>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Alexandre Courbot" <acourbot@nvidia.com>,
"Vlastimil Babka" <vbabka@suse.cz>,
"Christoph Lameter" <cl@gentwo.org>,
"David Rientjes" <rientjes@google.com>,
"Ingo Molnar" <mingo@redhat.com>,
"Waiman Long" <longman@redhat.com>,
"Mitchell Levy" <levymitchell0@gmail.com>,
"Frederic Weisbecker" <frederic@kernel.org>,
"Anna-Maria Behnsen" <anna-maria@linutronix.de>,
"John Stultz" <jstultz@google.com>,
linux-usb@vger.kernel.org, "Tejun Heo" <tj@kernel.org>,
"Lai Jiangshan" <jiangshanlai@gmail.com>,
"Matthew Wilcox" <willy@infradead.org>,
"Tamir Duberstein" <tamird@gmail.com>
Subject: Re: [PATCH 00/46] Allow inlining C helpers into Rust when using LTO
Date: Wed, 3 Dec 2025 14:33:05 +0000 [thread overview]
Message-ID: <20251203143305.591cd0da.gary@garyguo.net> (raw)
In-Reply-To: <20251202-define-rust-helper-v1-0-a2e13cbc17a6@google.com>
On Tue, 02 Dec 2025 19:37:24 +0000
Alice Ryhl <aliceryhl@google.com> wrote:
> This patch series adds __rust_helper to every single rust helper. The
> patches do not depend on each other, so maintainers please go ahead and
> pick up any patches relevant to your subsystem! Or provide your Acked-by
> so that Miguel can pick them up.
>
> These changes were generated by adding __rust_helper and running
> ClangFormat. Unrelated formatting changes were removed manually.
>
> Why is __rust_helper needed?
> ============================
>
> Currently, C helpers cannot be inlined into Rust even when using LTO
> because LLVM detects slightly different options on the codegen units.
>
> * LLVM doesn't want to inline functions compiled with
> `-fno-delete-null-pointer-checks` with code compiled without. The C
> CGUs all have this enabled and Rust CGUs don't. Inlining is okay since
> this is one of the hardening features that does not change the ABI,
> and we shouldn't have null pointer dereferences in these helpers.
>
> * LLVM doesn't want to inline functions with different list of builtins. C
> side has `-fno-builtin-wcslen`; `wcslen` is not a Rust builtin, so
> they should be compatible, but LLVM does not perform inlining due to
> attributes mismatch.
>
> * clang and Rust doesn't have the exact target string. Clang generates
> `+cmov,+cx8,+fxsr` but Rust doesn't enable them (in fact, Rust will
> complain if `-Ctarget-feature=+cmov,+cx8,+fxsr` is used). x86-64
> always enable these features, so they are in fact the same target
> string, but LLVM doesn't understand this and so inlining is inhibited.
> This can be bypassed with `--ignore-tti-inline-compatible`, but this
> is a hidden option.
>
> (This analysis was written by Gary Guo.)
>
> How is this fixed?
> ==================
>
> To fix this we need to add __always_inline to all helpers when compiling
> with LTO. However, it should not be added when running bindgen as
> bindgen will ignore functions marked inline. To achieve this, we are
> using a #define called __rust_helper that is defined differently
> depending on whether bindgen is running or not.
>
> Note that __rust_helper is currently always #defined to nothing.
> Changing it to __always_inline will happen separately in another patch
> series.
>
> Signed-off-by: Alice Ryhl <aliceryhl@google.com>
> ---
> Alice Ryhl (46):
> rust: auxiliary: add __rust_helper to helpers
> rust: barrier: add __rust_helper to helpers
> rust: binder: add __rust_helper to helpers
> rust: bitmap: add __rust_helper to helpers
> rust: bitops: add __rust_helper to helpers
> rust: blk: add __rust_helper to helpers
> rust: bug: add __rust_helper to helpers
> rust: clk: add __rust_helper to helpers
> rust: completion: add __rust_helper to helpers
> rust: cpu: add __rust_helper to helpers
> rust: cpufreq: add __rust_helper to helpers
> rust: cpumask: add __rust_helper to helpers
> rust: cred: add __rust_helper to helpers
> rust: device: add __rust_helper to helpers
> rust: dma: add __rust_helper to helpers
> rust: drm: add __rust_helper to helpers
> rust: err: add __rust_helper to helpers
> rust: fs: add __rust_helper to helpers
> rust: io: add __rust_helper to helpers
> rust: irq: add __rust_helper to helpers
> rust: jump_label: add __rust_helper to helpers
> rust: kunit: add __rust_helper to helpers
> rust: maple_tree: add __rust_helper to helpers
> rust: mm: add __rust_helper to helpers
> rust: of: add __rust_helper to helpers
> rust: pci: add __rust_helper to helpers
> rust: pid_namespace: add __rust_helper to helpers
> rust: platform: add __rust_helper to helpers
> rust: poll: add __rust_helper to helpers
> rust: processor: add __rust_helper to helpers
> rust: property: add __rust_helper to helpers
> rust: rbtree: add __rust_helper to helpers
> rust: rcu: add __rust_helper to helpers
> rust: refcount: add __rust_helper to helpers
> rust: regulator: add __rust_helper to helpers
> rust: scatterlist: add __rust_helper to helpers
> rust: security: add __rust_helper to helpers
> rust: slab: add __rust_helper to helpers
> rust: sync: add __rust_helper to helpers
> rust: task: add __rust_helper to helpers
> rust: time: add __rust_helper to helpers
> rust: uaccess: add __rust_helper to helpers
> rust: usb: add __rust_helper to helpers
> rust: wait: add __rust_helper to helpers
> rust: workqueue: add __rust_helper to helpers
> rust: xarray: add __rust_helper to helpers
Thansk for sending this Alice! With this series in first, my series for
inlining helpers should be much easier to apply.
For the whole series:
Reviewed-by: Gary Guo <gary@garyguo.net>
Best,
Gary
>
> rust/helpers/auxiliary.c | 6 +++--
> rust/helpers/barrier.c | 6 ++---
> rust/helpers/binder.c | 13 ++++-----
> rust/helpers/bitmap.c | 6 +++--
> rust/helpers/bitops.c | 11 +++++---
> rust/helpers/blk.c | 4 +--
> rust/helpers/bug.c | 4 +--
> rust/helpers/build_bug.c | 2 +-
> rust/helpers/clk.c | 24 +++++++++--------
> rust/helpers/completion.c | 2 +-
> rust/helpers/cpu.c | 2 +-
> rust/helpers/cpufreq.c | 3 ++-
> rust/helpers/cpumask.c | 32 +++++++++++++---------
> rust/helpers/cred.c | 4 +--
> rust/helpers/device.c | 16 +++++------
> rust/helpers/dma.c | 15 ++++++-----
> rust/helpers/drm.c | 7 ++---
> rust/helpers/err.c | 6 ++---
> rust/helpers/fs.c | 2 +-
> rust/helpers/io.c | 64 +++++++++++++++++++++++---------------------
> rust/helpers/irq.c | 6 +++--
> rust/helpers/jump_label.c | 2 +-
> rust/helpers/kunit.c | 2 +-
> rust/helpers/maple_tree.c | 3 ++-
> rust/helpers/mm.c | 20 +++++++-------
> rust/helpers/mutex.c | 13 ++++-----
> rust/helpers/of.c | 2 +-
> rust/helpers/page.c | 9 ++++---
> rust/helpers/pci.c | 13 +++++----
> rust/helpers/pid_namespace.c | 8 +++---
> rust/helpers/platform.c | 2 +-
> rust/helpers/poll.c | 5 ++--
> rust/helpers/processor.c | 2 +-
> rust/helpers/property.c | 2 +-
> rust/helpers/rbtree.c | 5 ++--
> rust/helpers/rcu.c | 4 +--
> rust/helpers/refcount.c | 10 +++----
> rust/helpers/regulator.c | 24 ++++++++++-------
> rust/helpers/scatterlist.c | 12 +++++----
> rust/helpers/security.c | 26 ++++++++++--------
> rust/helpers/signal.c | 2 +-
> rust/helpers/slab.c | 14 +++++-----
> rust/helpers/spinlock.c | 13 ++++-----
> rust/helpers/sync.c | 4 +--
> rust/helpers/task.c | 24 ++++++++---------
> rust/helpers/time.c | 12 ++++-----
> rust/helpers/uaccess.c | 8 +++---
> rust/helpers/usb.c | 3 ++-
> rust/helpers/vmalloc.c | 7 ++---
> rust/helpers/wait.c | 2 +-
> rust/helpers/workqueue.c | 8 +++---
> rust/helpers/xarray.c | 10 +++----
> 52 files changed, 280 insertions(+), 226 deletions(-)
> ---
> base-commit: 54e3eae855629702c566bd2e130d9f40e7f35bde
> change-id: 20251202-define-rust-helper-f7b531813007
>
> Best regards,
next prev parent reply other threads:[~2025-12-03 14:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-02 19:37 Alice Ryhl
2025-12-02 19:37 ` [PATCH 23/46] rust: maple_tree: add __rust_helper to helpers Alice Ryhl
2025-12-04 21:07 ` Andrew Ballance
2025-12-02 19:37 ` [PATCH 24/46] rust: mm: " Alice Ryhl
2025-12-03 1:43 ` Boqun Feng
2025-12-03 9:03 ` Alice Ryhl
2025-12-02 19:38 ` [PATCH 46/46] rust: xarray: " Alice Ryhl
2025-12-03 1:47 ` [PATCH 00/46] Allow inlining C helpers into Rust when using LTO Boqun Feng
2025-12-03 14:33 ` Gary Guo [this message]
2025-12-04 10:05 ` (subset) " Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251203143305.591cd0da.gary@garyguo.net \
--to=gary@garyguo.net \
--cc=Liam.Howlett@oracle.com \
--cc=a.hindborg@kernel.org \
--cc=abdiel.janulgue@gmail.com \
--cc=acourbot@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=aliceryhl@google.com \
--cc=andrewjballance@gmail.com \
--cc=anna-maria@linutronix.de \
--cc=ardb@kernel.org \
--cc=bhelgaas@google.com \
--cc=boqun.feng@gmail.com \
--cc=brauner@kernel.org \
--cc=brendan.higgins@linux.dev \
--cc=broonie@kernel.org \
--cc=cl@gentwo.org \
--cc=cmllamas@google.com \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=david.m.ertman@intel.com \
--cc=davidgow@google.com \
--cc=devicetree@vger.kernel.org \
--cc=elle@weathered-steel.dev \
--cc=frederic@kernel.org \
--cc=fujita.tomonori@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=ira.weiny@intel.com \
--cc=jack@suse.cz \
--cc=jbaron@akamai.com \
--cc=jiangshanlai@gmail.com \
--cc=jpoimboe@kernel.org \
--cc=jstultz@google.com \
--cc=kwilczynski@kernel.org \
--cc=leon@kernel.org \
--cc=levymitchell0@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=longman@redhat.com \
--cc=lorenzo.stoakes@oracle.com \
--cc=lossin@kernel.org \
--cc=lyude@redhat.com \
--cc=maple-tree@lists.infradead.org \
--cc=me@kloenk.dev \
--cc=mingo@redhat.com \
--cc=mturquette@baylibre.com \
--cc=ojeda@kernel.org \
--cc=paul@paul-moore.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=rafael@kernel.org \
--cc=rcu@vger.kernel.org \
--cc=remo@buenzli.dev \
--cc=rientjes@google.com \
--cc=rmoar@google.com \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=rostedt@goodmis.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=saravanak@google.com \
--cc=sboyd@kernel.org \
--cc=sergeh@kernel.org \
--cc=tamird@gmail.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=urezki@gmail.com \
--cc=vbabka@suse.cz \
--cc=viresh.kumar@linaro.org \
--cc=viro@zeniv.linux.org.uk \
--cc=vitaly.wool@konsulko.se \
--cc=will@kernel.org \
--cc=willy@infradead.org \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox