From: Andrzej Hajda <andrzej.hajda@intel.com>
To: Petr Mladek <pmladek@suse.com>,
Steven Rostedt <rostedt@goodmis.org>,
John Ogness <john.ogness@linutronix.de>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Danilo Krummrich <dakr@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@suse.cz>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>,
Brendan Jackman <jackmanb@google.com>,
Johannes Weiner <hannes@cmpxchg.org>, Zi Yan <ziy@nvidia.com>,
Christoph Lameter <cl@gentwo.org>,
David Rientjes <rientjes@google.com>,
Roman Gushchin <roman.gushchin@linux.dev>,
Harry Yoo <harry.yoo@oracle.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Andrzej Hajda <andrzej.hajda@intel.com>
Subject: [PATCH v2 5/5] mm: simplify variadic args handling
Date: Mon, 01 Dec 2025 10:31:26 +0100 [thread overview]
Message-ID: <20251201-va_format_call-v2-5-2906f3093b60@intel.com> (raw)
In-Reply-To: <20251201-va_format_call-v2-0-2906f3093b60@intel.com>
Changing argument type from va_list to struct va_format * allows
to simplify variadic argument handling with va_format_call helper.
Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
---
mm/slub.c | 23 ++++-------------------
1 file changed, 4 insertions(+), 19 deletions(-)
diff --git a/mm/slub.c b/mm/slub.c
index 786c5a4195d4..12d8ec97eac5 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -1135,27 +1135,16 @@ void skip_orig_size_check(struct kmem_cache *s, const void *object)
set_orig_size(s, (void *)object, s->object_size);
}
-static void __slab_bug(struct kmem_cache *s, const char *fmt, va_list argsp)
+static void __slab_bug(struct kmem_cache *s, const char *fmt, struct va_format *vaf)
{
- struct va_format vaf;
- va_list args;
-
- va_copy(args, argsp);
- vaf.fmt = fmt;
- vaf.va = &args;
pr_err("=============================================================================\n");
- pr_err("BUG %s (%s): %pV\n", s ? s->name : "<unknown>", print_tainted(), &vaf);
+ pr_err("BUG %s (%s): %pV\n", s ? s->name : "<unknown>", print_tainted(), vaf);
pr_err("-----------------------------------------------------------------------------\n\n");
- va_end(args);
}
static void slab_bug(struct kmem_cache *s, const char *fmt, ...)
{
- va_list args;
-
- va_start(args, fmt);
- __slab_bug(s, fmt, args);
- va_end(args);
+ va_format_call(fmt, __slab_bug, s, fmt, va_format_arg);
}
__printf(2, 3)
@@ -1252,14 +1241,10 @@ static void __slab_err(struct slab *slab)
static __printf(3, 4) void slab_err(struct kmem_cache *s, struct slab *slab,
const char *fmt, ...)
{
- va_list args;
-
if (slab_add_kunit_errors())
return;
- va_start(args, fmt);
- __slab_bug(s, fmt, args);
- va_end(args);
+ va_format_call(fmt, __slab_bug, s, fmt, va_format_arg);
__slab_err(slab);
}
--
2.43.0
prev parent reply other threads:[~2025-12-01 9:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-01 9:31 [PATCH v2 0/5] printk: add macros to simplify handling struct va_format Andrzej Hajda
2025-12-01 9:31 ` [PATCH v2 1/5] " Andrzej Hajda
2025-12-01 9:31 ` [PATCH v2 2/5] drivers/core: use va_format_call helper Andrzej Hajda
2025-12-01 9:31 ` [PATCH v2 3/5] drivers/core: simplify variadic args handling Andrzej Hajda
2025-12-02 15:51 ` Petr Mladek
2025-12-02 18:03 ` Hajda, Andrzej
2025-12-03 14:47 ` Andy Shevchenko
2025-12-03 18:07 ` Hajda, Andrzej
2025-12-01 9:31 ` [PATCH v2 4/5] mm: use va_format_call helper Andrzej Hajda
2025-12-01 9:31 ` Andrzej Hajda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251201-va_format_call-v2-5-2906f3093b60@intel.com \
--to=andrzej.hajda@intel.com \
--cc=akpm@linux-foundation.org \
--cc=cl@gentwo.org \
--cc=dakr@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hannes@cmpxchg.org \
--cc=harry.yoo@oracle.com \
--cc=jackmanb@google.com \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=pmladek@suse.com \
--cc=rafael@kernel.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox