From: David Laight <david.laight.linux@gmail.com>
To: Sahil Chandna <chandna.sahil@gmail.com>
Cc: akpm@linux-foundation.org, david@redhat.com,
lorenzo.stoakes@oracle.com, mhocko@suse.com, vbabka@suse.cz,
rppt@kernel.org, surenb@google.com, hannes@cmpxchg.org,
shakeel.butt@linux.dev, zhengqi.arch@bytedance.com,
Liam.Howlett@oracle.com, weixugc@google.com,
axelrasmussen@google.com, yuanchu@google.com,
yosry.ahmed@linux.dev, nphamcs@gmail.com,
chengming.zhou@linux.dev, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, david@kernel.org,
Matthew Wilcox <willy@infradead.org>
Subject: Re: [PATCH v3 1/3] mm: pagewalk: simplify hugepage boundary calculation using min()
Date: Thu, 27 Nov 2025 10:05:23 +0000 [thread overview]
Message-ID: <20251127100523.6c6f79c6@pumpkin> (raw)
In-Reply-To: <1e01c12f7666ade41f5f34ada24ad3de1087454f.1764177933.git.chandna.sahil@gmail.com>
On Thu, 27 Nov 2025 10:41:28 +0530
Sahil Chandna <chandna.sahil@gmail.com> wrote:
> Use the min() macro to compute the minimum value instead of an explicit
> ternary expression. This improves readability and matches common kernel
> style. Also change the return hugepage boundary expression for better
> clarity.
>
>...
> {
> - unsigned long boundary = (addr & huge_page_mask(h)) + huge_page_size(h);
> - return boundary < end ? boundary : end;
> + return min(ALIGN(addr, huge_page_size(h)), end);
> }
>
> static int walk_hugetlb_range(unsigned long addr, unsigned long end,
The commit message doesn't really match the patch.
The biggest part is not open-coding the equivalent of ALIGN(), not using min().
David
next prev parent reply other threads:[~2025-11-27 10:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-27 5:11 [PATCH v3 0/3] mm: Coccinelle-driven cleanups across memory management code Sahil Chandna
2025-11-27 5:11 ` [PATCH v3 1/3] mm: pagewalk: simplify hugepage boundary calculation using min() Sahil Chandna
2025-11-27 8:07 ` David Hildenbrand (Red Hat)
2025-11-27 10:05 ` David Laight [this message]
2025-11-27 5:11 ` [PATCH v3 2/3] mm/vmscan: use %pe to print error pointers Sahil Chandna
2025-11-27 5:11 ` [PATCH v3 3/3] mm/zswap: " Sahil Chandna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251127100523.6c6f79c6@pumpkin \
--to=david.laight.linux@gmail.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=axelrasmussen@google.com \
--cc=chandna.sahil@gmail.com \
--cc=chengming.zhou@linux.dev \
--cc=david@kernel.org \
--cc=david@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@suse.com \
--cc=nphamcs@gmail.com \
--cc=rppt@kernel.org \
--cc=shakeel.butt@linux.dev \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=weixugc@google.com \
--cc=willy@infradead.org \
--cc=yosry.ahmed@linux.dev \
--cc=yuanchu@google.com \
--cc=zhengqi.arch@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox