linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Guopeng Zhang <zhangguopeng@kylinos.cn>
To: tj@kernel.org, hannes@cmpxchg.org, mhocko@kernel.org,
	roman.gushchin@linux.dev, shakeel.butt@linux.dev,
	mkoutny@suse.com, muchun.song@linux.dev
Cc: lance.yang@linux.dev, shuah@kernel.org, linux-mm@kvack.org,
	linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
	Guopeng Zhang <zhangguopeng@kylinos.cn>
Subject: [PATCH v4 0/3] selftests: cgroup: Enhance robustness with polling helpers
Date: Mon, 24 Nov 2025 20:38:13 +0800	[thread overview]
Message-ID: <20251124123816.486164-1-zhangguopeng@kylinos.cn> (raw)

Hi all,

This patch series introduces improvements to the cgroup selftests by adding helper functions to better handle 
asynchronous updates in cgroup statistics. These changes are especially useful for managing cgroup stats like 
memory.stat and cgroup.stat, which can be affected by delays (e.g., RCPU callbacks and asynchronous rstat flushing).

v4:
 - Patch 1/3: Adds the `cg_read_key_long_poll()` helper to poll cgroup keys with retries and configurable intervals.
 - Patch 2/3: Updates `test_memcg_sock()` to use `cg_read_key_long_poll()` for handling delayed "sock" counter updates in memory.stat.
 - Patch 3/3: Replaces `sleep` and retry logic in `test_kmem_dead_cgroups()` with `cg_read_key_long_poll()` for waiting on `nr_dying_descendants`.

v3:
 - Move `MEMCG_SOCKSTAT_WAIT_*` defines after the `#include` block as suggested.

v2:
 - Clarify the rationale for the 3s timeout and mention the periodic rstat flush interval (FLUSH_TIME = 2*HZ) in the comment.
 - Replace hardcoded retry count and wait interval with macros to avoid magic numbers and make the timeout calculation explicit.

Thanks to Michal Koutný for the suggestion to introduce the polling helper, and to Lance Yang for the review.

Guopeng Zhang (3):
  selftests: cgroup: Add cg_read_key_long_poll() to poll a cgroup key
    with retries
  selftests: cgroup: make test_memcg_sock robust against delayed sock
    stats
  selftests: cgroup: Replace sleep with cg_read_key_long_poll() for
    waiting on nr_dying_descendants

 .../selftests/cgroup/lib/cgroup_util.c        | 21 +++++++++++++
 .../cgroup/lib/include/cgroup_util.h          |  5 +++
 tools/testing/selftests/cgroup/test_kmem.c    | 31 ++++++++-----------
 .../selftests/cgroup/test_memcontrol.c        | 20 +++++++++++-
 4 files changed, 58 insertions(+), 19 deletions(-)

-- 
2.25.1



             reply	other threads:[~2025-11-24 12:39 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-24 12:38 Guopeng Zhang [this message]
2025-11-24 12:38 ` [PATCH v4 1/3] selftests: cgroup: Add cg_read_key_long_poll() to poll a cgroup key with retries Guopeng Zhang
2025-12-02 19:24   ` Shakeel Butt
2025-11-24 12:38 ` [PATCH v4 2/3] selftests: cgroup: make test_memcg_sock robust against delayed sock stats Guopeng Zhang
2025-11-27 10:55   ` Lance Yang
2025-11-27 11:18     ` Guopeng Zhang
2025-11-27 11:29       ` Lance Yang
2025-12-02 23:12   ` Shakeel Butt
2025-12-03  3:27     ` Guopeng Zhang
2025-11-24 12:38 ` [PATCH v4 3/3] selftests: cgroup: Replace sleep with cg_read_key_long_poll() for waiting on nr_dying_descendants Guopeng Zhang
2025-12-02 23:18   ` Shakeel Butt
2025-12-03  3:32     ` Guopeng Zhang
2025-12-02  5:45 ` [PATCH v4 0/3] selftests: cgroup: Enhance robustness with polling helpers Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251124123816.486164-1-zhangguopeng@kylinos.cn \
    --to=zhangguopeng@kylinos.cn \
    --cc=hannes@cmpxchg.org \
    --cc=lance.yang@linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=mkoutny@suse.com \
    --cc=muchun.song@linux.dev \
    --cc=roman.gushchin@linux.dev \
    --cc=shakeel.butt@linux.dev \
    --cc=shuah@kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox