From: Zi Yan <ziy@nvidia.com>
To: David Hildenbrand <david@kernel.org>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Zi Yan <ziy@nvidia.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
Nico Pache <npache@redhat.com>,
Ryan Roberts <ryan.roberts@arm.com>, Dev Jain <dev.jain@arm.com>,
Barry Song <baohua@kernel.org>, Lance Yang <lance.yang@linux.dev>,
Miaohe Lin <linmiaohe@huawei.com>,
Naoya Horiguchi <nao.horiguchi@gmail.com>,
Wei Yang <richard.weiyang@gmail.com>,
Balbir Singh <balbirs@nvidia.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 4/4] mm/huge_memory: fix folio split stats counting
Date: Fri, 21 Nov 2025 21:55:29 -0500 [thread overview]
Message-ID: <20251122025529.1562592-5-ziy@nvidia.com> (raw)
In-Reply-To: <20251122025529.1562592-1-ziy@nvidia.com>
The "return <error code>" statements for error checks at the beginning of
__folio_split() skip necessary count_vm_event() and count_mthp_stat() at
the end of the function. Fix these by replacing them with
"ret = <error code>; goto out;".
Signed-off-by: Zi Yan <ziy@nvidia.com>
---
mm/huge_memory.c | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/mm/huge_memory.c b/mm/huge_memory.c
index ebc3ba0907fd..a42c4f29ce4f 100644
--- a/mm/huge_memory.c
+++ b/mm/huge_memory.c
@@ -3954,16 +3954,20 @@ static int __folio_split(struct folio *folio, unsigned int new_order,
VM_WARN_ON_ONCE_FOLIO(!folio_test_locked(folio), folio);
VM_WARN_ON_ONCE_FOLIO(!folio_test_large(folio), folio);
- if (folio != page_folio(split_at) || folio != page_folio(lock_at))
- return -EINVAL;
+ if (folio != page_folio(split_at) || folio != page_folio(lock_at)) {
+ ret = -EINVAL;
+ goto out;
+ }
- if (new_order >= old_order)
- return -EINVAL;
+ if (new_order >= old_order) {
+ ret = -EINVAL;
+ goto out;
+ }
ret = folio_check_splittable(folio, new_order, split_type,
/* warn = */ true);
if (ret)
- return ret;
+ goto out;
if (is_anon) {
/*
--
2.51.0
next prev parent reply other threads:[~2025-11-22 2:57 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-22 2:55 [PATCH v2 0/4] Improve folio split related functions Zi Yan
2025-11-22 2:55 ` [PATCH v2 1/4] mm/huge_memory: change folio_split_supported() to folio_check_splittable() Zi Yan
2025-11-23 1:50 ` Wei Yang
2025-11-23 18:38 ` Barry Song
2025-11-24 10:33 ` David Hildenbrand (Red Hat)
2025-11-24 16:38 ` Zi Yan
2025-11-25 8:58 ` David Hildenbrand (Red Hat)
2025-11-25 17:44 ` Andrew Morton
2025-11-22 2:55 ` [PATCH v2 2/4] mm/huge_memory: replace can_split_folio() with direct refcount calculation Zi Yan
2025-11-23 1:51 ` Wei Yang
2025-11-24 10:41 ` David Hildenbrand (Red Hat)
2025-11-24 17:05 ` Zi Yan
2025-11-24 19:22 ` David Hildenbrand (Red Hat)
2025-11-24 21:08 ` Zi Yan
2025-11-25 8:52 ` David Hildenbrand (Red Hat)
2025-11-25 15:55 ` Zi Yan
2025-11-25 9:10 ` Miaohe Lin
2025-11-25 9:34 ` David Hildenbrand (Red Hat)
2025-11-24 22:14 ` Balbir Singh
2025-11-25 8:55 ` David Hildenbrand (Red Hat)
2025-11-25 15:41 ` Zi Yan
2025-11-22 2:55 ` [PATCH v2 3/4] mm/huge_memory: make min_order_for_split() always return an order Zi Yan
2025-11-23 1:53 ` Wei Yang
2025-11-24 10:43 ` David Hildenbrand (Red Hat)
2025-11-24 15:18 ` Lorenzo Stoakes
2025-11-24 17:11 ` Zi Yan
2025-11-22 2:55 ` Zi Yan [this message]
2025-11-23 1:56 ` [PATCH v2 4/4] mm/huge_memory: fix folio split stats counting Wei Yang
2025-11-24 10:45 ` David Hildenbrand (Red Hat)
2025-11-24 17:23 ` Zi Yan
2025-11-24 15:21 ` Lorenzo Stoakes
2025-11-24 17:29 ` Zi Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251122025529.1562592-5-ziy@nvidia.com \
--to=ziy@nvidia.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=balbirs@nvidia.com \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@kernel.org \
--cc=dev.jain@arm.com \
--cc=lance.yang@linux.dev \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=nao.horiguchi@gmail.com \
--cc=npache@redhat.com \
--cc=richard.weiyang@gmail.com \
--cc=ryan.roberts@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox