* Re: [PATCH v2 5/8] x86/irq: soft_moderation: add support for posted_msi (intel)
[not found] <20251116182839.939139-6-lrizzo@google.com>
@ 2025-11-17 21:36 ` kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2025-11-17 21:36 UTC (permalink / raw)
To: Luigi Rizzo, Thomas Gleixner, Marc Zyngier, Luigi Rizzo,
Paolo Abeni, Andrew Morton, Sean Christopherson, Jacob Pan
Cc: llvm, oe-kbuild-all, Linux Memory Management List, linux-kernel,
linux-arch, Bjorn Helgaas, Willem de Bruijn
Hi Luigi,
kernel test robot noticed the following build errors:
[auto build test ERROR on tip/irq/core]
[also build test ERROR on tip/x86/core tip/master linus/master v6.18-rc6 next-20251117]
[cannot apply to tip/auto-latest]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Luigi-Rizzo/genirq-platform-wide-interrupt-moderation-Documentation-Kconfig-irq_desc/20251117-023148
base: tip/irq/core
patch link: https://lore.kernel.org/r/20251116182839.939139-6-lrizzo%40google.com
patch subject: [PATCH v2 5/8] x86/irq: soft_moderation: add support for posted_msi (intel)
config: x86_64-buildonly-randconfig-003-20251118 (https://download.01.org/0day-ci/archive/20251118/202511180439.x4dMf653-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251118/202511180439.x4dMf653-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202511180439.x4dMf653-lkp@intel.com/
All errors (new ones prefixed by >>):
>> kernel/irq/irq_moderation.c:369:6: error: call to undeclared function 'posted_msi_supported'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
369 | posted_msi_supported() ? " (also on posted_msi)" : "",
| ^
1 error generated.
vim +/posted_msi_supported +369 kernel/irq/irq_moderation.c
321
322 seq_printf(p, HEAD_FMT,
323 "# CPU", "irq/s", "my_irq/s", "cpus", "srcs", "delay_ns",
324 "irq_hi", "my_irq_hi", "hardirq_hi", "timer_set",
325 "disable_irq", "from_msi", "timer_calls", "stray_irq");
326
327 for_each_possible_cpu(j) {
328 struct irq_mod_state *ms = per_cpu_ptr(&irq_mod_state, j);
329 u64 age_ms = min((now - ms->last_ns) / NSEC_PER_MSEC, (u64)999999);
330
331 if (age_ms < 10000) {
332 /* Average irq_rate over recently active CPUs. */
333 active_cpus++;
334 irq_rate += ms->irq_rate;
335 } else {
336 ms->irq_rate = 0;
337 ms->my_irq_rate = 0;
338 ms->scaled_cpu_count = 64;
339 ms->scaled_src_count = 64;
340 ms->mod_ns = 0;
341 }
342
343 irq_high += ms->irq_high;
344 my_irq_high += ms->my_irq_high;
345 hardirq_high += ms->hardirq_high;
346
347 seq_printf(p, BODY_FMT,
348 j, ms->irq_rate, ms->my_irq_rate,
349 (ms->scaled_cpu_count + 128) / 256,
350 (ms->scaled_src_count + 128) / 256,
351 ms->mod_ns, ms->irq_high, ms->my_irq_high,
352 ms->hardirq_high, ms->timer_set, ms->disable_irq,
353 ms->from_posted_msi, ms->timer_calls, ms->stray_irq);
354 }
355
356 seq_printf(p, "\n"
357 "enabled %s%s\n"
358 "delay_us %u\n"
359 "timer_rounds %u\n"
360 "target_irq_rate %u\n"
361 "hardirq_percent %u\n"
362 "update_ms %u\n"
363 "scale_cpus %u\n"
364 "count_timer_calls %s\n"
365 "count_msi_calls %s\n"
366 "decay_factor %u\n"
367 "grow_factor %u\n",
368 str_yes_no(delay_us > 0),
> 369 posted_msi_supported() ? " (also on posted_msi)" : "",
370 delay_us, irq_mod_info.timer_rounds,
371 irq_mod_info.target_irq_rate, irq_mod_info.hardirq_percent,
372 irq_mod_info.update_ms, irq_mod_info.scale_cpus,
373 str_yes_no(irq_mod_info.count_timer_calls),
374 str_yes_no(irq_mod_info.count_msi_calls),
375 irq_mod_info.decay_factor, irq_mod_info.grow_factor);
376
377 seq_printf(p,
378 "irq_rate %lu\n"
379 "irq_high %lu\n"
380 "my_irq_high %lu\n"
381 "hardirq_percent_high %lu\n"
382 "total_interrupts %lu\n"
383 "total_cpus %lu\n",
384 active_cpus ? irq_rate / active_cpus : 0,
385 irq_high, my_irq_high, hardirq_high,
386 READ_ONCE(*((ulong *)&irq_mod_info.total_intrs)),
387 READ_ONCE(*((ulong *)&irq_mod_info.total_cpus)));
388
389 return 0;
390 }
391
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread