From: Peng Li <peng8420.li@gmail.com>
To: linux-mm@kvack.org, akpm@linux-foundation.org
Cc: david@redhat.com, osalvador@suse.de, jgg@ziepe.ca,
jhubbard@nvidia.com, peterx@redhat.com,
linux-kernel@vger.kernel.org, dan.j.williams@intel.com,
Peng Li <peng8420.li@gmail.com>,
David Hildenbrand <david@kernel.org>
Subject: [PATCH v3 2/2] selftests/mm: gup_test: fix comment regarding origin of FOLL_WRITE
Date: Mon, 17 Nov 2025 23:40:12 +0800 [thread overview]
Message-ID: <20251117154012.197499-2-peng8420.li@gmail.com> (raw)
In-Reply-To: <20251117154012.197499-1-peng8420.li@gmail.com>
From: Peng Li <peng8420.li@gmail.com>
The 'FOLL_WRITE' of the copied source is located in mm_types.h
of mm, not mm.h, so fix it.
Signed-off-by: Peng Li <peng8420.li@gmail.com>
Reviewed-by: John Hubbard <jhubbard@nvidia.com>
Reviewed-by: David Hildenbrand (Red Hat) <david@kernel.org>
---
tools/testing/selftests/mm/gup_test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/mm/gup_test.c b/tools/testing/selftests/mm/gup_test.c
index 75f7134d529d..40c1538a17b4 100644
--- a/tools/testing/selftests/mm/gup_test.c
+++ b/tools/testing/selftests/mm/gup_test.c
@@ -17,7 +17,7 @@
#define MB (1UL << 20)
-/* Just the flags we need, copied from mm.h: */
+/* Just the flags we need, copied from the kernel internals. */
#define FOLL_WRITE 0x01 /* check pte is writable */
#define GUP_TEST_FILE "/sys/kernel/debug/gup_test"
--
2.43.0
prev parent reply other threads:[~2025-11-17 15:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-17 15:40 [PATCH v3 1/2] selftests/mm: gup_test: stop testing FOLL_TOUCH Peng Li
2025-11-17 15:40 ` Peng Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251117154012.197499-2-peng8420.li@gmail.com \
--to=peng8420.li@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=david@kernel.org \
--cc=david@redhat.com \
--cc=jgg@ziepe.ca \
--cc=jhubbard@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=osalvador@suse.de \
--cc=peterx@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox