From: Andrew Morton <akpm@linux-foundation.org>
To: "Liam R. Howlett" <Liam.Howlett@oracle.com>
Cc: Suren Baghdasaryan <surenb@google.com>,
Vlastimil Babka <vbabka@suse.cz>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Shakeel Butt <shakeel.butt@linux.dev>,
Jann Horn <jannh@google.com>,
stable@vger.kernel.org,
syzbot+131f9eb2b5807573275c@syzkaller.appspotmail.com
Subject: Re: [PATCH] mm/mmap_lock: Reset maple state on lock_vma_under_rcu() retry
Date: Wed, 12 Nov 2025 12:24:46 -0800 [thread overview]
Message-ID: <20251112122446.e1f2c037550dc591a4d6b307@linux-foundation.org> (raw)
In-Reply-To: <aoq7jyue2qamctxmvtlic4nv53phskj6k7iizh7k6kwruwdgxk@qgjnaib7xgze>
On Tue, 11 Nov 2025 21:18:19 -0500 "Liam R. Howlett" <Liam.Howlett@oracle.com> wrote:
> > Prior to commit 0b16f8bed19c ("mm: change vma_start_read() to drop RCU
> > lock on failure"), vma_start_read() would drop rcu read lock and
> > return NULL, so the retry would not have happened. However, now that
> > vma_start_read() drops rcu read lock on failure followed by a retry,
> > we may end up using a freed maple tree node cached in the maple state.
>
> Yes, sounds good.
>
> Andrew, can you make this change and also drop Cc stable tag?
Done.
> This needs to be a hot fix, as Vlastimil said earlier.
Yup.
next prev parent reply other threads:[~2025-11-12 20:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-11 21:56 Liam R. Howlett
2025-11-11 22:18 ` Vlastimil Babka
2025-11-12 0:10 ` Suren Baghdasaryan
2025-11-12 0:19 ` Liam R. Howlett
2025-11-12 0:45 ` Suren Baghdasaryan
2025-11-12 2:18 ` Liam R. Howlett
2025-11-12 20:24 ` Andrew Morton [this message]
2025-11-12 15:06 ` Lorenzo Stoakes
2025-11-12 16:10 ` Liam R. Howlett
2025-11-13 15:15 ` Lorenzo Stoakes
2025-11-13 0:04 ` Matthew Wilcox
2025-11-13 1:27 ` Paul E. McKenney
2025-11-13 11:05 ` Lorenzo Stoakes
2025-11-21 9:08 ` Vlastimil Babka
2025-11-21 16:52 ` Paul E. McKenney
2025-11-13 10:45 ` Lorenzo Stoakes
2025-11-13 17:28 ` Liam R. Howlett
2025-11-14 11:51 ` Lorenzo Stoakes
2025-11-14 17:18 ` Liam R. Howlett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251112122446.e1f2c037550dc591a4d6b307@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=Liam.Howlett@oracle.com \
--cc=jannh@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=shakeel.butt@linux.dev \
--cc=stable@vger.kernel.org \
--cc=surenb@google.com \
--cc=syzbot+131f9eb2b5807573275c@syzkaller.appspotmail.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox