From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1B42ACCFA13 for ; Mon, 10 Nov 2025 15:50:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 729158E002D; Mon, 10 Nov 2025 10:50:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 700C08E002B; Mon, 10 Nov 2025 10:50:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5A1758E002D; Mon, 10 Nov 2025 10:50:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 41F1B8E002B for ; Mon, 10 Nov 2025 10:50:15 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 024A586210 for ; Mon, 10 Nov 2025 15:50:14 +0000 (UTC) X-FDA: 84095133990.04.34DD431 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) by imf26.hostedemail.com (Postfix) with ESMTP id 2677D14000B for ; Mon, 10 Nov 2025 15:50:12 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=GcKkt0r5; spf=pass (imf26.hostedemail.com: domain of loic.molinari@collabora.com designates 148.251.105.195 as permitted sender) smtp.mailfrom=loic.molinari@collabora.com; dmarc=pass (policy=none) header.from=collabora.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1762789813; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=G0aY04lOY/CCuWlgh9pgGDrSjRkpor/EJ9scCjjW61I=; b=mz3qWXOe9Gug7WEJ6qRQIJABo2RWI/R7ajkn6ODx4+o786YIW58kz31KwcahDVByDyt1k1 3+ncxw4/IEQgF2Z+KMY99bXgLChtrZmR/ffm8KWm4O77lAwrb+aZZdID69nvpga2mnQyEn g14e1Z+SVTH7pSqwBVPQjZiWQNU3fsk= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=GcKkt0r5; spf=pass (imf26.hostedemail.com: domain of loic.molinari@collabora.com designates 148.251.105.195 as permitted sender) smtp.mailfrom=loic.molinari@collabora.com; dmarc=pass (policy=none) header.from=collabora.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1762789813; a=rsa-sha256; cv=none; b=uKKzkfLfuavk7jAVBERpzYUQKCy98sWz5Q1ew4FB+hX+wzmeggWFFi+zkaO5/M/cT2tIJR M9tc6F1qfP+a8D+vR/2s76/ZUxC/sHAQZtUALReWLVkFe75cnD7hhdHOjQPE2wbvUEFUVy RmHYSAidj6qmrwWoxhoSAJlK8Gbpck0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1762789811; bh=CmZzkccIUL92ZcDISbCLHJ25kFHzLgptyvzB27dAVN8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GcKkt0r53Me+M1pwNywqaQH/RobAgLrN/vCBheM092YOQY+1MDE4igiaNtdHGA0+C cZB9VF15Vd0ubNNPiaT8yuJMznbicTmzeJK3WOcrdu+JcFO8Rz92ZCOJmMdSRjv+ih AC371X71M7XFS8QQZ08fhrZkJNoxDkygBzQgxIIOC//dSHl3SLDaHVYWZmu9BrJT6c FoWXRD01fvDWZZ87w4hbETvVrXdrno6PJ9JYR7N6cpR7jSVT7vqUoVPzlXfOHBkyMr qT33pao8VRmexG+q6/Cx+LpzaQ8kEz02og9hWUgc1m8yKxAGe2i7PzI0oFgyd22cST IKctUxj2AIWdw== Received: from debian-rockchip-rock5b-rk3588.. (unknown [IPv6:2a01:e0a:5e3:6100:826d:bc07:e98c:84a]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: loicmolinari) by bali.collaboradmins.com (Postfix) with ESMTPSA id 1CA5817E130A; Mon, 10 Nov 2025 16:50:10 +0100 (CET) From: =?UTF-8?q?Lo=C3=AFc=20Molinari?= To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Boris Brezillon , Rob Herring , Steven Price , Liviu Dudau , Melissa Wen , =?UTF-8?q?Ma=C3=ADra=20Canal?= , Hugh Dickins , Baolin Wang , Andrew Morton , =?UTF-8?q?Lo=C3=AFc=20Molinari?= , Al Viro , =?UTF-8?q?Miko=C5=82aj=20Wasiak?= , Christian Brauner , Nitin Gote , Andi Shyti , Jonathan Corbet , Christopher Healy , Matthew Wilcox , Bagas Sanjaya Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, kernel@collabora.com Subject: [PATCH v7 04/11] drm/gem: Add huge tmpfs mountpoint helpers Date: Mon, 10 Nov 2025 16:49:52 +0100 Message-ID: <20251110155000.2936-5-loic.molinari@collabora.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251110155000.2936-1-loic.molinari@collabora.com> References: <20251110155000.2936-1-loic.molinari@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 2677D14000B X-Stat-Signature: 34xiynr11s89sijxaqk1473rujznajg9 X-Rspamd-Server: rspam02 X-Rspam-User: X-HE-Tag: 1762789812-370678 X-HE-Meta: U2FsdGVkX18zrkRimgB/lSR8lQgA/IJ8t/KidWJ+3bjk5PEiJMkgvssXvtoJmIoQ93x4pTAORiyWAaq1ritJXhdRX/wUghUShpLahbt6R+IF1jqiwZAYQbtwLVuXpPzsjFVgVQYlUO5p4ZlurH5eEjNM5J8pmLhoyCkfc3lmcBnjGpnC6MBVe4Y4G5vF+r1gVoltOdptaSkqa4jHhEw037XEh6XyX+CAyGZs2DHHBK4WDKTooH/9+eionsuULirffPjYwSZhVyclLX6theKhVS2XGYOjq1IGItSNElldIodRs4ioqmTNyU0SW/W+KYJq7BcYiyasjnDwtSLsLhD/MBIlaFR+WI8USGcbSY+ymDqCmJeUDH51PQhCf9agjfTAsEGZUOLVDzgGsk73eW5J4qLcln0zxFtWT2svDRI/iI5AvJ24EhhCuDHYvd2hLnd1F+iJE4I02XPiuZ5p8/pXqdKm5eynLNWrwzbKwb4lOKuDdcCm6Wu/GBTA0vNMJ12AI2LUwhC1nkYqCB742rzDTCxzWZD5FzgkJgBB9iB/gJLo/hRjikV4TApykWWl+IwK6LlfI7CKJt+5hhHLxKi/oY6XSHJkzU2yhaY6wMbKi/eZ+pTaDSvHAk0q8vFtqVJl+an9sCpEi0hY7of01rmzNj3p3hIA7o+djOoqTmnmib3JeBv19dVAF02RY1xAQA1Yc6IzzO4wJkDqXqTEs8tDSQ6wfNvbYxapUd1CHBog2bKcr+VVmTHuDCTXvyLL5IbBLezdhAiNKebqx4l8og6yW1BEGvk84ezFIXRQKNbAbr8t98/vbUMDbKR4ZY1Lp4paQVjcRovGg+zZe6pVjPdUALJEl4so5nY24osu+3WvK76Rgllq8y8xqUXzhWEKOmUfZ+XaerjDy6O8ioXuvxz3uewjiW9v7EjZOpYuqtiwwWLtywvarhOsOdpQHBOOZSJehuM8HgxMK0xtkmmraa5 /6WE21Yq XBz0dvxdzfbP8FJGZvUQWmnqbvT4EfpCW11/+IvT1EVuvC/blvmR+3P0Fqo2pBmlGjULGuQ/3yMiUUUfU9TPyZu+WEi2b0O80uLbqBfLqDduaFxqkY/9XC14ROU5qYED5fkcvlaDmkHZUj8DSLPGEXQZwrJtGvy+E0oaPWYDXELCHEL8wNSgtoniZ6jpEzXTQTvpAhFUqGngparselKMm2U3FnOIReOi/5C+C4b+TagYTCPCHgN3fJU+/DwjuQOditB/6tNMA3ovmIY37fWn//7K+P88gBSTYj/MbtlXGTp71io6UszdUZSxGlBpDA1ClTXO7dP68ROBUFbSuG2Jtgphf9lTbjLuzNTjU18LTOTG3rjzefzTfB3S+pbnwz4JnVilK X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Add the drm_gem_huge_mnt_create() and drm_gem_has_huge_mnt() helpers to avoid code duplication in the i915, V3D, Panfrost and Panthor drivers. The former creates and mounts a dedicated huge tmpfs mountpoint, for the lifetime of a DRM device, used at GEM object initialization. The latter checks whether a dedicated huge tmpfs mountpoint is in use by a DRM device. The next commits will port drivers to this helper. v3: - store huge tmpfs mountpoint in drm_device v4: - return 0 in builds with CONFIG_TRANSPARENT_HUGEPAGE=n - return 0 when huge_mnt already exists - use new vfs_parse_fs_string() helper v5: - remove warning on !dev->huge_mnt and reset to NULL on free - inline drm_gem_huge_mnt_create() to remove func from text and avoid calls in builds with CONFIG_TRANSPARENT_HUGEPAGE=n - compile out drm_device's huge_mnt field in builds with CONFIG_TRANSPARENT_HUGEPAGE=n - add drm_gem_has_huge_mnt() helper v6: - move huge_mnt doc into ifdef'd section - either inline or export drm_gem_huge_mnt_create() v7: - include in drm_gem.h Signed-off-by: Loïc Molinari --- drivers/gpu/drm/drm_gem.c | 57 +++++++++++++++++++++++++++++++++++++++ include/drm/drm_device.h | 15 +++++++++++ include/drm/drm_gem.h | 33 +++++++++++++++++++++++ 3 files changed, 105 insertions(+) diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c index 2a0eecc0d3e4..bbca2ab9e9a5 100644 --- a/drivers/gpu/drm/drm_gem.c +++ b/drivers/gpu/drm/drm_gem.c @@ -29,6 +29,9 @@ #include #include #include +#ifdef CONFIG_TRANSPARENT_HUGEPAGE +#include +#endif #include #include #include @@ -82,6 +85,60 @@ * up at a later date, and as our interface with shmfs for memory allocation. */ +#ifdef CONFIG_TRANSPARENT_HUGEPAGE +static void drm_gem_huge_mnt_free(struct drm_device *dev, void *data) +{ + kern_unmount(dev->huge_mnt); +} + +/** + * drm_gem_huge_mnt_create - Create, mount and use a huge tmpfs mountpoint + * @dev: DRM device a huge tmpfs mountpoint should be used with + * @value: huge tmpfs mount option value + * + * This function creates and mounts a dedicated huge tmpfs mountpoint for the + * lifetime of the DRM device @dev which is used at GEM object initialization + * with drm_gem_object_init(). + * + * The most common option value @value is "within_size" which only allocates + * huge pages if the page will be fully within the GEM object size. "always", + * "advise" and "never" are supported too but the latter would just create a + * mountpoint similar to the default one (`shm_mnt`). See shmemfs and + * Transparent Hugepage for more information. + * + * Returns: + * 0 on success or a negative error code on failure. + */ +int drm_gem_huge_mnt_create(struct drm_device *dev, const char *value) +{ + struct file_system_type *type; + struct fs_context *fc; + int ret; + + if (unlikely(drm_gem_has_huge_mnt(dev))) + return 0; + + type = get_fs_type("tmpfs"); + if (unlikely(!type)) + return -EOPNOTSUPP; + fc = fs_context_for_mount(type, SB_KERNMOUNT); + if (IS_ERR(fc)) + return PTR_ERR(fc); + ret = vfs_parse_fs_string(fc, "source", "tmpfs"); + if (unlikely(ret)) + return -ENOPARAM; + ret = vfs_parse_fs_string(fc, "huge", value); + if (unlikely(ret)) + return -ENOPARAM; + + dev->huge_mnt = fc_mount_longterm(fc); + put_fs_context(fc); + + return drmm_add_action_or_reset(dev, drm_gem_huge_mnt_free, NULL); +} +EXPORT_SYMBOL_GPL(drm_gem_huge_mnt_create); +#endif + static void drm_gem_init_release(struct drm_device *dev, void *ptr) { diff --git a/include/drm/drm_device.h b/include/drm/drm_device.h index 778b2cca6c49..bcde07c43e3f 100644 --- a/include/drm/drm_device.h +++ b/include/drm/drm_device.h @@ -3,6 +3,9 @@ #include #include +#ifdef CONFIG_TRANSPARENT_HUGEPAGE +#include +#endif #include #include #include @@ -168,6 +171,18 @@ struct drm_device { */ struct drm_master *master; +#ifdef CONFIG_TRANSPARENT_HUGEPAGE + /** + * @huge_mnt: + * + * Huge tmpfs mountpoint used at GEM object initialization + * drm_gem_object_init(). Drivers can call drm_gem_huge_mnt_create() to + * create a huge tmfps mountpoint. The default tmpfs mountpoint + * (`shm_mnt`) is used if NULL. + */ + struct vfsmount *huge_mnt; +#endif + /** * @driver_features: per-device driver features * diff --git a/include/drm/drm_gem.h b/include/drm/drm_gem.h index 7c8bd67d087c..58fa1e6b9773 100644 --- a/include/drm/drm_gem.h +++ b/include/drm/drm_gem.h @@ -40,6 +40,9 @@ #include #include +#ifdef CONFIG_TRANSPARENT_HUGEPAGE +#include +#endif #include struct iosys_map; @@ -492,6 +495,36 @@ struct drm_gem_object { DRM_GEM_FOPS,\ } +#ifdef CONFIG_TRANSPARENT_HUGEPAGE +int drm_gem_huge_mnt_create(struct drm_device *dev, const char *value); +#else +static inline int drm_gem_huge_mnt_create(struct drm_device *dev, + const char *value) +{ + return 0; +} +#endif + +/** + * drm_gem_has_huge_mnt - Check if a huge tmpfs mountpoint is in use + * @dev: DRM device + * + * This function checks whether a huge tmpfs mountpoint is in use after by DRM + * device @dev. A huge tmpfs mountpoint is used after a successful call to + * drm_gem_huge_mnt_create() on builds with Transparent Hugepage enabled. + * + * Returns: + * true on success, false otherwise. + */ +static inline bool drm_gem_has_huge_mnt(struct drm_device *dev) +{ +#ifdef CONFIG_TRANSPARENT_HUGEPAGE + return !!dev->huge_mnt; +#else + return false; +#endif +} + void drm_gem_object_release(struct drm_gem_object *obj); void drm_gem_object_free(struct kref *kref); int drm_gem_object_init(struct drm_device *dev, -- 2.47.3