From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 73351CCF9E3 for ; Mon, 10 Nov 2025 14:28:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3B02D8E001C; Mon, 10 Nov 2025 09:28:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 388A58E0002; Mon, 10 Nov 2025 09:28:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 251C98E001F; Mon, 10 Nov 2025 09:28:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 0442A8E0002 for ; Mon, 10 Nov 2025 09:28:00 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id AF1E9137532 for ; Mon, 10 Nov 2025 14:27:59 +0000 (UTC) X-FDA: 84094926678.16.736F21C Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) by imf24.hostedemail.com (Postfix) with ESMTP id C2E70180004 for ; Mon, 10 Nov 2025 14:27:57 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=hUHusAAM; spf=pass (imf24.hostedemail.com: domain of loic.molinari@collabora.com designates 148.251.105.195 as permitted sender) smtp.mailfrom=loic.molinari@collabora.com; dmarc=pass (policy=none) header.from=collabora.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1762784878; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Y8bqc7k5ffSYLcnCkC2cFpHb45P0+KNSqsjAHF8Ni8I=; b=kFXXT6sohhi34D1KRaE8auff6xIXSXFoZOKCQ3z80AWIp1aaN6uNynHSZIicmm/WUg1oxR Uxb5Ff1SNvFe4vzobDDH275/J8A78dWCk969C272sJHMBlVt1WfTAci7oIxsroGw9fBAnd nfqSoal+HTGNEjpk6WqXv1K2jIqrm3g= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=hUHusAAM; spf=pass (imf24.hostedemail.com: domain of loic.molinari@collabora.com designates 148.251.105.195 as permitted sender) smtp.mailfrom=loic.molinari@collabora.com; dmarc=pass (policy=none) header.from=collabora.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1762784878; a=rsa-sha256; cv=none; b=Btpf3v+rFqhdGfT0IkqgPjiT5QvV10Lvs0mqItW788/g2cpBsKRM+an0BAKXtNJv2041wl AWXiX87eZ6L/KIHqWg6uRaDKIusIvyuYyv0+91vJygRpf3GDn88pDf527AWPjXidYJJD0B /ln2Mo6oilHCnasIzHnQ9fE5qa1J7b0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1762784876; bh=y5nkQgQMrTrvRwMVZLtSuSfJVQVW2Gt3f418Lny6C0s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hUHusAAM9kZwwG29Li7scxkz83k15tYQBntxXDHJVcq4SJnLVX19oaVSpiRAxLvPU qiBUapKIX3XPr9DrSvLw6je3vKpOBtx+tAp6PVcPzl67OdkEKjI12buSNOE2U4leMh U9az+hkepk21XyI+oTq4DbDBT+F3xDUGaijLGEXyngGQNz2LBo/Qy52XO6ap4WIATY +pMOqG7WU4PDTKKeBFpSxo6+uRe7nsQgXJA3kEtEi2TAaVB2Xdfpud+OnVpO87lnpc s5VyHqA5zs7h/WsRtowsUKlui0Ld0ooimoH3I/qFDgvwe2hNBFl/CpYG34GXyIW/Jw Mxw7EPWPS1uWg== Received: from debian-rockchip-rock5b-rk3588.. (unknown [IPv6:2a01:e0a:5e3:6100:2e0:4cff:fe03:d8c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: loicmolinari) by bali.collaboradmins.com (Postfix) with ESMTPSA id 65D7C17E153A; Mon, 10 Nov 2025 15:27:55 +0100 (CET) From: =?UTF-8?q?Lo=C3=AFc=20Molinari?= To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Boris Brezillon , Rob Herring , Steven Price , Liviu Dudau , Melissa Wen , =?UTF-8?q?Ma=C3=ADra=20Canal?= , Hugh Dickins , Baolin Wang , Andrew Morton , =?UTF-8?q?Lo=C3=AFc=20Molinari?= , Al Viro , =?UTF-8?q?Miko=C5=82aj=20Wasiak?= , Christian Brauner , Nitin Gote , Andi Shyti , Jonathan Corbet , Christopher Healy , Matthew Wilcox , Bagas Sanjaya Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, kernel@collabora.com Subject: [PATCH v6 05/11] drm/i915: Use huge tmpfs mountpoint helpers Date: Mon, 10 Nov 2025 15:27:40 +0100 Message-ID: <20251110142746.3490-6-loic.molinari@collabora.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251110142746.3490-1-loic.molinari@collabora.com> References: <20251110142746.3490-1-loic.molinari@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: C2E70180004 X-Stat-Signature: etmnsn5fn9pfxogdkyk4crmek5xscb5m X-Rspam-User: X-HE-Tag: 1762784877-24214 X-HE-Meta: U2FsdGVkX184ZdJD/xb5JFJt0WqBUuQXfopl/iifyhZPeSnXmKFoVY+hiJ/90CrOXMK/bBIlt0RbQ8KfWYHWgtcsrXFEITAztUq/K+NLmxc5S9w4TPfILXiKKaEkb0NHynYCMKg3cWuqYx91Ps6v+8NUoRhxuwmaQR+ZPA64LUEfuxPYAc2Is9k+/bib+zZbLlkM6sdRvkNhIYfiRjRbchCAW/pvH5ZtZlXoAZuBZH4b5y00UgiLX5MWh9I6jCAVJsjRsQXV4CT3xG2TWYkFurNQ+8+nSobsIpjHsjRZ1uu4eUfSwSjfmHG+VhT4nfKTDDi7IVM5mBhy4QNRIlObA2GjNff+O6vX9lrlhixh7ziQZYf67MSqLvjLngjNsXrKuzyoBl74wTgq3BQ1qXV9ttbs9IeUWPTvSl02WoGTU343SVDAEW8B6jogwSYGJijatFkGekAFaFSAryvPmgeo1NAtbXNe1EuC3GijETibIuHdwyEu5vfVenRSm4Vv4gMT0GaB/7Cs5GsBBTbQQjZsKqDe2/slCvyjXbNvqqwtd5kRCrRBOPgn+4430esHfu9MW/03CjlrnGYJ2rj/3VHJX6PszaCZ+t7d7Su8Mw0XwZ1EbBRZitQVZw7bSSVE/0mtfU1FVia/xMSQ9mk3XyQAxgLBRfPNzW0w8LWx7VFZpnGMZcX4XBxc+rtVt2wW0XxhMBstQJmJRfhSlvGlt5AJ/ADF5s76WFsx7DCfFZtCL4ohA3yaPKUIaERzbywuULBX/SqmniFeh6E3w6/OB+KN5YsbbnS/uV5MJ95P1giCUDdsX78LJGU2pjlqYNLGy76zvQMcPpulWk+Kz4WBRscDHk3LU2qS7WNYT38K4S5667Vq5zVUszdUm86k0xiThD/961UlyB278Ttah+huUK/GzMdX3DchcogYhGgvLEXDEKyiwRD5ZrTRPjElkb4MGdoxFXi+0AygiNH5fTMBL4w 5cGYYPY4 l2UudDFZVCNj3ggGJilOgdwLIakotjWfBBQZRcp/94gUZ8GYl9KWqj+fER2j+EHoZvjenZFnhGr/RBatD7SsiaNPgcoJqqdjX+ounRO6qeCLTNlk6CUgH6gOAwinkGzJUcRFEXK+6BAoROga+PZkVruEpIUz6Lw7VMiafOATgEhe2CShJY695OkCHdqign8gaHl8QrlKAFSQCGA/7TofQfHIhejfK9WhliLkTq8k0+SFaht2yzqVVKhR8bqjIUu1OVql87yCHPlf1M3is0Oi4IROCHrwN2mP3bii5uYbdUita+LZV5J5oo2rDTcz6qWkzfXLer22Vln8i5X8Mqw9H/aOPxiD9xhhqLX4rvyAE22P1b5lcTeElyQXuSPQPF09PIhqj X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Make use of the new drm_gem_huge_mnt_create() and drm_gem_has_huge_mnt() helpers to avoid code duplication. Now that it's just a few lines long, the single function in i915_gemfs.c is moved into v3d_gem_shmem.c. v3: - use huge tmpfs mountpoint in drm_device - move i915_gemfs.c into i915_gem_shmem.c v4: - clean up mountpoint creation error handling v5: - Use drm_gem_has_huge_mnt() helper Signed-off-by: Loïc Molinari --- drivers/gpu/drm/i915/Makefile | 3 +- drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 47 +++++++++---- drivers/gpu/drm/i915/gem/i915_gemfs.c | 69 ------------------- drivers/gpu/drm/i915/gem/i915_gemfs.h | 14 ---- .../gpu/drm/i915/gem/selftests/huge_pages.c | 11 +-- drivers/gpu/drm/i915/i915_drv.h | 5 -- 6 files changed, 41 insertions(+), 108 deletions(-) delete mode 100644 drivers/gpu/drm/i915/gem/i915_gemfs.c delete mode 100644 drivers/gpu/drm/i915/gem/i915_gemfs.h diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile index e58c0c158b3a..e22393a7cf6f 100644 --- a/drivers/gpu/drm/i915/Makefile +++ b/drivers/gpu/drm/i915/Makefile @@ -163,8 +163,7 @@ gem-y += \ gem/i915_gem_ttm_move.o \ gem/i915_gem_ttm_pm.o \ gem/i915_gem_userptr.o \ - gem/i915_gem_wait.o \ - gem/i915_gemfs.o + gem/i915_gem_wait.o i915-y += \ $(gem-y) \ i915_active.o \ diff --git a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c b/drivers/gpu/drm/i915/gem/i915_gem_shmem.c index b9dae15c1d16..944aceac4cd3 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_shmem.c @@ -9,14 +9,15 @@ #include #include +#include #include "gem/i915_gem_region.h" #include "i915_drv.h" #include "i915_gem_object.h" #include "i915_gem_tiling.h" -#include "i915_gemfs.h" #include "i915_scatterlist.h" #include "i915_trace.h" +#include "i915_utils.h" /* * Move folios to appropriate lru and release the batch, decrementing the @@ -506,9 +507,9 @@ static int __create_shmem(struct drm_i915_private *i915, if (BITS_PER_LONG == 64 && size > MAX_LFS_FILESIZE) return -E2BIG; - if (i915->mm.gemfs) - filp = shmem_file_setup_with_mnt(i915->mm.gemfs, "i915", size, - flags); + if (drm_gem_has_huge_mnt(&i915->drm)) + filp = shmem_file_setup_with_mnt(i915->drm.huge_mnt, "i915", + size, flags); else filp = shmem_file_setup("i915", size, flags); if (IS_ERR(filp)) @@ -635,21 +636,41 @@ i915_gem_object_create_shmem_from_data(struct drm_i915_private *i915, static int init_shmem(struct intel_memory_region *mem) { - i915_gemfs_init(mem->i915); - intel_memory_region_set_name(mem, "system"); + struct drm_i915_private *i915 = mem->i915; + int err; - return 0; /* We have fallback to the kernel mnt if gemfs init failed. */ -} + /* + * By creating our own shmemfs mountpoint, we can pass in + * mount flags that better match our usecase. + * + * One example, although it is probably better with a per-file + * control, is selecting huge page allocations ("huge=within_size"). + * However, we only do so on platforms which benefit from it, or to + * offset the overhead of iommu lookups, where with latter it is a net + * win even on platforms which would otherwise see some performance + * regressions such a slow reads issue on Broadwell and Skylake. + */ -static int release_shmem(struct intel_memory_region *mem) -{ - i915_gemfs_fini(mem->i915); - return 0; + if (GRAPHICS_VER(i915) < 11 && !i915_vtd_active(i915)) + goto no_thp; + + err = drm_gem_huge_mnt_create(&i915->drm, "within_size"); + if (drm_gem_has_huge_mnt(&i915->drm)) + drm_info(&i915->drm, "Using Transparent Hugepages\n"); + else if (err) + drm_notice(&i915->drm, + "Transparent Hugepage support is recommended for optimal performance%s\n", + GRAPHICS_VER(i915) >= 11 ? " on this platform!" : + " when IOMMU is enabled!"); + + no_thp: + intel_memory_region_set_name(mem, "system"); + + return 0; /* We have fallback to the kernel mnt if huge mnt failed. */ } static const struct intel_memory_region_ops shmem_region_ops = { .init = init_shmem, - .release = release_shmem, .init_object = shmem_object_init, }; diff --git a/drivers/gpu/drm/i915/gem/i915_gemfs.c b/drivers/gpu/drm/i915/gem/i915_gemfs.c deleted file mode 100644 index 8f13ec4ff0d0..000000000000 --- a/drivers/gpu/drm/i915/gem/i915_gemfs.c +++ /dev/null @@ -1,69 +0,0 @@ -// SPDX-License-Identifier: MIT -/* - * Copyright © 2017 Intel Corporation - */ - -#include -#include -#include - -#include "i915_drv.h" -#include "i915_gemfs.h" -#include "i915_utils.h" - -void i915_gemfs_init(struct drm_i915_private *i915) -{ - struct file_system_type *type; - struct fs_context *fc; - struct vfsmount *gemfs; - int ret; - - /* - * By creating our own shmemfs mountpoint, we can pass in - * mount flags that better match our usecase. - * - * One example, although it is probably better with a per-file - * control, is selecting huge page allocations ("huge=within_size"). - * However, we only do so on platforms which benefit from it, or to - * offset the overhead of iommu lookups, where with latter it is a net - * win even on platforms which would otherwise see some performance - * regressions such a slow reads issue on Broadwell and Skylake. - */ - - if (GRAPHICS_VER(i915) < 11 && !i915_vtd_active(i915)) - return; - - if (!IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE)) - goto err; - - type = get_fs_type("tmpfs"); - if (!type) - goto err; - - fc = fs_context_for_mount(type, SB_KERNMOUNT); - if (IS_ERR(fc)) - goto err; - ret = vfs_parse_fs_string(fc, "source", "tmpfs"); - if (!ret) - ret = vfs_parse_fs_string(fc, "huge", "within_size"); - if (!ret) - gemfs = fc_mount_longterm(fc); - put_fs_context(fc); - if (ret) - goto err; - - i915->mm.gemfs = gemfs; - drm_info(&i915->drm, "Using Transparent Hugepages\n"); - return; - -err: - drm_notice(&i915->drm, - "Transparent Hugepage support is recommended for optimal performance%s\n", - GRAPHICS_VER(i915) >= 11 ? " on this platform!" : - " when IOMMU is enabled!"); -} - -void i915_gemfs_fini(struct drm_i915_private *i915) -{ - kern_unmount(i915->mm.gemfs); -} diff --git a/drivers/gpu/drm/i915/gem/i915_gemfs.h b/drivers/gpu/drm/i915/gem/i915_gemfs.h deleted file mode 100644 index 16d4333c9a4e..000000000000 --- a/drivers/gpu/drm/i915/gem/i915_gemfs.h +++ /dev/null @@ -1,14 +0,0 @@ -/* SPDX-License-Identifier: MIT */ -/* - * Copyright © 2017 Intel Corporation - */ - -#ifndef __I915_GEMFS_H__ -#define __I915_GEMFS_H__ - -struct drm_i915_private; - -void i915_gemfs_init(struct drm_i915_private *i915); -void i915_gemfs_fini(struct drm_i915_private *i915); - -#endif diff --git a/drivers/gpu/drm/i915/gem/selftests/huge_pages.c b/drivers/gpu/drm/i915/gem/selftests/huge_pages.c index bd08605a1611..2b9f7d86b46e 100644 --- a/drivers/gpu/drm/i915/gem/selftests/huge_pages.c +++ b/drivers/gpu/drm/i915/gem/selftests/huge_pages.c @@ -1316,7 +1316,7 @@ typedef struct drm_i915_gem_object * static inline bool igt_can_allocate_thp(struct drm_i915_private *i915) { - return i915->mm.gemfs && has_transparent_hugepage(); + return drm_gem_has_huge_mnt(&i915->drm); } static struct drm_i915_gem_object * @@ -1761,7 +1761,8 @@ static int igt_tmpfs_fallback(void *arg) struct drm_i915_private *i915 = arg; struct i915_address_space *vm; struct i915_gem_context *ctx; - struct vfsmount *gemfs = i915->mm.gemfs; + struct vfsmount *huge_mnt = + drm_gem_has_huge_mnt(&i915->drm) ? i915->drm.huge_mnt : NULL; struct drm_i915_gem_object *obj; struct i915_vma *vma; struct file *file; @@ -1782,10 +1783,10 @@ static int igt_tmpfs_fallback(void *arg) /* * Make sure that we don't burst into a ball of flames upon falling back * to tmpfs, which we rely on if on the off-chance we encounter a failure - * when setting up gemfs. + * when setting up a huge mountpoint. */ - i915->mm.gemfs = NULL; + i915->drm.huge_mnt = NULL; obj = i915_gem_object_create_shmem(i915, PAGE_SIZE); if (IS_ERR(obj)) { @@ -1819,7 +1820,7 @@ static int igt_tmpfs_fallback(void *arg) out_put: i915_gem_object_put(obj); out_restore: - i915->mm.gemfs = gemfs; + i915->drm.huge_mnt = huge_mnt; i915_vm_put(vm); out: diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index 6a768aad8edd..1bfee23e64a3 100644 --- a/drivers/gpu/drm/i915/i915_drv.h +++ b/drivers/gpu/drm/i915/i915_drv.h @@ -141,11 +141,6 @@ struct i915_gem_mm { */ atomic_t free_count; - /** - * tmpfs instance used for shmem backed objects - */ - struct vfsmount *gemfs; - struct intel_memory_region *regions[INTEL_REGION_UNKNOWN]; struct notifier_block oom_notifier; -- 2.47.3