From: Wei Yang <richard.weiyang@gmail.com>
To: Zi Yan <ziy@nvidia.com>
Cc: Wei Yang <richard.weiyang@gmail.com>,
akpm@linux-foundation.org, david@redhat.com,
lorenzo.stoakes@oracle.com, baolin.wang@linux.alibaba.com,
Liam.Howlett@oracle.com, npache@redhat.com, ryan.roberts@arm.com,
dev.jain@arm.com, baohua@kernel.org, lance.yang@linux.dev,
linux-mm@kvack.org
Subject: Re: [PATCH] mm/huge_memory: merge uniform_split_supported() and non_uniform_split_supported()
Date: Wed, 5 Nov 2025 02:44:02 +0000 [thread overview]
Message-ID: <20251105024402.ikb5c7ayeq6gmkty@master> (raw)
In-Reply-To: <E1772F62-C1FC-4B67-A47F-7A1A6581C89D@nvidia.com>
On Tue, Nov 04, 2025 at 09:14:31PM -0500, Zi Yan wrote:
>On 4 Nov 2025, at 2:53, Wei Yang wrote:
[...]
>>>>>
>>>>
>>>> How about this one:
>>>>
>>>> swapcache folio could only be split to order 0
>>>
>>> This looks good.
>>>
>>>>
>>>> For non-uniform split or uniform split targeting a large folio, return
>>>> false.
>>>
>>> You are just describing the code.
>>>
>>> non-uniform split creates after-split folios with orders from
>>> folio_order(folio) - 1 to new_order, making it not suitable for any swapcache
>>> folio split. Only uniform split to order-0 can be used here.
>>>
>>
>> Below is the updated version:
>>
>> swapcache folio could only be split to order 0
>>
>> non-uniform split creates after-split folios with orders from
>> folio_order(folio) - 1 to new_order, making it not suitable for any
>> swapcache folio split. Only uniform split to order-0 can be used here.
>
>LGTM.
>
>Thank you for updating the comments. Looking forward to your updated patch.
Thanks for you time and patience, will prepare a new version.
--
Wei Yang
Help you, Help me
prev parent reply other threads:[~2025-11-05 2:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-01 2:11 Wei Yang
2025-11-03 9:04 ` Dev Jain
2025-11-03 16:19 ` Zi Yan
2025-11-03 11:50 ` David Hildenbrand (Red Hat)
2025-11-04 0:41 ` Wei Yang
2025-11-04 9:05 ` David Hildenbrand (Red Hat)
2025-11-04 13:31 ` Wei Yang
2025-11-03 16:34 ` Zi Yan
2025-11-04 0:36 ` Wei Yang
2025-11-04 2:30 ` Zi Yan
2025-11-04 7:53 ` Wei Yang
2025-11-05 2:14 ` Zi Yan
2025-11-05 2:44 ` Wei Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251105024402.ikb5c7ayeq6gmkty@master \
--to=richard.weiyang@gmail.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@redhat.com \
--cc=dev.jain@arm.com \
--cc=lance.yang@linux.dev \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=npache@redhat.com \
--cc=ryan.roberts@arm.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox