linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Christian Brauner <brauner@kernel.org>
To: Zilin Guan <zilin@seu.edu.cn>
Cc: Christian Brauner <brauner@kernel.org>,
	jack@suse.cz, kees@kernel.org, linux-fsdevel@vger.kernel.org,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	jianhao.xu@seu.edu.cn, viro@zeniv.linux.org.uk
Subject: Re: [PATCH] binfmt_misc: restore write access before closing files opened by open_exec()
Date: Wed,  5 Nov 2025 12:12:46 +0100	[thread overview]
Message-ID: <20251105-gebucht-kaktus-f394c88493d5@brauner> (raw)
In-Reply-To: <20251105022923.1813587-1-zilin@seu.edu.cn>

On Wed, 05 Nov 2025 02:29:23 +0000, Zilin Guan wrote:
> bm_register_write() opens an executable file using open_exec(), which
> internally calls do_open_execat() and denies write access on the file to
> avoid modification while it is being executed.
> 
> However, when an error occurs, bm_register_write() closes the file using
> filp_close() directly. This does not restore the write permission, which
> may cause subsequent write operations on the same file to fail.
> 
> [...]

Thanks!

---

Applied to the vfs.fixes branch of the vfs/vfs.git tree.
Patches in the vfs.fixes branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.fixes

[1/1] binfmt_misc: restore write access before closing files opened by open_exec()
      https://git.kernel.org/vfs/vfs/c/0e0c1b03d6d4


      reply	other threads:[~2025-11-05 11:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-05  2:29 Zilin Guan
2025-11-05 11:12 ` Christian Brauner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251105-gebucht-kaktus-f394c88493d5@brauner \
    --to=brauner@kernel.org \
    --cc=jack@suse.cz \
    --cc=jianhao.xu@seu.edu.cn \
    --cc=kees@kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=viro@zeniv.linux.org.uk \
    --cc=zilin@seu.edu.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox