From: Andrew Morton <akpm@linux-foundation.org>
To: Hui Zhu <hui.zhu@linux.dev>
Cc: Muchun Song <muchun.song@linux.dev>,
Oscar Salvador <osalvador@suse.de>,
David Hildenbrand <david@redhat.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Hui Zhu <zhuhui@kylinos.cn>
Subject: Re: [PATCH v3 0/2] mm/hugetlb: refactor sysfs/sysctl interfaces
Date: Tue, 4 Nov 2025 15:06:18 -0800 [thread overview]
Message-ID: <20251104150618.0606afefb2a9e226aaa6ce77@linux-foundation.org> (raw)
In-Reply-To: <cover.1762245157.git.zhuhui@kylinos.cn>
On Tue, 4 Nov 2025 16:37:41 +0800 Hui Zhu <hui.zhu@linux.dev> wrote:
> From: Hui Zhu <zhuhui@kylinos.cn>
>
> The hugetlb.c file has grown significantly and become difficult to
> maintain. This patch series extracts the sysfs and sysctl interface
> code into separate dedicated files to improve code organization.
>
> The refactoring includes:
> - Patch 1: Extract sysfs interface into mm/hugetlb_sysfs.c
> - Patch 2: Extract sysctl interface into mm/hugetlb_sysctl.c
>
> No functional changes are introduced in this series. The code is moved
> as-is, with only minor formatting adjustments for code style
> consistency. This should make future maintenance and enhancements to
> the hugetlb subsystem easier.
>
> Testing: The patch series has been compile-tested and maintains the
> same functionality as the original code.
Thanks.
> MAINTAINERS | 2 +
> mm/Makefile | 2 +-
> mm/hugetlb.c | 852 +-----------------------------------------
> mm/hugetlb_internal.h | 113 ++++++
> mm/hugetlb_sysctl.c | 133 +++++++
> mm/hugetlb_sysfs.c | 629 +++++++++++++++++++++++++++++++
> 6 files changed, 887 insertions(+), 844 deletions(-)
> create mode 100644 mm/hugetlb_internal.h
> create mode 100644 mm/hugetlb_sysctl.c
> create mode 100644 mm/hugetlb_sysfs.c
Seems a reasonable thing to do, although those who work on this code
should have the final call.
This amount of code motion might cause some (easily resolved) merge
issues during the rest of the -rc window - we'll see how it goes.
next prev parent reply other threads:[~2025-11-04 23:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-04 8:37 Hui Zhu
2025-11-04 8:37 ` [PATCH v3 1/2] mm/hugetlb: extract sysfs into hugetlb_sysfs.c Hui Zhu
2025-11-05 11:42 ` David Hildenbrand
2025-11-04 8:37 ` [PATCH v3 2/2] mm/hugetlb: extract sysctl into hugetlb_sysctl.c Hui Zhu
2025-11-04 23:06 ` Andrew Morton [this message]
2025-11-05 11:43 ` [PATCH v3 0/2] mm/hugetlb: refactor sysfs/sysctl interfaces David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251104150618.0606afefb2a9e226aaa6ce77@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=hui.zhu@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=muchun.song@linux.dev \
--cc=osalvador@suse.de \
--cc=zhuhui@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox