From: "Matthew Wilcox (Oracle)" <willy@infradead.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>,
linux-mm@kvack.org, Suren Baghdasaryan <surenb@google.com>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Vlastimil Babka <vbabka@suse.cz>,
Shakeel Butt <shakeel.butt@linux.dev>,
Jann Horn <jannh@google.com>, Pedro Falcato <pfalcato@suse.de>,
Chris Li <chriscli@google.com>
Subject: [PATCH 0/2] vma_start_write_killable
Date: Mon, 3 Nov 2025 18:03:44 +0000 [thread overview]
Message-ID: <20251103180348.3368668-1-willy@infradead.org> (raw)
When we added the VMA lock, we made a major oversight in not adding a
killable variant. That can run us into trouble where a thread takes
the VMA lock for read (eg handling a page fault) and then goes out to
lunch for an hour (eg doing reclaim). Another thread tries to modify
the VMA, taking the mmap_lock for write, then attempts to lock the VMA
for write. That blocks on the first thread, and ensures that every
other page fault now tries to take the mmap_lock for read. Because
everything's in an uninterruptible sleep, we can't kill the task,
which makes me angry.
This patch set just adds vma_start_write_killable() and converts one
caller to use it. Most users are somewhat tricky to convert, so expect
follow-up individual patches per call-site which need careful analysis
to make sure we've done proper cleanup.
Matthew Wilcox (Oracle) (2):
mm: Add vma_start_write_killable()
mm: Use vma_start_write_killable() in dup_mmap()
include/linux/mmap_lock.h | 31 +++++++++++++++++++++++++++++--
mm/mmap.c | 12 +++---------
mm/mmap_lock.c | 27 ++++++++++++++++++---------
tools/testing/vma/vma_internal.h | 8 ++++++++
4 files changed, 58 insertions(+), 20 deletions(-)
--
2.47.2
next reply other threads:[~2025-11-03 18:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-03 18:03 Matthew Wilcox (Oracle) [this message]
2025-11-03 18:03 ` [PATCH 1/2] mm: Add vma_start_write_killable() Matthew Wilcox (Oracle)
2025-11-03 21:53 ` Suren Baghdasaryan
2025-11-03 23:14 ` Matthew Wilcox
2025-11-03 23:17 ` Suren Baghdasaryan
2025-11-04 16:09 ` Matthew Wilcox
2025-11-07 19:12 ` Liam R. Howlett
2025-11-03 18:03 ` [PATCH 2/2] mm: Use vma_start_write_killable() in dup_mmap() Matthew Wilcox (Oracle)
2025-11-03 21:56 ` Suren Baghdasaryan
2025-11-07 19:12 ` Liam R. Howlett
2025-11-04 9:08 ` [syzbot ci] Re: vma_start_write_killable syzbot ci
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251103180348.3368668-1-willy@infradead.org \
--to=willy@infradead.org \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=chriscli@google.com \
--cc=jannh@google.com \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=pfalcato@suse.de \
--cc=shakeel.butt@linux.dev \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox