From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F2715CCFA02 for ; Sat, 1 Nov 2025 18:21:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 449CB8E0014; Sat, 1 Nov 2025 14:20:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 404D28E0019; Sat, 1 Nov 2025 14:20:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1B5C88E0014; Sat, 1 Nov 2025 14:20:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D5ADF8E0017 for ; Sat, 1 Nov 2025 14:20:44 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A0D2A88857 for ; Sat, 1 Nov 2025 18:20:44 +0000 (UTC) X-FDA: 84062854008.23.EB3A601 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf21.hostedemail.com (Postfix) with ESMTP id 134BD1C0004 for ; Sat, 1 Nov 2025 18:20:42 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=hk8oZQyt; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf21.hostedemail.com: domain of sj@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1762021243; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Z1ffhiHv8OB6FPSsGlOS1bPAonWBDrN84MuF7JMfKuA=; b=CREaCB0tgXBSXX24pTDY49hQRBWyQr9h4RnWYKatgjLLAwiyCXYPVaCBTROcgR+4r3SVWU 9UNcEf4lmhRS0L55flrr2CRGgQxThhBj43gnT7Mi0d21bGqhbkvvJyEx4+wqnx+Wbl4pv0 kRS5uc1zasGzfOr99k6WswSGPnMI+n4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1762021243; a=rsa-sha256; cv=none; b=4FIgljzhywz7BESKBKOGfJhkLF57db13AFVX7tzaVP/4I9iSmI3JosDQzUsM/XwFHz0ujM 8aHk8HIldkBYO5fGevMyb0XiULt+pfY8b0rv0OZ4178co4hCJqWqcyWkN1FcDGDSKwloPZ SdJW9T8Xy+3jWuU7L4Xin27eDS3yeN8= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=hk8oZQyt; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf21.hostedemail.com: domain of sj@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=sj@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 9590960208; Sat, 1 Nov 2025 18:20:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 10B93C4CEF1; Sat, 1 Nov 2025 18:20:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1762021242; bh=PLzxcHsoSe+0yVejn7B0A/LGthJsGhvzYk8OEsuxAOY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hk8oZQytRHvD4yY1GTSmSR5xdnrFQaYLz0Neg46BHv9DIcvoXZdYDUeepzqOKkRGA PQdMwmnMSndNRmiV6tEnV7K4EfSB9+2onrnhkjywAkSRC89hu097m8uH1DBSOaUEnt QcxZhCZ0+e4MYhaAlAXRjP5D+1Lu/cM+QyXRWq6yL0OWM/3MzNwW2Q9OTGtFERMY+b okP80u3h6S+YiBXPPzoxNpKy2T+CyEy3C/323OTjtzJ4rpIoRDknBu95SpbnHJ9eQv ELqNdB/w1R6hmLmm7ZrdEC8pqQEkyG82IoWq2U+dAHxzHkZHRgObgmwwTMNOj4ZsLw /6ovLKarDPWhA== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , "# 5 . 15 . x" , Brendan Higgins , David Gow , damon@lists.linux.dev, kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 19/22] mm/damon/tests/vaddr-kunit: handle alloc failures on damon_test_split_evenly_succ() Date: Sat, 1 Nov 2025 11:20:13 -0700 Message-ID: <20251101182021.74868-20-sj@kernel.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251101182021.74868-1-sj@kernel.org> References: <20251101182021.74868-1-sj@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: 134BD1C0004 X-Rspamd-Server: rspam02 X-Stat-Signature: 4t1xxbdrbzb3t8enbubjauawdkupob96 X-HE-Tag: 1762021242-724967 X-HE-Meta: U2FsdGVkX19UQRBHnypGECDyzQbPMybA+pJr6ajjVPtASiPjqzzSxmWaaVhgQHDllyJ5rHcus85ZEctIGm4d6nnYvWGWMn1GoBa9183dNtN+HaI0SbigFJsasTfQhdPvh76SgxFLF0iqYOSU6OEiFkQLgqgYQgY6B3bXKELkLbX5FpLK7VgcNIIKZCZpEMWnSYwA9fJSapcda0cym1fvK4Uvv/MUMUROKLzC7tM1SMIUp4YQO+xznYRDzBbyouIhfY7+rNPA1VTR7T6M33lYjvFycRkn+4AH3T3dxMw5V6gfCwpRCb0cz0CFaUgzU3W7PRBeu4dZA5gIDRr9qeHxgp0LH5xn+fh5sQEXYyxLNocMGPnUu9cFqEO6NjU06EFZVZkBjpLwQ9HLlYQvhHkL6tDp4MZVxG2SunPCUCooofLCNCTSvvI/8M9PhJINq5U+i/qAYHwVnmTOT6G9zUGuqo1hFPHWa8WR+MCUHaML2TjhXgeDsow/uGvr5s/oBTn5JDPkiNwvn5sXskKSRQOOSNdh4u87dkIkdt+vETC5GeTHPMXdonr+bSuthiUzHdO+EENu4UHi/WyGmT0XWcZCAgeaBclMrusth8l9pR5Cnp5NkiysZ5B1b4lniQ7QWYfntHQJtGsjlZYIRmI+aDoQ72BQ63cM0vxMfjZbtnXbYcywlJQiGZhVBzaakNuX95GzxQCEKF1rU4bcOejKiLU2C+BvhcXRaq89U8skQA/3OaQtMrOmBef59b69z8oVj5xMpSi0zdCQRr39wReDTvn/GIU4NcwA8LyiPM6/GAg0Vor6zQ49/xzTDC3kTYIqa2Ur0tK/Qmy1IoP4fmRtImZ51fRarbQwRlDrcFOrERY8dbwQQexMpGEPj3JAaVLA3+P1wT+XYtvt8ozr9Or3AT8eYkeym2KupFtFuJ9lI77aenpahkTb3NVfLpoy/0Lt7lix5uTTYN+AwhnL8AbHZxq z7o3ayNQ V+Bfdgdh01tIu/MY5mT3Z46rMCj8fQ2/kiysftSXHQc0GahwfLYNCFMfNEfGTXfXlDE7xHbJ0AAh9HIisWLzy4sDQMpaF8DWaww1dun/Fk1HQc7NZaadVROESaBx8z9IryXVds0BnAPXaqb/IoH1qE1qty+RkRJ4ux0/wUvHPkMDvpvIqG7JnbM/WniJpgVv+N3oq4Y0kdYnKi5xxPDkMBSQH6bOW9N1Kr1znSm9F4kPiyVuq7keFAlZ03GN4B4xOVDUWUyv2UojJ+mA4rfl52uMRkA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: damon_test_split_evenly_succ() is assuming all dynamic memory allocation in it will succeed. Those are indeed likely in the real use cases since those allocations are too small to fail, but theoretically those could fail. In the case, inappropriate memory access can happen. Fix it by appropriately cleanup pre-allocated memory and skip the execution of the remaining tests in the failure cases. Fixes: 17ccae8bb5c9 ("mm/damon: add kunit tests") Cc: # 5.15.x Signed-off-by: SeongJae Park --- mm/damon/tests/vaddr-kunit.h | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/mm/damon/tests/vaddr-kunit.h b/mm/damon/tests/vaddr-kunit.h index 1b0f21c2e376..30dc5459f1d2 100644 --- a/mm/damon/tests/vaddr-kunit.h +++ b/mm/damon/tests/vaddr-kunit.h @@ -284,10 +284,17 @@ static void damon_test_split_evenly_succ(struct kunit *test, unsigned long start, unsigned long end, unsigned int nr_pieces) { struct damon_target *t = damon_new_target(); - struct damon_region *r = damon_new_region(start, end); + struct damon_region *r; unsigned long expected_width = (end - start) / nr_pieces; unsigned long i = 0; + if (!t) + kunit_skip(test, "target alloc fail"); + r = damon_new_region(start, end); + if (!r) { + damon_free_target(t); + kunit_skip(test, "region alloc fail"); + } damon_add_region(r, t); KUNIT_EXPECT_EQ(test, damon_va_evenly_split_region(t, r, nr_pieces), 0); -- 2.47.3