From: Wei Yang <richard.weiyang@gmail.com>
To: akpm@linux-foundation.org, david@redhat.com,
lorenzo.stoakes@oracle.com, ziy@nvidia.com,
baolin.wang@linux.alibaba.com, Liam.Howlett@oracle.com,
npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com,
baohua@kernel.org, lance.yang@linux.dev
Cc: linux-mm@kvack.org, Wei Yang <richard.weiyang@gmail.com>
Subject: [PATCH 2/2] mm/huge_memory: separate uniform/non uniform split logic in __split_unmapped_folio()
Date: Sat, 1 Nov 2025 00:29:27 +0000 [thread overview]
Message-ID: <20251101002927.2610-3-richard.weiyang@gmail.com> (raw)
In-Reply-To: <20251101002927.2610-1-richard.weiyang@gmail.com>
By utilizing the newly introduced __split_folio_and_update_stats()
helper function, we can now clearly separate the logic for uniform and
non-uniform folio splitting within __split_unmapped_folio().
This refactoring greatly simplifies the code by creating two distinct
execution paths:
* Uniform Split: Directly calls __split_folio_and_update_stats()
once to achieve the @new_order in a single operation.
* Non-Uniform Split: Continues to use a loop to iteratively split
the folio to a single lower order at a time, eventually reaching
the @new_order.
This separation improves code clarity and maintainability.
Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
Cc: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Cc: Zi Yan <ziy@nvidia.com>
---
mm/huge_memory.c | 31 ++++++++++++++++---------------
1 file changed, 16 insertions(+), 15 deletions(-)
diff --git a/mm/huge_memory.c b/mm/huge_memory.c
index abde0f1aa8ff..c4fb84cedbe0 100644
--- a/mm/huge_memory.c
+++ b/mm/huge_memory.c
@@ -3629,14 +3629,20 @@ static int __split_unmapped_folio(struct folio *folio, int new_order,
{
const bool is_anon = folio_test_anon(folio);
int old_order = folio_order(folio);
- int start_order = uniform_split ? new_order : old_order - 1;
int split_order;
+ /* For uniform split, folio is split to new_order directly. */
+ if (uniform_split) {
+ if (mapping)
+ xas_split(xas, folio, old_order);
+ __split_folio_and_update_stats(folio, old_order, new_order, is_anon);
+ return 0;
+ }
+
/*
- * split to new_order one order at a time. For uniform split,
- * folio is split to new_order directly.
+ * For non-uniform, split to new_order one order at a time.
*/
- for (split_order = start_order;
+ for (split_order = old_order - 1;
split_order >= new_order;
split_order--) {
/* order-1 anonymous folio is not supported */
@@ -3649,21 +3655,16 @@ static int __split_unmapped_folio(struct folio *folio, int new_order,
* irq is disabled to allocate enough memory, whereas
* non-uniform split can handle ENOMEM.
*/
- if (uniform_split)
- xas_split(xas, folio, old_order);
- else {
- xas_set_order(xas, folio->index, split_order);
- xas_try_split(xas, folio, old_order);
- if (xas_error(xas))
- return xas_error(xas);
- }
+ xas_set_order(xas, folio->index, split_order);
+ xas_try_split(xas, folio, old_order);
+ if (xas_error(xas))
+ return xas_error(xas);
}
__split_folio_and_update_stats(folio, old_order, split_order, is_anon);
/*
- * If uniform split, the process is complete.
- * If non-uniform, continue splitting the folio at @split_at
- * as long as the next @split_order is >= @new_order.
+ * Continue splitting the folio at @split_at as long as the
+ * next @split_order is >= @new_order.
*/
folio = page_folio(split_at);
old_order = split_order;
--
2.34.1
next prev parent reply other threads:[~2025-11-01 0:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-01 0:29 [PATCH 0/2] mm/huge_memory: Modularize and simplify folio splitting paths Wei Yang
2025-11-01 0:29 ` [PATCH 1/2] mm/huge_memory: introduce __split_folio_and_update_stats() to consolidate split task Wei Yang
2025-11-03 16:20 ` David Hildenbrand (Red Hat)
2025-11-03 16:21 ` David Hildenbrand (Red Hat)
2025-11-03 16:22 ` David Hildenbrand (Red Hat)
2025-11-07 2:15 ` Wei Yang
2025-11-03 23:37 ` Wei Yang
2025-11-04 10:33 ` David Hildenbrand (Red Hat)
2025-11-04 13:30 ` Wei Yang
2025-11-01 0:29 ` Wei Yang [this message]
2025-11-07 1:02 ` [PATCH 0/2] mm/huge_memory: Modularize and simplify folio splitting paths Wei Yang
2025-11-07 1:59 ` Zi Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251101002927.2610-3-richard.weiyang@gmail.com \
--to=richard.weiyang@gmail.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@redhat.com \
--cc=dev.jain@arm.com \
--cc=lance.yang@linux.dev \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=npache@redhat.com \
--cc=ryan.roberts@arm.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox