From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3E76BCCF9E9 for ; Wed, 29 Oct 2025 10:21:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A2ACF8E005F; Wed, 29 Oct 2025 06:21:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9DAF28E0045; Wed, 29 Oct 2025 06:21:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8A2E98E005F; Wed, 29 Oct 2025 06:21:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 75BA18E0045 for ; Wed, 29 Oct 2025 06:21:02 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 262CD1606F6 for ; Wed, 29 Oct 2025 10:21:02 +0000 (UTC) X-FDA: 84050758764.18.21FBB96 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf23.hostedemail.com (Postfix) with ESMTP id 98463140004 for ; Wed, 29 Oct 2025 10:20:59 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b="CxvCE/I+"; spf=pass (imf23.hostedemail.com: domain of imbrenda@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=imbrenda@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1761733259; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=a8C3xo7d6IbVEJTrFBvgh0IG4wFajk7Jzk1+en8wFBE=; b=XmvZTSPLTqy/c2Y0wtorsb/zpV2sP/qH19BMX0kS52c2auRWzCTttT7eeN5egCnP/NDsiN sZx4J73Biq1GyLbR+3E+qRiGELv+CdX1/vSOhfA7fdMz2eZN342V9KCbe1BSv9556Uc3ei OTy/rR+/zUKEl0iOe61QY7AKXWlsBpM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1761733259; a=rsa-sha256; cv=none; b=jzYURPD14w6+BoiwgVUqWpWPew2BMdabKUfb/3rjLDUgwFEBgmaXmVwLq4xkDQybIsYOBV wBTdEXV82L2HUirJwgiyOFCsM+9eLPLymcquiVOCEmPjdJMrB8c4IWLyTmfVyejxbqPsFc m9WLytTcld5TujjfQZLX22ui3jEqiV8= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b="CxvCE/I+"; spf=pass (imf23.hostedemail.com: domain of imbrenda@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=imbrenda@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 59SJmGuE008719; Wed, 29 Oct 2025 10:20:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=a8C3xo 7d6IbVEJTrFBvgh0IG4wFajk7Jzk1+en8wFBE=; b=CxvCE/I+LSKtS0sazC2Nc6 bp3whjjsUFd21k1GJtSj8Kdf+0EYFLgg9hz5DsiSTDo3LI6+WJtiqJCc8ga16KYl GrLdc/7dCYmzZXNGnTZ0dcP4KKPpr4c/7+qmGDhPtvndPENgvpcBsZK0SpBxiBXJ N2aQJfPj8xygiw9XjB6IZHNd+nANVczXQlzLweaAA7NYKpgT6TGc1NLtxpBztram 828uKIXNKsXePgmptKTEKYlbA4DNUzfB6gKhoTFtaMOw9FrsvEBlUa4O3itHPa2F 9F2XAxIjRcNT3QRLLEyioxafoUYAQbCB8jqk3oJnHK2G38bH8FWWpJ3snC8QWNhw == Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4a34afapvj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 29 Oct 2025 10:20:51 +0000 (GMT) Received: from m0356517.ppops.net (m0356517.ppops.net [127.0.0.1]) by pps.reinject (8.18.1.12/8.18.0.8) with ESMTP id 59TAK2Li031504; Wed, 29 Oct 2025 10:20:51 GMT Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4a34afapuw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 29 Oct 2025 10:20:50 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 59T9vZLR027516; Wed, 29 Oct 2025 10:20:44 GMT Received: from smtprelay07.fra02v.mail.ibm.com ([9.218.2.229]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 4a33w2jqxs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 29 Oct 2025 10:20:44 +0000 Received: from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com [10.20.54.105]) by smtprelay07.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 59TAKcdE39977418 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 29 Oct 2025 10:20:38 GMT Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 65AC52004F; Wed, 29 Oct 2025 10:20:38 +0000 (GMT) Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4F4BD2005A; Wed, 29 Oct 2025 10:20:36 +0000 (GMT) Received: from p-imbrenda (unknown [9.87.139.129]) by smtpav06.fra02v.mail.ibm.com (Postfix) with SMTP; Wed, 29 Oct 2025 10:20:36 +0000 (GMT) Date: Wed, 29 Oct 2025 11:20:33 +0100 From: Claudio Imbrenda To: David Hildenbrand Cc: akpm@linux-foundation.org, balbirs@nvidia.com, borntraeger@de.ibm.com, Liam.Howlett@oracle.com, airlied@gmail.com, apopple@nvidia.com, baohua@kernel.org, baolin.wang@linux.alibaba.com, byungchul@sk.com, dakr@kernel.org, dev.jain@arm.com, dri-devel@lists.freedesktop.org, francois.dugast@intel.com, gourry@gourry.net, joshua.hahnjy@gmail.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, lorenzo.stoakes@oracle.com, lyude@redhat.com, matthew.brost@intel.com, mpenttil@redhat.com, npache@redhat.com, osalvador@suse.de, rakie.kim@sk.com, rcampbell@nvidia.com, ryan.roberts@arm.com, simona@ffwll.ch, ying.huang@linux.alibaba.com, ziy@nvidia.com, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-next@vger.kernel.org, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com Subject: Re: [PATCH v1 1/1] KVM: s390: Fix missing present bit for gmap puds Message-ID: <20251029112033.23b3ee87@p-imbrenda> In-Reply-To: References: <20251028130150.57379-1-imbrenda@linux.ibm.com> <20251028130150.57379-2-imbrenda@linux.ibm.com> Organization: IBM X-Mailer: Claws Mail 4.3.1 (GTK 3.24.49; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: iCCZHicpewE1nEEK0Th6TZo8jyCZ_lKE X-Authority-Analysis: v=2.4 cv=WPhyn3sR c=1 sm=1 tr=0 ts=6901ea83 cx=c_pps a=AfN7/Ok6k8XGzOShvHwTGQ==:117 a=AfN7/Ok6k8XGzOShvHwTGQ==:17 a=kj9zAlcOel0A:10 a=x6icFKpwvdMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=VnNF1IyMAAAA:8 a=20KFwNOVAAAA:8 a=TqUBss7doubTCnVJSwQA:9 a=CjuIK1q_8ugA:10 a=nl4s5V0KI7Kw-pW0DWrs:22 a=pHzHmUro8NiASowvMSCR:22 a=xoEH_sTeL_Rfw54TyV31:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDI4MDE2NiBTYWx0ZWRfX2SsWkX+TbQmr 2+aNTSE9EGTlVJFFPDNI6EvdJ/0NfLidif5XzlmHYduy5nfQecT+UYgBSNmL6XNqDkbQj/eqN+Z Aj3pDYE10hsg5ntFoqFViDE3Q5xO1GDKNGiZzWFDGbKvvuJKoQtcaFta8VzlvDgHz1bdD+6dW+A pCJjPzQks6en4f7qgaW5s26I9ftRLR5WqIr+sWqJzNBKkHOjDa23cObi9I8Ht558wHkgPC0fZv1 LLBy4oHH0ig79qC3Raez+ML1eHMuj4KSAahnKAS7A+jqSFjkGr2UHtjWkInx/zsx05E7/VYjqIR 3FQZTJCSdFfVUlzkLcj50LiZuToa1+MV63UUsB7dx5IlB8eZozqV4iaQsE9UsfuLjrJyb4Qwk43 Ms1L5rM7zV9X+fse4/06Kz7/8zx0MA== X-Proofpoint-ORIG-GUID: wKqPvWninnMRfuPgoIUz0EKbJo7AbSs7 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-29_04,2025-10-22_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 adultscore=0 malwarescore=0 suspectscore=0 spamscore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 bulkscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2510240000 definitions=main-2510280166 X-Rspamd-Server: rspam05 X-Stat-Signature: 84c35ygbug6cte3pcmse7nddue7q765c X-Rspam-User: X-Rspamd-Queue-Id: 98463140004 X-HE-Tag: 1761733259-449419 X-HE-Meta: U2FsdGVkX18KZawwMFZkBlbxpi8SwN899IwjUJTVelykqcTb1zStuIYRiUgOA0dQtLUYGxZq7Zgw41ZnY39QmX5Wh6QsnGgFv0X4tuP7PFQIEPfKBsD+TFXQh1SXYCrOiIPFkZKkOZc99t48q3XETjSDH5sbwuFMtwpUrvmYUyuLSjHdx+yqfVchoMf8eowv9i2eCQM+L0LFTiXTMZFCNcfZ63Ye9GBmc+MOmtCPVMHFVnqsIQT9OT9Y332W4R5FWwKTRm/pNJffnpWYPVLDQlB81Bh37o3G16A8dkvbtE97bODNWjKDBIPfcDfhtO3yBsvCuEsS0xkLTTXmyhUoekali9pGrULgpTeRDhigbILBMVL25JEThUp5tBKMBW/LJxgXX7qK6YDZb0TnSGheQQNQL6BiFTV2gM74qdJ29DMcLLCR7iHihfVcH64QvQSSuVx55Y3U/MKjCpqMSKa9O6c13N+SdDcwK/rlWMPQi1pG120bNQTHTmzGIAvM6rxz5VaS0bf3vG+KzBHE/DBP5x1C19sd1wG9D5LuuFpiWZ4XVa+lC+74w92mQ+BYIFX0rMOdnAEGL5ZgnUaG9AeouOy9Cn/t0WzqS0wM6mFKKefLnkYA7cdnCLcbB86P5yORkGL/wReMe1rfBpsmBdIgVL7utAWY46ZIntebJiJAAucK7nRW7rA6v5N04nlx6Ym5F42ZQr6nNxbaUiRrN+vnb+ba+kvrREgT07RdRUqoeAHhMh6R9QRkxy7lB3zJYan7H8sXjKnzlEoOxZvFafrylgfry9MtIot+LXYVrAlVUR/HppJVUVeLFvWA5gNfZTyNJUjc5GGRks+vdhqpuEmcwkPaIrNYKxPDdK8thAO1714AorVmrm4hSWPMlIBjGB4YOw5OiRg5Ki1icwsN98wYr/RUShatPFRrzlrmTfvcpDKmia+dIOlZLfhR6/OTUdxXxjMQcXin6K2UzNeNBrd wZzBHbL0 tEA0ttA2gGfHQdc3EYMCIzdUo3UoS6kbzewc/8z10xFdmc6llnCtchFUeWz2Uavat64MXE+DLhI5/w7cDEq5t4ipCqWXBzG8Tf9VcOpA4Gif3MhqG384xe1kOy7QJNBMOs9M5Abndve6Pr4xk+agee9v7Wl+mHFEmRyJah4Wd9HX3sWkLNZD0j3t2TjoeL2RNrtEMfFv+lJ0kV2r++FjCk20mCsLSLtdOksCQZAnACPH74owI5sfi1Eu8BVJPUU1Wj8EKaK4sWNtJBE0GkW/LG6yNRipS6SA3H5FzDcSeC/RFbgIVqzZS190fLrSswxI3VpfUkCb8bGgFhX7bxFRU8rwOZ9+GjpiwNp3gTvWRd0WgXrSyAYjAvb1zhirUDT/xTJDKx26UdKDfinpYE8fwIb1FWSedVX4L3VNY7rFcvTfM5HPSC3WucQzlYKo9CEJ2+Pu/SopC0AUoZes= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 29 Oct 2025 11:00:14 +0100 David Hildenbrand wrote: > On 28.10.25 14:01, Claudio Imbrenda wrote: > > For hugetlbs, gmap puds have the present bit set. For normal puds > > (which point to ptes), the bit is not set. This is in contrast to the > > normal userspace puds, which always have the bit set for present pmds. > > > > This causes issues when ___pte_offset_map() is modified to only check > > for the present bit. > > > > The solution to the problem is simply to always set the present bit for > > present gmap pmds. > > > > Signed-off-by: Claudio Imbrenda > > Link: https://lore.kernel.org/lkml/20251017144924.10034-1-borntraeger@linux.ibm.com/ > > Tested-by: Christian Borntraeger > > Acked-by: Christian Borntraeger > > --- > > arch/s390/mm/gmap.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/arch/s390/mm/gmap.c b/arch/s390/mm/gmap.c > > index 8ff6bba107e8..22c448b32340 100644 > > --- a/arch/s390/mm/gmap.c > > +++ b/arch/s390/mm/gmap.c > > @@ -599,8 +599,9 @@ int __gmap_link(struct gmap *gmap, unsigned long gaddr, unsigned long vmaddr) > > | _SEGMENT_ENTRY_GMAP_UC > > | _SEGMENT_ENTRY; > > } else > > - *table = pmd_val(*pmd) & > > - _SEGMENT_ENTRY_HARDWARE_BITS; > > I'd add a comment here like > > /* Make sure that pmd_present() will work on these entries. */ the whole file is going away very soon anyway > > > + *table = (pmd_val(*pmd) & > > + _SEGMENT_ENTRY_HARDWARE_BITS) > > + | _SEGMENT_ENTRY; > > } > > } else if (*table & _SEGMENT_ENTRY_PROTECT && > > !(pmd_val(*pmd) & _SEGMENT_ENTRY_PROTECT)) { > > Reviewed-by: David Hildenbrand >