From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 278C0CCD1BF for ; Tue, 28 Oct 2025 16:14:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8C12480176; Tue, 28 Oct 2025 12:14:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 84A568013F; Tue, 28 Oct 2025 12:14:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7398C80176; Tue, 28 Oct 2025 12:14:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 5CFDE8013F for ; Tue, 28 Oct 2025 12:14:37 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 140E2883FB for ; Tue, 28 Oct 2025 16:14:37 +0000 (UTC) X-FDA: 84048020994.18.07A24C8 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf01.hostedemail.com (Postfix) with ESMTP id D283040010 for ; Tue, 28 Oct 2025 16:14:34 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=aLTbcXzc; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf01.hostedemail.com: domain of hca@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=hca@linux.ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1761668075; a=rsa-sha256; cv=none; b=dPnIfy/aENlLY8UCwZG3WNfs20eVFhFvnWfkiItT8VyLnMYxAZaC5OF8B1J+vrnwo4VMPH k8KDOXYioRWtI6RUBluqtgeMwsqzZEQ60WuHuowzX8IeDKDrNbOcM+VlK9Ls2i3wROrcrZ QIR/IiVJX9zzWbjgFJOKCE/x0+F8kXY= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=aLTbcXzc; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf01.hostedemail.com: domain of hca@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=hca@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1761668075; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3XIzNoQ5RCEgQQp0zWyk+dkyklSOKQ/ufsdyjhxnvVY=; b=A1UtE3W9c7Z9XZ4JOowds5LalxbYoUwReDamkFAg4FJd1I5EVlYYTDuhBXAWXCnsWIYcOo WcviHaoEqPgbRNdNrg2G6JOT0htB1mHcJAUMMAqfROpFi2uuYKDxUZpZCND+865U6iQyzu zKkhNL4NAZCX4b0TxHBMCs3M5koceVk= Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 59SD9pGB021233; Tue, 28 Oct 2025 16:14:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pp1; bh=3XIzNoQ5RCEgQQp0zWyk+dkyklSOKQ /ufsdyjhxnvVY=; b=aLTbcXzcBLgz15HZYNZbGhutYYE7YyTQ8tfo1i3DmCZVS5 g8zqZ2ZLbRXJfYIDxJ1qPPUZbbOVOYwfgckplK0ZD50svB28tHsAPD/fntRlNk6i o7Tufm/OKo41uCYSXdVJaump+KAaAncvpjDYfMdd2GrZXadpaWJ4vtbYcUjdZP9U 67UGnREt5eg5nD0vwiW9HGX6mYRWdN+EIHRzEnFc0jU7LUtE3xTvmP29IBwZ/zlm vwiKUyC6A3jCGhoacKJf6tC6PQBaFgPycHBllgLJwbs5AhKqpF75KZA7ck+LZy3a fIKgRkUB4yRI7xov1WHvVZVT16CugKwv2QNvH1lw== Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4a0p81wetu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 28 Oct 2025 16:14:30 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 59SFefYn009411; Tue, 28 Oct 2025 16:14:29 GMT Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 4a1b3j3nb6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 28 Oct 2025 16:14:29 +0000 Received: from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com [10.20.54.103]) by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 59SGESqD57475398 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 28 Oct 2025 16:14:28 GMT Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 277D520043; Tue, 28 Oct 2025 16:14:28 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D92FB20040; Tue, 28 Oct 2025 16:14:27 +0000 (GMT) Received: from osiris (unknown [9.155.211.25]) by smtpav04.fra02v.mail.ibm.com (Postfix) with ESMTPS; Tue, 28 Oct 2025 16:14:27 +0000 (GMT) Date: Tue, 28 Oct 2025 17:14:26 +0100 From: Heiko Carstens To: Joao Martins Cc: Luiz Capitulino , osalvador@suse.de, akpm@linux-foundation.org, david@redhat.com, aneesh.kumar@kernel.org, borntraeger@linux.ibm.com, mike.kravetz@oracle.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org Subject: Re: [PATCH] mm: hugetlb: fix HVO crash on s390 Message-ID: <20251028161426.35377Af6-hca@linux.ibm.com> References: <20251028153930.37107-1-luizcap@redhat.com> <50d815a1-8384-4eaa-8515-19d6c92425b3@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <50d815a1-8384-4eaa-8515-19d6c92425b3@oracle.com> X-TM-AS-GCONF: 00 X-Authority-Analysis: v=2.4 cv=fIQ0HJae c=1 sm=1 tr=0 ts=6900ebe6 cx=c_pps a=AfN7/Ok6k8XGzOShvHwTGQ==:117 a=AfN7/Ok6k8XGzOShvHwTGQ==:17 a=kj9zAlcOel0A:10 a=x6icFKpwvdMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=cXYDuvELUoMafkmudakA:9 a=CjuIK1q_8ugA:10 a=cPQSjfK2_nFv0Q5t_7PE:22 X-Proofpoint-ORIG-GUID: t1jWPofHSTzi3Zc35SfGVCvcTD7gq-84 X-Proofpoint-GUID: t1jWPofHSTzi3Zc35SfGVCvcTD7gq-84 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDI1MDAyNCBTYWx0ZWRfX8UTXR0KaqSdI 79JMtu0fTtaWbYbUXLBgLHFX/fb81KT9lAFgjU/gMYe3RqpmLVpX5b0kumFEd0FMumefdjP5h7S xOOerJJs4DhZ9V6UTTGHFhWtRSuqIx7RjjhwMYJpKGByz1YFd0FIWUazj1/PectAPNgJ3FG/DA6 e4EQQ7QoluBVzkNS1LRZb801Mn9r7VEvUWsf1CYGOGlVMyhv9GRT2ZKPaMLRoWzFkCzox/x3gV/ R4GPoYUwECeEZuoicl8GNBtiIdx7hbqBONvsM+gua12HcIDHsF5UIMQdxVBsazdFIhb+rg0MFpB +OSNQOtbr2rRHXH2Eu4EL8Nlw+YtceY1blrxYdQ/RJKr4vs/1yI77AJE6/6h1ybYp1YS2iwFGKf XMPV9y4uVpxOPnMaCQEfANnSzJuxtw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-28_06,2025-10-22_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 adultscore=0 suspectscore=0 spamscore=0 clxscore=1011 bulkscore=0 lowpriorityscore=0 phishscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2510020000 definitions=main-2510250024 X-Stat-Signature: 9rm1a58sh76g5rge7t4s53u1ypje65q8 X-Rspamd-Queue-Id: D283040010 X-Rspamd-Server: rspam06 X-Rspam-User: X-HE-Tag: 1761668074-897850 X-HE-Meta: U2FsdGVkX1+/3CPJ4fmS+AYEXDaKIj+OdBhrDzpIT1eBL3JFzcfKyRSGpD27SakXOQjGOj9G8+mCAyRDb3w1xOEqbjwXVbGx1z/K6OpL2DslHMpudZvPQTeQoix2C3fREWE34OeeIVWY/JwD93xlvpSCDEit3QMFD1JQg2951fAkSDp6/mp5tonOP55dTAoKp+k+yB338IM46hryoO43D/8W+NIY/BtjMNlGdgAwHlYsTSXlE/RKzl87ngkeM/xge3mG8FVw6pcaZDFEJ3kSFWS5a0QxSR2hKfyJvJc5E1W4jtxUN3b9a0+e4sfJsfgmNhtqPwny+dAEbr/ncPXWy4ZPPeYT5ttjzOkDPgsA5r64NeItrKgwnuH4tRJXZBbwoExuX/D/eEnGr53r6bvdQIKlf5mrAyRo4yzKuv+1MfOeozmWkw4/qRw3hhRxVE/QwlZ4msVNpyqKIS0YGrHAsVCKNlANTpu0WyFKRY7sfqDSgODswsXjzDaOm0YAfo8vwD8bszNq/PG0o32pg+uTVvpveSpuDnQhKsZNSt9mHmf3PdegnNSMav/i6Odr/A0puaRTZ6pM6GeBLva7F4ws3FhV1VDfbxg25BsoaOncMr2HvQyrn4LY8k8/MhuQHkW8wJzBBLcW2q8XlBszU5tDWSbHJswpGcwjOQaQAhT77F9Ox8nJaDVqRSYeW2qHzyGx3VgORXcwPN8kztPFzHzl98/15auTgKVD5TncEuNU7vf/zeyeMZ4yyQpRnbM44H3JzzbXglPHU23m4+kwSFueTrRHiKP3GsSS2GO82scatKJD2w2vGPjvDD25HS6l+w9S+w0ctOkFUTYj0UpovUrTqZCjPtKm6v9BUbXLk32s/dr7FQ5XSWby6U9ljtd+pYswnE629yZ3pTVPROTJf9poTdPNtA6w4rkrxxAGxbIn09r2Ow189qL3Ut9o84yeT+0b/vl6UYe3G3s= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Oct 28, 2025 at 04:05:45PM +0000, Joao Martins wrote: > > diff --git a/mm/hugetlb_vmemmap.c b/mm/hugetlb_vmemmap.c > > index ba0fb1b6a5a8..5819a3088850 100644 > > --- a/mm/hugetlb_vmemmap.c > > +++ b/mm/hugetlb_vmemmap.c > > @@ -48,6 +48,15 @@ struct vmemmap_remap_walk { > > unsigned long flags; > > }; > > > > +static inline void vmemmap_flush_tlb_all(void) > > +{ > > +#ifdef CONFIG_S390 > > + __tlb_flush_kernel(); > > +#else > > + flush_tlb_all(); > > +#endif > > +} > > + > > Wouldn't a better fix be to implement flush_tlb_all() in > s390/include/asm/tlbflush.h since that aliases to __tlb_flush_kernel()? The question is rather what is flush_tlb_all() supposed to flush? Is it supposed to flush only tlb entries corresponding to the kernel address space, or should it flush just everything? Within this context it looks like only tlb flushing for the kernel address space is required(?)