linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Al Viro <viro@zeniv.linux.org.uk>
To: linux-fsdevel@vger.kernel.org
Cc: torvalds@linux-foundation.org, brauner@kernel.org, jack@suse.cz,
	raven@themaw.net, miklos@szeredi.hu, neil@brown.name,
	a.hindborg@kernel.org, linux-mm@kvack.org,
	linux-efi@vger.kernel.org, ocfs2-devel@lists.linux.dev,
	kees@kernel.org, rostedt@goodmis.org, gregkh@linuxfoundation.org,
	linux-usb@vger.kernel.org, paul@paul-moore.com,
	casey@schaufler-ca.com, linuxppc-dev@lists.ozlabs.org,
	john.johansen@canonical.com, selinux@vger.kernel.org,
	borntraeger@linux.ibm.com, bpf@vger.kernel.org
Subject: [PATCH v2 47/50] get rid of kill_litter_super()
Date: Tue, 28 Oct 2025 00:46:06 +0000	[thread overview]
Message-ID: <20251028004614.393374-48-viro@zeniv.linux.org.uk> (raw)
In-Reply-To: <20251028004614.393374-1-viro@zeniv.linux.org.uk>

Not used anymore.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---
 Documentation/filesystems/porting.rst |  7 +++++++
 fs/dcache.c                           | 21 ---------------------
 fs/internal.h                         |  1 -
 fs/super.c                            |  8 --------
 include/linux/dcache.h                |  1 -
 include/linux/fs.h                    |  1 -
 6 files changed, 7 insertions(+), 32 deletions(-)

diff --git a/Documentation/filesystems/porting.rst b/Documentation/filesystems/porting.rst
index 7233b04668fc..4921b3b0662a 100644
--- a/Documentation/filesystems/porting.rst
+++ b/Documentation/filesystems/porting.rst
@@ -1309,3 +1309,10 @@ a different length, use
 	vfs_parse_fs_qstr(fc, key, &QSTR_LEN(value, len))
 
 instead.
+
+---
+
+**mandatory**
+
+kill_litter_super() is gone; convert to DCACHE_PERSISTENT use (as all
+in-tree filesystems have done).
diff --git a/fs/dcache.c b/fs/dcache.c
index 3e26039ceca1..a7fab68fb4c9 100644
--- a/fs/dcache.c
+++ b/fs/dcache.c
@@ -3159,27 +3159,6 @@ bool is_subdir(struct dentry *new_dentry, struct dentry *old_dentry)
 }
 EXPORT_SYMBOL(is_subdir);
 
-static enum d_walk_ret d_genocide_kill(void *data, struct dentry *dentry)
-{
-	struct dentry *root = data;
-	if (dentry != root) {
-		if (d_unhashed(dentry) || !dentry->d_inode ||
-		    dentry->d_flags & DCACHE_PERSISTENT)
-			return D_WALK_SKIP;
-
-		if (!(dentry->d_flags & DCACHE_GENOCIDE)) {
-			dentry->d_flags |= DCACHE_GENOCIDE;
-			dentry->d_lockref.count--;
-		}
-	}
-	return D_WALK_CONTINUE;
-}
-
-void d_genocide(struct dentry *parent)
-{
-	d_walk(parent, parent, d_genocide_kill);
-}
-
 void d_mark_tmpfile(struct file *file, struct inode *inode)
 {
 	struct dentry *dentry = file->f_path.dentry;
diff --git a/fs/internal.h b/fs/internal.h
index 9b2b4d116880..144686af6c36 100644
--- a/fs/internal.h
+++ b/fs/internal.h
@@ -227,7 +227,6 @@ extern void shrink_dcache_for_umount(struct super_block *);
 extern struct dentry *__d_lookup(const struct dentry *, const struct qstr *);
 extern struct dentry *__d_lookup_rcu(const struct dentry *parent,
 				const struct qstr *name, unsigned *seq);
-extern void d_genocide(struct dentry *);
 
 /*
  * pipe.c
diff --git a/fs/super.c b/fs/super.c
index 5bab94fb7e03..ee001f684d2a 100644
--- a/fs/super.c
+++ b/fs/super.c
@@ -1284,14 +1284,6 @@ void kill_anon_super(struct super_block *sb)
 }
 EXPORT_SYMBOL(kill_anon_super);
 
-void kill_litter_super(struct super_block *sb)
-{
-	if (sb->s_root)
-		d_genocide(sb->s_root);
-	kill_anon_super(sb);
-}
-EXPORT_SYMBOL(kill_litter_super);
-
 int set_anon_super_fc(struct super_block *sb, struct fs_context *fc)
 {
 	return set_anon_super(sb, NULL);
diff --git a/include/linux/dcache.h b/include/linux/dcache.h
index 6ec4066825e3..20a85144a00e 100644
--- a/include/linux/dcache.h
+++ b/include/linux/dcache.h
@@ -198,7 +198,6 @@ enum dentry_flags {
 	DCACHE_REFERENCED		= BIT(6),	/* Recently used, don't discard. */
 	DCACHE_DONTCACHE		= BIT(7),	/* Purge from memory on final dput() */
 	DCACHE_CANT_MOUNT		= BIT(8),
-	DCACHE_GENOCIDE			= BIT(9),
 	DCACHE_SHRINK_LIST		= BIT(10),
 	DCACHE_OP_WEAK_REVALIDATE	= BIT(11),
 	/*
diff --git a/include/linux/fs.h b/include/linux/fs.h
index f5037c556f61..95933ceaae51 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -2728,7 +2728,6 @@ void retire_super(struct super_block *sb);
 void generic_shutdown_super(struct super_block *sb);
 void kill_block_super(struct super_block *sb);
 void kill_anon_super(struct super_block *sb);
-void kill_litter_super(struct super_block *sb);
 void deactivate_super(struct super_block *sb);
 void deactivate_locked_super(struct super_block *sb);
 int set_anon_super(struct super_block *s, void *data);
-- 
2.47.3



  parent reply	other threads:[~2025-10-28  3:51 UTC|newest]

Thread overview: 101+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-28  0:45 [PATCH v2 00/50] tree-in-dcache stuff Al Viro
2025-10-28  0:45 ` [PATCH v2 01/50] fuse_ctl_add_conn(): fix nlink breakage in case of early failure Al Viro
2025-10-28  0:45 ` [PATCH v2 02/50] tracefs: fix a leak in eventfs_create_events_dir() Al Viro
2025-10-28  1:15   ` Steven Rostedt
2025-10-28  0:45 ` [PATCH v2 03/50] new helper: simple_remove_by_name() Al Viro
2025-10-28  0:45 ` [PATCH v2 04/50] new helper: simple_done_creating() Al Viro
2025-10-28  0:45 ` [PATCH v2 05/50] introduce a flag for explicitly marking persistently pinned dentries Al Viro
2025-10-28  0:45 ` [PATCH v2 06/50] primitives for maintaining persisitency Al Viro
2025-10-28 12:38   ` James Bottomley
2025-10-29  5:10     ` Al Viro
2025-10-29 15:25       ` James Bottomley
2025-10-28  0:45 ` [PATCH v2 07/50] convert simple_{link,unlink,rmdir,rename,fill_super}() to new primitives Al Viro
2025-10-29 14:02   ` [External] : " Mark Tinguely
2025-10-29 17:55     ` Al Viro
2025-10-28  0:45 ` [PATCH v2 08/50] convert ramfs and tmpfs Al Viro
2025-10-28  0:45 ` [PATCH v2 09/50] procfs: make /self and /thread_self dentries persistent Al Viro
2025-10-28  0:45 ` [PATCH v2 10/50] configfs, securityfs: kill_litter_super() not needed Al Viro
2025-10-28 23:58   ` Paul Moore
2025-10-29  6:18   ` Andreas Hindborg
2025-10-28  0:45 ` [PATCH v2 11/50] convert xenfs Al Viro
2025-10-28  0:45 ` [PATCH v2 12/50] convert smackfs Al Viro
2025-10-28  0:45 ` [PATCH v2 13/50] convert hugetlbfs Al Viro
2025-10-28  0:45 ` [PATCH v2 14/50] convert mqueue Al Viro
2025-10-28  0:45 ` [PATCH v2 15/50] convert bpf Al Viro
2025-10-28  0:45 ` [PATCH v2 16/50] convert dlmfs Al Viro
2025-10-28  0:45 ` [PATCH v2 17/50] convert fuse_ctl Al Viro
2025-10-28  0:45 ` [PATCH v2 18/50] convert pstore Al Viro
2025-11-04  1:43   ` Kees Cook
2025-10-28  0:45 ` [PATCH v2 19/50] convert tracefs Al Viro
2025-10-28 15:37   ` Steven Rostedt
2025-10-28  0:45 ` [PATCH v2 20/50] convert debugfs Al Viro
2025-10-28  0:45 ` [PATCH v2 21/50] debugfs: remove duplicate checks in callers of start_creating() Al Viro
2025-10-28  0:45 ` [PATCH v2 22/50] convert efivarfs Al Viro
2025-10-28 12:53   ` James Bottomley
2025-10-28 17:45     ` Al Viro
2025-10-28 21:08       ` Al Viro
2025-10-28 21:34         ` Ard Biesheuvel
2025-10-29 18:08           ` Al Viro
2025-10-29 18:26             ` Ard Biesheuvel
2025-10-29 18:57           ` James Bottomley
2025-10-29 19:37             ` Al Viro
2025-10-29 19:48               ` James Bottomley
2025-10-30 13:35               ` Ard Biesheuvel
2025-11-05 11:47                 ` Christian Brauner
2025-11-05 13:09                   ` James Bottomley
2025-11-05 13:16                     ` Christian Brauner
2025-11-05 13:33                       ` James Bottomley
2025-11-05 13:46                         ` Christian Brauner
2025-11-05 14:01                           ` James Bottomley
2025-11-05 15:23                             ` Christian Brauner
2025-11-05 13:43                       ` Christian Brauner
2025-11-09 20:40                         ` Al Viro
2025-11-11 10:56                           ` Christian Brauner
2025-11-19 21:15                         ` [REGRESSION] " Chris Bainbridge
2025-11-25  9:00                           ` Christian Brauner
2025-11-05 14:34                   ` Ard Biesheuvel
2025-10-28  0:45 ` [PATCH v2 23/50] convert spufs Al Viro
2025-10-28  1:15   ` bot+bpf-ci
2025-10-28  1:33     ` Al Viro
2025-10-28  0:45 ` [PATCH v2 24/50] convert ibmasmfs Al Viro
2025-10-28  0:45 ` [PATCH v2 25/50] ibmasmfs: get rid of ibmasmfs_dir_ops Al Viro
2025-10-28  0:45 ` [PATCH v2 26/50] convert devpts Al Viro
2025-10-28  0:45 ` [PATCH v2 27/50] binderfs: use simple_start_creating() Al Viro
2025-10-28  0:45 ` [PATCH v2 28/50] binderfs_binder_ctl_create(): kill a bogus check Al Viro
2025-10-28  0:45 ` [PATCH v2 29/50] convert binderfs Al Viro
2025-10-28  0:45 ` [PATCH v2 30/50] autofs_{rmdir,unlink}: dentry->d_fsdata->dentry == dentry there Al Viro
2025-10-28  0:45 ` [PATCH v2 31/50] convert autofs Al Viro
2025-10-28  1:55   ` Al Viro
2025-10-28  5:32     ` Linus Torvalds
2025-10-28  0:45 ` [PATCH v2 32/50] convert binfmt_misc Al Viro
2025-10-28  0:45 ` [PATCH v2 33/50] selinuxfs: don't stash the dentry of /policy_capabilities Al Viro
2025-10-29  0:08   ` Paul Moore
2025-10-29 15:19   ` Stephen Smalley
2025-10-28  0:45 ` [PATCH v2 34/50] selinuxfs: new helper for attaching files to tree Al Viro
2025-10-28 23:51   ` Paul Moore
2025-10-29 15:22   ` Stephen Smalley
2025-10-28  0:45 ` [PATCH v2 35/50] convert selinuxfs Al Viro
2025-10-29  0:02   ` Paul Moore
2025-10-29  3:24     ` Al Viro
2025-10-29 14:49       ` Paul Moore
2025-10-29 15:06   ` Stephen Smalley
2025-10-28  0:45 ` [PATCH v2 36/50] functionfs: switch to simple_remove_by_name() Al Viro
2025-10-28  8:47   ` Greg KH
2025-10-28  0:45 ` [PATCH v2 37/50] convert functionfs Al Viro
2025-10-28  0:45 ` [PATCH v2 38/50] gadgetfs: switch to simple_remove_by_name() Al Viro
2025-10-28  0:45 ` [PATCH v2 39/50] convert gadgetfs Al Viro
2025-10-28  0:45 ` [PATCH v2 40/50] hypfs: don't pin dentries twice Al Viro
2025-10-28  0:46 ` [PATCH v2 41/50] hypfs: switch hypfs_create_str() to returning int Al Viro
2025-10-28  0:46 ` [PATCH v2 42/50] hypfs: swich hypfs_create_u64() " Al Viro
2025-10-28  0:46 ` [PATCH v2 43/50] convert hypfs Al Viro
2025-10-28  0:46 ` [PATCH v2 44/50] convert rpc_pipefs Al Viro
2025-10-28  0:46 ` [PATCH v2 45/50] convert nfsctl Al Viro
2025-10-28  0:46 ` [PATCH v2 46/50] convert rust_binderfs Al Viro
2025-10-28  0:46 ` Al Viro [this message]
2025-10-28  0:46 ` [PATCH v2 48/50] convert securityfs Al Viro
2025-10-29  0:10   ` Paul Moore
2025-10-28  0:46 ` [PATCH v2 49/50] kill securityfs_recursive_remove() Al Viro
2025-10-29  0:04   ` Paul Moore
2025-10-28  0:46 ` [PATCH v2 50/50] d_make_discardable(): warn if given a non-persistent dentry Al Viro
2025-10-28  0:59 ` [PATCH v2 00/50] tree-in-dcache stuff Al Viro
2025-10-28  5:33 ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251028004614.393374-48-viro@zeniv.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=a.hindborg@kernel.org \
    --cc=borntraeger@linux.ibm.com \
    --cc=bpf@vger.kernel.org \
    --cc=brauner@kernel.org \
    --cc=casey@schaufler-ca.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jack@suse.cz \
    --cc=john.johansen@canonical.com \
    --cc=kees@kernel.org \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=miklos@szeredi.hu \
    --cc=neil@brown.name \
    --cc=ocfs2-devel@lists.linux.dev \
    --cc=paul@paul-moore.com \
    --cc=raven@themaw.net \
    --cc=rostedt@goodmis.org \
    --cc=selinux@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox