linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: libaokun@huaweicloud.com
To: linux-ext4@vger.kernel.org
Cc: tytso@mit.edu, adilger.kernel@dilger.ca, jack@suse.cz,
	linux-kernel@vger.kernel.org, kernel@pankajraghav.com,
	mcgrof@kernel.org, linux-fsdevel@vger.kernel.org,
	linux-mm@kvack.org, yi.zhang@huawei.com, yangerkun@huawei.com,
	chengzhihao1@huawei.com, libaokun1@huawei.com,
	libaokun@huaweicloud.com
Subject: [PATCH 18/25] ext4: support large block size in mpage_map_and_submit_buffers()
Date: Sat, 25 Oct 2025 11:22:14 +0800	[thread overview]
Message-ID: <20251025032221.2905818-19-libaokun@huaweicloud.com> (raw)
In-Reply-To: <20251025032221.2905818-1-libaokun@huaweicloud.com>

From: Baokun Li <libaokun1@huawei.com>

Use the EXT4_P_TO_LBLK/EXT4_LBLK_TO_P macros to complete the conversion
between folio indexes and blocks to avoid negative left/right shifts after
supporting blocksize greater than PAGE_SIZE.

Signed-off-by: Baokun Li <libaokun1@huawei.com>
Reviewed-by: Zhang Yi <yi.zhang@huawei.com>
---
 fs/ext4/inode.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index d97ce88d6e0a..cbf04b473ae7 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -2289,15 +2289,14 @@ static int mpage_map_and_submit_buffers(struct mpage_da_data *mpd)
 	struct folio_batch fbatch;
 	unsigned nr, i;
 	struct inode *inode = mpd->inode;
-	int bpp_bits = PAGE_SHIFT - inode->i_blkbits;
 	pgoff_t start, end;
 	ext4_lblk_t lblk;
 	ext4_fsblk_t pblock;
 	int err;
 	bool map_bh = false;
 
-	start = mpd->map.m_lblk >> bpp_bits;
-	end = (mpd->map.m_lblk + mpd->map.m_len - 1) >> bpp_bits;
+	start = EXT4_LBLK_TO_P(inode, mpd->map.m_lblk);
+	end = EXT4_LBLK_TO_P(inode, mpd->map.m_lblk + mpd->map.m_len - 1);
 	pblock = mpd->map.m_pblk;
 
 	folio_batch_init(&fbatch);
@@ -2308,7 +2307,7 @@ static int mpage_map_and_submit_buffers(struct mpage_da_data *mpd)
 		for (i = 0; i < nr; i++) {
 			struct folio *folio = fbatch.folios[i];
 
-			lblk = folio->index << bpp_bits;
+			lblk = EXT4_P_TO_LBLK(inode, folio->index);
 			err = mpage_process_folio(mpd, folio, &lblk, &pblock,
 						 &map_bh);
 			/*
-- 
2.46.1



  parent reply	other threads:[~2025-10-25  3:30 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-25  3:21 [PATCH 00/25] ext4: enable block size larger than page size libaokun
2025-10-25  3:21 ` [PATCH 01/25] ext4: remove page offset calculation in ext4_block_zero_page_range() libaokun
2025-11-03  7:41   ` Jan Kara
2025-10-25  3:21 ` [PATCH 02/25] ext4: remove page offset calculation in ext4_block_truncate_page() libaokun
2025-11-03  7:42   ` Jan Kara
2025-10-25  3:21 ` [PATCH 03/25] ext4: remove PAGE_SIZE checks for rec_len conversion libaokun
2025-11-03  7:43   ` Jan Kara
2025-10-25  3:22 ` [PATCH 04/25] ext4: make ext4_punch_hole() support large block size libaokun
2025-11-03  8:05   ` Jan Kara
2025-11-04  6:55     ` Baokun Li
2025-10-25  3:22 ` [PATCH 05/25] ext4: enable DIOREAD_NOLOCK by default for BS > PS as well libaokun
2025-11-03  8:06   ` Jan Kara
2025-10-25  3:22 ` [PATCH 06/25] ext4: introduce s_min_folio_order for future BS > PS support libaokun
2025-11-03  8:19   ` Jan Kara
2025-10-25  3:22 ` [PATCH 07/25] ext4: support large block size in ext4_calculate_overhead() libaokun
2025-11-03  8:14   ` Jan Kara
2025-11-03 14:37     ` Baokun Li
2025-10-25  3:22 ` [PATCH 08/25] ext4: support large block size in ext4_readdir() libaokun
2025-11-03  8:27   ` Jan Kara
2025-10-25  3:22 ` [PATCH 09/25] ext4: add EXT4_LBLK_TO_B macro for logical block to bytes conversion libaokun
2025-11-03  8:21   ` Jan Kara
2025-10-25  3:22 ` [PATCH 10/25] ext4: add EXT4_LBLK_TO_P and EXT4_P_TO_LBLK for block/page conversion libaokun
2025-11-03  8:26   ` Jan Kara
2025-11-03 14:45     ` Baokun Li
2025-11-05  8:27       ` Jan Kara
2025-10-25  3:22 ` [PATCH 11/25] ext4: support large block size in ext4_mb_load_buddy_gfp() libaokun
2025-11-05  8:46   ` Jan Kara
2025-10-25  3:22 ` [PATCH 12/25] ext4: support large block size in ext4_mb_get_buddy_page_lock() libaokun
2025-11-05  9:13   ` Jan Kara
2025-11-05  9:44     ` Baokun Li
2025-10-25  3:22 ` [PATCH 13/25] ext4: support large block size in ext4_mb_init_cache() libaokun
2025-11-05  9:18   ` Jan Kara
2025-10-25  3:22 ` [PATCH 14/25] ext4: prepare buddy cache inode for BS > PS with large folios libaokun
2025-11-05  9:19   ` Jan Kara
2025-10-25  3:22 ` [PATCH 15/25] ext4: rename 'page' references to 'folio' in multi-block allocator libaokun
2025-11-05  9:21   ` Jan Kara
2025-10-25  3:22 ` [PATCH 16/25] ext4: support large block size in ext4_mpage_readpages() libaokun
2025-11-05  9:26   ` Jan Kara
2025-10-25  3:22 ` [PATCH 17/25] ext4: support large block size in ext4_block_write_begin() libaokun
2025-11-05  9:28   ` Jan Kara
2025-10-25  3:22 ` libaokun [this message]
2025-11-05  9:30   ` [PATCH 18/25] ext4: support large block size in mpage_map_and_submit_buffers() Jan Kara
2025-10-25  3:22 ` [PATCH 19/25] ext4: support large block size in mpage_prepare_extent_to_map() libaokun
2025-11-05  9:31   ` Jan Kara
2025-10-25  3:22 ` [PATCH 20/25] ext4: support large block size in __ext4_block_zero_page_range() libaokun
2025-11-05  9:33   ` Jan Kara
2025-10-25  3:22 ` [PATCH 21/25] ext4: make online defragmentation support large block size libaokun
2025-11-05  9:50   ` Jan Kara
2025-11-05 10:48     ` Zhang Yi
2025-11-05 11:28     ` Baokun Li
2025-10-25  3:22 ` [PATCH 22/25] fs/buffer: prevent WARN_ON in __alloc_pages_slowpath() when BS > PS libaokun
2025-10-25  4:45   ` Matthew Wilcox
2025-10-25  5:13     ` Darrick J. Wong
2025-10-25  6:32     ` Baokun Li
2025-10-25  7:01       ` Zhang Yi
2025-10-25 17:56       ` Matthew Wilcox
2025-10-27  2:57         ` Baokun Li
2025-10-27  7:40         ` Christoph Hellwig
2025-10-30 21:25       ` Matthew Wilcox
2025-10-31  1:47         ` Zhang Yi
2025-10-31  1:55         ` Baokun Li
2025-10-25  6:34     ` Baokun Li
2025-10-25  3:22 ` [PATCH 23/25] jbd2: " libaokun
2025-10-25  3:22 ` [PATCH 24/25] ext4: add checks for large folio incompatibilities " libaokun
2025-11-05  9:59   ` Jan Kara
2025-10-25  3:22 ` [PATCH 25/25] ext4: enable block size larger than page size libaokun
2025-11-05 10:14   ` Jan Kara
2025-11-06  2:44     ` Baokun Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251025032221.2905818-19-libaokun@huaweicloud.com \
    --to=libaokun@huaweicloud.com \
    --cc=adilger.kernel@dilger.ca \
    --cc=chengzhihao1@huawei.com \
    --cc=jack@suse.cz \
    --cc=kernel@pankajraghav.com \
    --cc=libaokun1@huawei.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mcgrof@kernel.org \
    --cc=tytso@mit.edu \
    --cc=yangerkun@huawei.com \
    --cc=yi.zhang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox