From: Jason Gunthorpe <jgg@ziepe.ca>
To: Pasha Tatashin <pasha.tatashin@soleen.com>
Cc: akpm@linux-foundation.org, brauner@kernel.org, corbet@lwn.net,
graf@amazon.com, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-mm@kvack.org,
masahiroy@kernel.org, ojeda@kernel.org, pratyush@kernel.org,
rdunlap@infradead.org, rppt@kernel.org, tj@kernel.org,
jasonmiu@google.com, dmatlack@google.com, skhawaja@google.com
Subject: Re: [PATCH 2/2] liveupdate: kho: allocate metadata directly from the buddy allocator
Date: Fri, 24 Oct 2025 10:21:55 -0300 [thread overview]
Message-ID: <20251024132155.GA760669@ziepe.ca> (raw)
In-Reply-To: <20251015053121.3978358-3-pasha.tatashin@soleen.com>
On Wed, Oct 15, 2025 at 01:31:21AM -0400, Pasha Tatashin wrote:
> - elm = kzalloc(sz, GFP_KERNEL);
> + order = get_order(sz);
> + elm = (void *)__get_free_pages(GFP_KERNEL | __GFP_ZERO, order);
> if (!elm)
> return ERR_PTR(-ENOMEM);
Please add a function to allocate preservable non-scratch pages then
:\ I don't think we should be sprinkling __get_free_pages() all over
the place.
You can then add a cleanup.h for the new function and so on.
It should allocate frozen pages, accept a size_t and return a void *.
If this issue is only related to kfence then the new function could
have an if IS_ENABLED(KFENCE) and use slab when it is safe.
Jason
prev parent reply other threads:[~2025-10-24 13:22 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-15 5:31 [PATCH 0/2] KHO: Fix metadata allocation in scratch area Pasha Tatashin
2025-10-15 5:31 ` [PATCH 1/2] liveupdate: kho: warn and fail on metadata or preserved memory " Pasha Tatashin
2025-10-15 8:21 ` Mike Rapoport
2025-10-15 12:36 ` Pasha Tatashin
2025-10-16 17:23 ` Mike Rapoport
2025-10-18 15:31 ` Pasha Tatashin
2025-10-18 15:28 ` Pasha Tatashin
2025-10-15 12:10 ` Pratyush Yadav
2025-10-15 12:40 ` Pasha Tatashin
2025-10-15 13:11 ` Pratyush Yadav
2025-10-15 5:31 ` [PATCH 2/2] liveupdate: kho: allocate metadata directly from the buddy allocator Pasha Tatashin
2025-10-15 8:37 ` Mike Rapoport
2025-10-15 12:46 ` Pasha Tatashin
2025-10-15 13:05 ` Pratyush Yadav
2025-10-15 14:19 ` Pasha Tatashin
2025-10-15 14:36 ` Alexander Potapenko
2025-10-24 13:25 ` Jason Gunthorpe
2025-10-24 13:57 ` Pasha Tatashin
2025-10-24 14:20 ` Jason Gunthorpe
2025-10-24 14:36 ` Pasha Tatashin
2025-10-24 14:55 ` Jason Gunthorpe
2025-10-24 15:06 ` Pasha Tatashin
2025-10-15 14:22 ` Pasha Tatashin
2025-10-24 13:21 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251024132155.GA760669@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=corbet@lwn.net \
--cc=dmatlack@google.com \
--cc=graf@amazon.com \
--cc=jasonmiu@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=masahiroy@kernel.org \
--cc=ojeda@kernel.org \
--cc=pasha.tatashin@soleen.com \
--cc=pratyush@kernel.org \
--cc=rdunlap@infradead.org \
--cc=rppt@kernel.org \
--cc=skhawaja@google.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox