From: Andrew Morton <akpm@linux-foundation.org>
To: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: David Hildenbrand <david@redhat.com>,
Oscar Salvador <osalvador@suse.de>,
Muchun Song <muchun.song@linux.dev>, <linux-mm@kvack.org>,
<sidhartha.kumar@oracle.com>, <jane.chu@oracle.com>,
Zi Yan <ziy@nvidia.com>, Vlastimil Babka <vbabka@suse.cz>,
Brendan Jackman <jackmanb@google.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Matthew Wilcox <willy@infradead.org>
Subject: Re: [PATCH v4 5/6] mm: cma: add cma_alloc_frozen{_compound}()
Date: Thu, 23 Oct 2025 18:12:11 -0700 [thread overview]
Message-ID: <20251023181211.5884d84bd48d3d5ef9448741@linux-foundation.org> (raw)
In-Reply-To: <20251023115940.3573158-6-wangkefeng.wang@huawei.com>
On Thu, 23 Oct 2025 19:59:39 +0800 Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
> --- a/mm/internal.h
> +++ b/mm/internal.h
> @@ -515,13 +515,6 @@ static inline void set_page_refcounted(struct page *page)
>
> static inline void set_pages_refcounted(struct page *page, unsigned long nr_pages)
> {
> - unsigned long pfn = page_to_pfn(page);
> -
> - if (PageHead(page)) {
> - set_page_refcounted(page);
> - return;
> - }
> -
> for (; nr_pages--; pfn++)
> set_page_refcounted(pfn_to_page(pfn));
> }
pfn is undefined here.
I could fix, but what you sent clearly wasn't what you tested, so I'll
drop this version of this series.
next prev parent reply other threads:[~2025-10-24 1:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-23 11:59 [PATCH v4 0/6] mm: hugetlb: allocate frozen gigantic folio Kefeng Wang
2025-10-23 11:59 ` [PATCH v4 1/6] mm: debug_vm_pgtable: add debug_vm_pgtable_free_huge_page() Kefeng Wang
2025-10-23 11:59 ` [PATCH v4 2/6] mm: page_alloc: add __split_page() Kefeng Wang
2025-10-23 11:59 ` [PATCH v4 3/6] mm: cma: add __cma_release() Kefeng Wang
2025-10-23 11:59 ` [PATCH v4 4/6] mm: page_alloc: add alloc_contig_frozen_{range,pages}() Kefeng Wang
2025-10-23 11:59 ` [PATCH v4 5/6] mm: cma: add cma_alloc_frozen{_compound}() Kefeng Wang
2025-10-24 1:12 ` Andrew Morton [this message]
2025-10-24 1:31 ` Kefeng Wang
2025-10-23 11:59 ` [PATCH v4 6/6] mm: hugetlb: allocate frozen pages in alloc_gigantic_folio() Kefeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251023181211.5884d84bd48d3d5ef9448741@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=jackmanb@google.com \
--cc=jane.chu@oracle.com \
--cc=linux-mm@kvack.org \
--cc=muchun.song@linux.dev \
--cc=osalvador@suse.de \
--cc=sidhartha.kumar@oracle.com \
--cc=vbabka@suse.cz \
--cc=wangkefeng.wang@huawei.com \
--cc=willy@infradead.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox