From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5E972CCD1BC for ; Thu, 23 Oct 2025 16:51:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4F60C8E0015; Thu, 23 Oct 2025 12:51:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 47F688E0019; Thu, 23 Oct 2025 12:51:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2D0358E0015; Thu, 23 Oct 2025 12:51:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 071A08E0019 for ; Thu, 23 Oct 2025 12:51:19 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C5558140BAC for ; Thu, 23 Oct 2025 16:51:18 +0000 (UTC) X-FDA: 84029969436.25.3965C62 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf23.hostedemail.com (Postfix) with ESMTP id B9C2314000B for ; Thu, 23 Oct 2025 16:51:16 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=q8ECC6CS; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf23.hostedemail.com: domain of devnull+debug.rivosinc.com@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=devnull+debug.rivosinc.com@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1761238276; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dj4t8oHJHFGYvecueYgyOSzNzLpZ1TIb7xPt4GibhSI=; b=T19Z3M3G8AX4Qcf2cDgBBeydYhdhL6O/UIgdSGsDAYb54ldc94UrrMwTpAz7XeWDAsHJgh NtGXZL433l7zcIfrwu69gw4dYfNaepGI+WyW/APl3TZy2HbSn0W48Gqy/1VEeymHN8cug3 a11xgBKkqlTo2i0Iy8OwgkHO/lLU1uM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1761238276; a=rsa-sha256; cv=none; b=YOQPiqhInx/BkG6l2ZDpC1TAjDM7wK+PHIAO6jyd6jRp8DawWxutIM6tnXiD6afB8jlchc sMXwTweSUivNsiR2eKvrdmIp31ZHCqvmwGcvQQY1XZgpL+3bHbQe7+Ghs6ZxbnyJ8okenr 7E1g7mpWSW8wAXI8XNCGiN/HjONdDP8= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=q8ECC6CS; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf23.hostedemail.com: domain of devnull+debug.rivosinc.com@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=devnull+debug.rivosinc.com@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 177294B069; Thu, 23 Oct 2025 16:51:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id C9D1EC2BCB8; Thu, 23 Oct 2025 16:51:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1761238270; bh=Nt2zLD8Sdg7vBJGX6xA427HFGzcGQt9fZjSPUHt4WCk=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=q8ECC6CS9VGDVXaL8WrOz84y8tbF/74RAQP7lrImrX9zuHaBeN+kPDWC9HgaZ/WgC nOYJ5+NU5XCYOddMWXT3kqYRNsM+4RVEmDnaQ8WbwOl5NnEXuPTIZCrzIFJ8YZ4UpS C/VS0lEZShhf9KLJ2DD4XoiYaDAEXc77hxCAhWi2MLYd+NttKVu3Aniq6VXF3r2UXW 6+7fRBBsTITYi25gBqtH69t1h1zEHVVefDAkHHTcUuWQi790ECEaRnf5LE5puuURh2 igl4MQckAtRi6el8Jz+EUtBAYfYFGkSI7/5V8vzRcXpvWIfrJxBilG47JHCfsIMoTT VWBkrPrllQM7w== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7CB1CCD193; Thu, 23 Oct 2025 16:51:10 +0000 (UTC) From: Deepak Gupta via B4 Relay Date: Thu, 23 Oct 2025 09:51:17 -0700 Subject: [PATCH v22 12/28] riscv: Implements arch agnostic shadow stack prctls MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20251023-v5_user_cfi_series-v22-12-1935270f7636@rivosinc.com> References: <20251023-v5_user_cfi_series-v22-0-1935270f7636@rivosinc.com> In-Reply-To: <20251023-v5_user_cfi_series-v22-0-1935270f7636@rivosinc.com> To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Andrew Morton , "Liam R. Howlett" , Vlastimil Babka , Lorenzo Stoakes , Paul Walmsley , Palmer Dabbelt , Albert Ou , Conor Dooley , Rob Herring , Krzysztof Kozlowski , Arnd Bergmann , Christian Brauner , Peter Zijlstra , Oleg Nesterov , Eric Biederman , Kees Cook , Jonathan Corbet , Shuah Khan , Jann Horn , Conor Dooley , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Andreas Hindborg , Alice Ryhl , Trevor Gross , Benno Lossin Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-arch@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, alistair.francis@wdc.com, richard.henderson@linaro.org, jim.shu@sifive.com, andybnac@gmail.com, kito.cheng@sifive.com, charlie@rivosinc.com, atishp@rivosinc.com, evan@rivosinc.com, cleger@rivosinc.com, alexghiti@rivosinc.com, samitolvanen@google.com, broonie@kernel.org, rick.p.edgecombe@intel.com, rust-for-linux@vger.kernel.org, Zong Li , Deepak Gupta X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1761238267; l=7429; i=debug@rivosinc.com; s=20251023; h=from:subject:message-id; bh=z5xdZaKwg2qUwtrY22O4fobOm82lvR70DFtbPBo8Rjw=; b=7ohyxhZdXPWWRljekiJ/o0UFgCd1w47jPDlYBJz6qBlD1T6GKgX0GI7yeEo4Z4BuMICU/ONif bN0W19fqYsOAadBjibdA1WX+unF/OP9BlXvXWWDaV48bWhlDU+Armho X-Developer-Key: i=debug@rivosinc.com; a=ed25519; pk=O37GQv1thBhZToXyQKdecPDhtWVbEDRQ0RIndijvpjk= X-Endpoint-Received: by B4 Relay for debug@rivosinc.com/20251023 with auth_id=553 X-Original-From: Deepak Gupta Reply-To: debug@rivosinc.com X-Rspam-User: X-Rspamd-Queue-Id: B9C2314000B X-Rspamd-Server: rspam02 X-Stat-Signature: zqgq4p9m768jsyx5tq53gteamw5uxxwq X-HE-Tag: 1761238276-527251 X-HE-Meta: U2FsdGVkX1+dHoUkZTO9xliVeGi70a6E1HrHaMw3gYNhV04vn2JCHc0BV8mk0NwOy9kvIflZ2JC/WnRXo+KqOqJMcSYTXn01dzryWpMt6m+JIGB9elT4v+J3g/GNLzndVCwaMwOJ8qlHf1NhZQcIrSHp+lucBwnD+BCKd83rYLq+VannnEntKl4upBqk57LfJK61YlwNabTFcR43H13Vok3pw2+CZJDf2NKUn4xWztPsc5nfXetpsK6Crs5iSjJKxX2PCtRFhufQ3MYhkBDzPTf2Q7aJjBxS5grBxsiWuprfICMvPW4KjplknQ1AO87adNWgsptONfiGU5txTYSDHzi0T+dWcx6Y77fNHXR9yqQUsiNpgMgph3/riar5KxbgjlCurECxxZ9y8Wx7Oj6vCSei9Q+qm5seGyOeTUePA0j+uGaHg0nIw6fTEaRXFL1xXh4JHob8lYIO7/QJuHo6btJzBIW+60OIDtVBiahDufkQs3dTPFr4IN8O+2EqS96d+/hq2PFAjUQi1jPRBDXhuWfAK275sNun79KC50PzowGrAvPVc1qnFfaQnLWa/z52Z3SgvKmQqKaVQSwLah79ND7wt/mpaOG+j6pPM9enAwJHpaI6Bpbt6swNKz9mtWWFlgcobVxygHigkBeUrWd8fi+QY/0ol1vE3qzkr+niKCJ3eMaioo80IpF3pSk85ilf+JJqgV4SBZKU09658TJUufn0nGjo8PrSh/ZJxgPsRqcFAXCOBw2NnNuRjU1ke1+x+Br0VmKR0qGjYka2JGPxgGMj/tQjUGfMpgE+vhRzePpeUmw5xg1I9lr6bxu9TWHZKv/hXJJaCNZwxQgDyqtOZRYLo2uniT6q5IrvZSEQol6eAUwUsIZIIZkQX+EaNi8YoQ/3UN3z55DDOnfRJPaSb1xxsaAO2kU3I3Irc0N+ANeJ23pUqrE89/Z0uLlMVgorCmCyb3oUvtzwfWW1hkt VYvZSh2R x20qD1MGXovt1izz4aBF0geRZLd6gNqgovrcdx2WtGOLRJQ/3woLJOC83BQueGG9h8cGeS3M2Lp9PsKmYm1ac0xCsWzKJFT6+zDAUq7nH0meColMn231E21vkNcxOPCSfwY63eZGYZoclSDK1v686J27g4XM97qdqf+0pa4/O3E2iDy95PWxi7rpyaSzP/Mo97t3REPj2opFeUiQ6n4pwGCJ7vVimK55ixi/gfD0h8oF1MjSZSLzxJksHHyx/+X5pLH9OJrhhZwmvwXskX+me2z+HRxN+MH/RiwSrKMwMteA2KGu61BmMLWBtGsFjBYHqR/NZxaGUTBJLUgxtDgCd9OrFEWmxrQVS7nu4QolOyy7Ro2/u9XGoMCx4wyI4GmpazebkzD13/qJTMFEQNToelYaEhxICm+8C4GLjoIy0u73mGFvRSvGjucTAMlffOyurieJGv+rzriV66ay06h4jT6ygWJhD+3y8MmHlMGqwYUc6sClH52BGN3MSxA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Deepak Gupta Implement architecture agnostic prctls() interface for setting and getting shadow stack status. prctls implemented are PR_GET_SHADOW_STACK_STATUS, PR_SET_SHADOW_STACK_STATUS and PR_LOCK_SHADOW_STACK_STATUS. As part of PR_SET_SHADOW_STACK_STATUS/PR_GET_SHADOW_STACK_STATUS, only PR_SHADOW_STACK_ENABLE is implemented because RISCV allows each mode to write to their own shadow stack using `sspush` or `ssamoswap`. PR_LOCK_SHADOW_STACK_STATUS locks current configuration of shadow stack enabling. Reviewed-by: Zong Li Signed-off-by: Deepak Gupta --- arch/riscv/include/asm/usercfi.h | 16 ++++++ arch/riscv/kernel/process.c | 8 +++ arch/riscv/kernel/usercfi.c | 110 +++++++++++++++++++++++++++++++++++++++ 3 files changed, 134 insertions(+) diff --git a/arch/riscv/include/asm/usercfi.h b/arch/riscv/include/asm/usercfi.h index a16a5dff8b0e..d71093f414df 100644 --- a/arch/riscv/include/asm/usercfi.h +++ b/arch/riscv/include/asm/usercfi.h @@ -7,6 +7,7 @@ #ifndef __ASSEMBLER__ #include +#include struct task_struct; struct kernel_clone_args; @@ -14,6 +15,7 @@ struct kernel_clone_args; #ifdef CONFIG_RISCV_USER_CFI struct cfi_state { unsigned long ubcfi_en : 1; /* Enable for backward cfi. */ + unsigned long ubcfi_locked : 1; unsigned long user_shdw_stk; /* Current user shadow stack pointer */ unsigned long shdw_stk_base; /* Base address of shadow stack */ unsigned long shdw_stk_size; /* size of shadow stack */ @@ -26,6 +28,12 @@ void set_shstk_base(struct task_struct *task, unsigned long shstk_addr, unsigned unsigned long get_shstk_base(struct task_struct *task, unsigned long *size); void set_active_shstk(struct task_struct *task, unsigned long shstk_addr); bool is_shstk_enabled(struct task_struct *task); +bool is_shstk_locked(struct task_struct *task); +bool is_shstk_allocated(struct task_struct *task); +void set_shstk_lock(struct task_struct *task); +void set_shstk_status(struct task_struct *task, bool enable); + +#define PR_SHADOW_STACK_SUPPORTED_STATUS_MASK (PR_SHADOW_STACK_ENABLE) #else @@ -41,6 +49,14 @@ bool is_shstk_enabled(struct task_struct *task); #define is_shstk_enabled(task) false +#define is_shstk_locked(task) false + +#define is_shstk_allocated(task) false + +#define set_shstk_lock(task) do {} while (0) + +#define set_shstk_status(task, enable) do {} while (0) + #endif /* CONFIG_RISCV_USER_CFI */ #endif /* __ASSEMBLER__ */ diff --git a/arch/riscv/kernel/process.c b/arch/riscv/kernel/process.c index 72d35adc6e0e..a137d3483646 100644 --- a/arch/riscv/kernel/process.c +++ b/arch/riscv/kernel/process.c @@ -156,6 +156,14 @@ void start_thread(struct pt_regs *regs, unsigned long pc, regs->epc = pc; regs->sp = sp; + /* + * clear shadow stack state on exec. + * libc will set it later via prctl. + */ + set_shstk_status(current, false); + set_shstk_base(current, 0, 0); + set_active_shstk(current, 0); + #ifdef CONFIG_64BIT regs->status &= ~SR_UXL; diff --git a/arch/riscv/kernel/usercfi.c b/arch/riscv/kernel/usercfi.c index ec3d78efd6f3..08620bdae696 100644 --- a/arch/riscv/kernel/usercfi.c +++ b/arch/riscv/kernel/usercfi.c @@ -24,6 +24,16 @@ bool is_shstk_enabled(struct task_struct *task) return task->thread_info.user_cfi_state.ubcfi_en; } +bool is_shstk_allocated(struct task_struct *task) +{ + return task->thread_info.user_cfi_state.shdw_stk_base; +} + +bool is_shstk_locked(struct task_struct *task) +{ + return task->thread_info.user_cfi_state.ubcfi_locked; +} + void set_shstk_base(struct task_struct *task, unsigned long shstk_addr, unsigned long size) { task->thread_info.user_cfi_state.shdw_stk_base = shstk_addr; @@ -42,6 +52,26 @@ void set_active_shstk(struct task_struct *task, unsigned long shstk_addr) task->thread_info.user_cfi_state.user_shdw_stk = shstk_addr; } +void set_shstk_status(struct task_struct *task, bool enable) +{ + if (!cpu_supports_shadow_stack()) + return; + + task->thread_info.user_cfi_state.ubcfi_en = enable ? 1 : 0; + + if (enable) + task->thread.envcfg |= ENVCFG_SSE; + else + task->thread.envcfg &= ~ENVCFG_SSE; + + csr_write(CSR_ENVCFG, task->thread.envcfg); +} + +void set_shstk_lock(struct task_struct *task) +{ + task->thread_info.user_cfi_state.ubcfi_locked = 1; +} + /* * If size is 0, then to be compatible with regular stack we want it to be as big as * regular stack. Else PAGE_ALIGN it and return back @@ -261,3 +291,83 @@ void shstk_release(struct task_struct *tsk) vm_munmap(base, size); set_shstk_base(tsk, 0, 0); } + +int arch_get_shadow_stack_status(struct task_struct *t, unsigned long __user *status) +{ + unsigned long bcfi_status = 0; + + if (!cpu_supports_shadow_stack()) + return -EINVAL; + + /* this means shadow stack is enabled on the task */ + bcfi_status |= (is_shstk_enabled(t) ? PR_SHADOW_STACK_ENABLE : 0); + + return copy_to_user(status, &bcfi_status, sizeof(bcfi_status)) ? -EFAULT : 0; +} + +int arch_set_shadow_stack_status(struct task_struct *t, unsigned long status) +{ + unsigned long size = 0, addr = 0; + bool enable_shstk = false; + + if (!cpu_supports_shadow_stack()) + return -EINVAL; + + /* Reject unknown flags */ + if (status & ~PR_SHADOW_STACK_SUPPORTED_STATUS_MASK) + return -EINVAL; + + /* bcfi status is locked and further can't be modified by user */ + if (is_shstk_locked(t)) + return -EINVAL; + + enable_shstk = status & PR_SHADOW_STACK_ENABLE; + /* Request is to enable shadow stack and shadow stack is not enabled already */ + if (enable_shstk && !is_shstk_enabled(t)) { + /* shadow stack was allocated and enable request again + * no need to support such usecase and return EINVAL. + */ + if (is_shstk_allocated(t)) + return -EINVAL; + + size = calc_shstk_size(0); + addr = allocate_shadow_stack(0, size, 0, false); + if (IS_ERR_VALUE(addr)) + return -ENOMEM; + set_shstk_base(t, addr, size); + set_active_shstk(t, addr + size); + } + + /* + * If a request to disable shadow stack happens, let's go ahead and release it + * Although, if CLONE_VFORKed child did this, then in that case we will end up + * not releasing the shadow stack (because it might be needed in parent). Although + * we will disable it for VFORKed child. And if VFORKed child tries to enable again + * then in that case, it'll get entirely new shadow stack because following condition + * are true + * - shadow stack was not enabled for vforked child + * - shadow stack base was anyways pointing to 0 + * This shouldn't be a big issue because we want parent to have availability of shadow + * stack whenever VFORKed child releases resources via exit or exec but at the same + * time we want VFORKed child to break away and establish new shadow stack if it desires + * + */ + if (!enable_shstk) + shstk_release(t); + + set_shstk_status(t, enable_shstk); + return 0; +} + +int arch_lock_shadow_stack_status(struct task_struct *task, + unsigned long arg) +{ + /* If shtstk not supported or not enabled on task, nothing to lock here */ + if (!cpu_supports_shadow_stack() || + !is_shstk_enabled(task) || arg != 0) + return -EINVAL; + + set_shstk_lock(task); + + return 0; +} -- 2.43.0