From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 13206CCF9EB for ; Thu, 23 Oct 2025 16:51:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F301F8E0017; Thu, 23 Oct 2025 12:51:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EE05E8E0015; Thu, 23 Oct 2025 12:51:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CE44D8E0017; Thu, 23 Oct 2025 12:51:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id B801A8E0015 for ; Thu, 23 Oct 2025 12:51:18 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 73A6D140BBE for ; Thu, 23 Oct 2025 16:51:18 +0000 (UTC) X-FDA: 84029969436.30.A8B8F48 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf11.hostedemail.com (Postfix) with ESMTP id 5384A4001B for ; Thu, 23 Oct 2025 16:51:16 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=I+9I5VbI; spf=pass (imf11.hostedemail.com: domain of devnull+debug.rivosinc.com@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=devnull+debug.rivosinc.com@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1761238276; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vvTS72JlUAt6GbVtaA9+jO85mMj8kdDw4B6rz6IQdTY=; b=fvUtaguUCQeVHU2rLMT75X7Pw8ngeWY5ILunixTlibXNueapLqMdV02pY3oI8UU06JQ5HS jDcFmbgjkvuMwszTETAR4oNyWlUdr+9CYEMrHyNbk23pqm0lQTFLBG31MtHT4rB48LTn17 p/1m00NwJgTbagrpIkgsW5DuiEb+U7o= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=I+9I5VbI; spf=pass (imf11.hostedemail.com: domain of devnull+debug.rivosinc.com@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=devnull+debug.rivosinc.com@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1761238276; a=rsa-sha256; cv=none; b=UviHU0mvvOsaCHNR3Ls6dbGBYVXGHcebP5wZHR19yI1gO3Jys+DxHdYQeAAKjpriT4GmST vX8H65ZIMYlaf1WIc4/D6bw/yX2XbYUY3WpBT+00xcrLQNkjAwKKlvWfQpMnnMxBUobspe S74GCSqMu0mF8iC2cq5UX6Q4aAxe8nA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id F014B4AFE3; Thu, 23 Oct 2025 16:51:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id B2167C2BCB5; Thu, 23 Oct 2025 16:51:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1761238270; bh=sBNjkIEDOFpToniuMunkLQrwCp8Ll7kcmqpzuth7VfY=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=I+9I5VbILyLIyf5IhycZYXEfz5GMgz452woDJ30IipYiXtYe6qXNr+zWMgbk46EoJ xSCRbur2D6aVESilng32NkbulvsPNvUEcWipdIlNjUoxkcqn0z2UqUrrBOd2T2X0kC i8XAiT5A/OscTuYWNwwa35Q/VB1cfye78YvHHWTiEm52PdEiZBaTVgz8aPd7ffciGB 7vAJdo+AGAkSBTBEKyW/H1xQgg/Uy8Z/eowJ85Fd3SXiMikbZd/fUiRkX0I6RNp+jP 8mL6rgu2itXEOqaTKhx6RSd2xTvlwqm89bbVRvGmgT7gfNAmGvWghlw+A7wHrABxrR 1ja2iHBdqePPw== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F621CCF9E3; Thu, 23 Oct 2025 16:51:10 +0000 (UTC) From: Deepak Gupta via B4 Relay Date: Thu, 23 Oct 2025 09:51:16 -0700 Subject: [PATCH v22 11/28] riscv/shstk: If needed allocate a new shadow stack on clone MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20251023-v5_user_cfi_series-v22-11-1935270f7636@rivosinc.com> References: <20251023-v5_user_cfi_series-v22-0-1935270f7636@rivosinc.com> In-Reply-To: <20251023-v5_user_cfi_series-v22-0-1935270f7636@rivosinc.com> To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Andrew Morton , "Liam R. Howlett" , Vlastimil Babka , Lorenzo Stoakes , Paul Walmsley , Palmer Dabbelt , Albert Ou , Conor Dooley , Rob Herring , Krzysztof Kozlowski , Arnd Bergmann , Christian Brauner , Peter Zijlstra , Oleg Nesterov , Eric Biederman , Kees Cook , Jonathan Corbet , Shuah Khan , Jann Horn , Conor Dooley , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Andreas Hindborg , Alice Ryhl , Trevor Gross , Benno Lossin Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-arch@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, alistair.francis@wdc.com, richard.henderson@linaro.org, jim.shu@sifive.com, andybnac@gmail.com, kito.cheng@sifive.com, charlie@rivosinc.com, atishp@rivosinc.com, evan@rivosinc.com, cleger@rivosinc.com, alexghiti@rivosinc.com, samitolvanen@google.com, broonie@kernel.org, rick.p.edgecombe@intel.com, rust-for-linux@vger.kernel.org, Zong Li , Deepak Gupta X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1761238267; l=9013; i=debug@rivosinc.com; s=20251023; h=from:subject:message-id; bh=J6pR8GRxWFhgvoVIFkuG4OND1BCNoXiY7FcguKrzJIk=; b=MI+5sy9ihdDFWjRgT7vZ2yngZeYUq8FJMyEU8jpPWroM+DiGjB5E30oiHnuRjg6KP2LMEV8er 6SmwDlNlV0IDBqHO9JOM1yWXUFRX/FuAYZI9HiTddHRz0JUFcCLR5sR X-Developer-Key: i=debug@rivosinc.com; a=ed25519; pk=O37GQv1thBhZToXyQKdecPDhtWVbEDRQ0RIndijvpjk= X-Endpoint-Received: by B4 Relay for debug@rivosinc.com/20251023 with auth_id=553 X-Original-From: Deepak Gupta Reply-To: debug@rivosinc.com X-Stat-Signature: iaifoxg7aocgsyc5ni3od4ht5558irih X-Rspamd-Queue-Id: 5384A4001B X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1761238276-623751 X-HE-Meta: U2FsdGVkX1+3+/amQ0CDNSwo+YbxMrRql81ek/XaSScPsF85ApHxkYEc3vBMKu26furnbRqoFb9rtebQ9ZXgegdv7+ks36zjA99vMWSTzNxT72WqSy8X7xqCGaYS/VXMnQn9lJbDLPvnyfcrV8l3B4BqRqhEx4YVVxZ7qbNq1dgcchJf2MLl0XqfsyVjMRjKUAmtoXAtqv675x8TO7WYoUGUzWx4PInCHyCk0Wlj6TAZFpdQvx7fG32yUCBK9DJCTL63YUgyUxZzx+VDs7kPqnq+3VlaVkDYsyi0k+RkdPcFM2W5Bs7dpNpFiNtwjIjHJTuvunZQ4DTShEuSNFxD9ddv2LB3g2OLgEDRGANbYRAJNahRCk87FnV3ckpkbJSyiRM9KasopyJhQSRN/dYp0fitQ1atwuoIkyH51PdYReRYhOIH6N0mdvsL3ObVRHst3EuEvCEaCMoIGu9bCjwxJVm3blG4FogOzKmS1PxhdxfAyzBWypOv2xuqNJsVfA11hVSRBMTkxEfFwJ2JUjNIJaI+e/O7ORwl0yYPakC6+56YXMVMrjlXeHp+8MNcIpi39ETAdmco0AjaoayCGa/z1kYqBn+jsL7iJZWCkK9lotKIhjft28BVPrBSXh58jh30UYySkgtDSba0vFrf/RpICPrZ4SbNc2hU/yibE3O1C+hT1/gGbE88nDoM0fKPJ4uPfEBNkYhSY0P1vsPYny1d1+n4rNwZpsdMWYknn7C393IoijsU4joodGCAWzlUsYV2q0vQKH78wRjIKAOGgBpomSMFNAjpMATnHYlhpDGY5TG93Q3rExIRR1SEnMCpN7+0RHe44/BXE2KRUZoSCGdMKivOJ50WsOFgy4gxmVFVdUN2x9naabgTbNRz9tC7XlBWu2aUBMJeXve3so7hGN2b1CqfwzWhr9uHBN05AX6Tt1V51DCz7t9F1ZtDqLMmDvndiMbEfZT1ms4UNeb4cSW F4TOmBAS dq59WJMMcg4pmqvXI3DCmOVeBm1aSJDahGcSLJXFHJBx3+IEGDTNax57hFe/r4+ySxk3Hcnw/todhHm+VMgRU90DEVyR1nvHJP03cpwgKtTyaYsqbXi00XiPxsHf7zGYzJNhE3/h3vaZhjMTgrmEfyPytNnQaAsSx2ZWX/ZgAyapWiHX0dw+L6M9niZCcZmqxxx/nChcOG+yx+DeZKzYLF9nA0cJbP89grAGqKqB+Z4/EQZ1/DmlhNfIdOCSqMxmvTU5CdY3Fv1s02TYukj58xWMuCrDbRTdYqPTEoJ35VLA8I8EUPj1o8P4u84cmdbLKf3NEtZOTNAD2PEwD1IoS2+jkil+XURgw4C2ACZbD58WcY5W0W0vKEAQXe+SJEfCLVDEIHLGgggwU2z2pLCojpLuNfeSgxkwV8XbplHxjb0IGq8i5rt1yJYvwvYHnB8/IhFhsww6aAQimrkJ+c1fTUQfYWg16SVIcnUbwX2S8p/hw6ZiGXw8U2ScZopK1az5Er2e7ZUwFhJTI+YKjMv+LAV6FLkl+I6p3gldN X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Deepak Gupta Userspace specifies CLONE_VM to share address space and spawn new thread. `clone` allow userspace to specify a new stack for new thread. However there is no way to specify new shadow stack base address without changing API. This patch allocates a new shadow stack whenever CLONE_VM is given. In case of CLONE_VFORK, parent is suspended until child finishes and thus can child use parent shadow stack. In case of !CLONE_VM, COW kicks in because entire address space is copied from parent to child. `clone3` is extensible and can provide mechanisms using which shadow stack as an input parameter can be provided. This is not settled yet and being extensively discussed on mailing list. Once that's settled, this commit will adapt to that. Reviewed-by: Zong Li Signed-off-by: Deepak Gupta --- arch/riscv/include/asm/mmu_context.h | 7 ++ arch/riscv/include/asm/usercfi.h | 25 ++++++++ arch/riscv/kernel/process.c | 10 +++ arch/riscv/kernel/usercfi.c | 120 +++++++++++++++++++++++++++++++++++ 4 files changed, 162 insertions(+) diff --git a/arch/riscv/include/asm/mmu_context.h b/arch/riscv/include/asm/mmu_context.h index 8c4bc49a3a0f..dbf27a78df6c 100644 --- a/arch/riscv/include/asm/mmu_context.h +++ b/arch/riscv/include/asm/mmu_context.h @@ -48,6 +48,13 @@ static inline unsigned long mm_untag_mask(struct mm_struct *mm) } #endif +#define deactivate_mm deactivate_mm +static inline void deactivate_mm(struct task_struct *tsk, + struct mm_struct *mm) +{ + shstk_release(tsk); +} + #include #endif /* _ASM_RISCV_MMU_CONTEXT_H */ diff --git a/arch/riscv/include/asm/usercfi.h b/arch/riscv/include/asm/usercfi.h index 4c5233e8f3f9..a16a5dff8b0e 100644 --- a/arch/riscv/include/asm/usercfi.h +++ b/arch/riscv/include/asm/usercfi.h @@ -8,6 +8,9 @@ #ifndef __ASSEMBLER__ #include +struct task_struct; +struct kernel_clone_args; + #ifdef CONFIG_RISCV_USER_CFI struct cfi_state { unsigned long ubcfi_en : 1; /* Enable for backward cfi. */ @@ -16,6 +19,28 @@ struct cfi_state { unsigned long shdw_stk_size; /* size of shadow stack */ }; +unsigned long shstk_alloc_thread_stack(struct task_struct *tsk, + const struct kernel_clone_args *args); +void shstk_release(struct task_struct *tsk); +void set_shstk_base(struct task_struct *task, unsigned long shstk_addr, unsigned long size); +unsigned long get_shstk_base(struct task_struct *task, unsigned long *size); +void set_active_shstk(struct task_struct *task, unsigned long shstk_addr); +bool is_shstk_enabled(struct task_struct *task); + +#else + +#define shstk_alloc_thread_stack(tsk, args) 0 + +#define shstk_release(tsk) + +#define get_shstk_base(task, size) 0UL + +#define set_shstk_base(task, shstk_addr, size) do {} while (0) + +#define set_active_shstk(task, shstk_addr) do {} while (0) + +#define is_shstk_enabled(task) false + #endif /* CONFIG_RISCV_USER_CFI */ #endif /* __ASSEMBLER__ */ diff --git a/arch/riscv/kernel/process.c b/arch/riscv/kernel/process.c index 31a392993cb4..72d35adc6e0e 100644 --- a/arch/riscv/kernel/process.c +++ b/arch/riscv/kernel/process.c @@ -31,6 +31,7 @@ #include #include #include +#include #if defined(CONFIG_STACKPROTECTOR) && !defined(CONFIG_STACKPROTECTOR_PER_TASK) #include @@ -226,6 +227,7 @@ int copy_thread(struct task_struct *p, const struct kernel_clone_args *args) u64 clone_flags = args->flags; unsigned long usp = args->stack; unsigned long tls = args->tls; + unsigned long ssp = 0; struct pt_regs *childregs = task_pt_regs(p); /* Ensure all threads in this mm have the same pointer masking mode. */ @@ -245,11 +247,19 @@ int copy_thread(struct task_struct *p, const struct kernel_clone_args *args) p->thread.s[1] = (unsigned long)args->fn_arg; p->thread.ra = (unsigned long)ret_from_fork_kernel_asm; } else { + /* allocate new shadow stack if needed. In case of CLONE_VM we have to */ + ssp = shstk_alloc_thread_stack(p, args); + if (IS_ERR_VALUE(ssp)) + return PTR_ERR((void *)ssp); + *childregs = *(current_pt_regs()); /* Turn off status.VS */ riscv_v_vstate_off(childregs); if (usp) /* User fork */ childregs->sp = usp; + /* if needed, set new ssp */ + if (ssp) + set_active_shstk(p, ssp); if (clone_flags & CLONE_SETTLS) childregs->tp = tls; childregs->a0 = 0; /* Return value of fork() */ diff --git a/arch/riscv/kernel/usercfi.c b/arch/riscv/kernel/usercfi.c index 0b3bbb41490a..ec3d78efd6f3 100644 --- a/arch/riscv/kernel/usercfi.c +++ b/arch/riscv/kernel/usercfi.c @@ -19,6 +19,41 @@ #define SHSTK_ENTRY_SIZE sizeof(void *) +bool is_shstk_enabled(struct task_struct *task) +{ + return task->thread_info.user_cfi_state.ubcfi_en; +} + +void set_shstk_base(struct task_struct *task, unsigned long shstk_addr, unsigned long size) +{ + task->thread_info.user_cfi_state.shdw_stk_base = shstk_addr; + task->thread_info.user_cfi_state.shdw_stk_size = size; +} + +unsigned long get_shstk_base(struct task_struct *task, unsigned long *size) +{ + if (size) + *size = task->thread_info.user_cfi_state.shdw_stk_size; + return task->thread_info.user_cfi_state.shdw_stk_base; +} + +void set_active_shstk(struct task_struct *task, unsigned long shstk_addr) +{ + task->thread_info.user_cfi_state.user_shdw_stk = shstk_addr; +} + +/* + * If size is 0, then to be compatible with regular stack we want it to be as big as + * regular stack. Else PAGE_ALIGN it and return back + */ +static unsigned long calc_shstk_size(unsigned long size) +{ + if (size) + return PAGE_ALIGN(size); + + return PAGE_ALIGN(min_t(unsigned long long, rlimit(RLIMIT_STACK), SZ_4G)); +} + /* * Writes on shadow stack can either be `sspush` or `ssamoswap`. `sspush` can happen * implicitly on current shadow stack pointed to by CSR_SSP. `ssamoswap` takes pointer to @@ -141,3 +176,88 @@ SYSCALL_DEFINE3(map_shadow_stack, unsigned long, addr, unsigned long, size, unsi return allocate_shadow_stack(addr, aligned_size, size, set_tok); } + +/* + * This gets called during clone/clone3/fork. And is needed to allocate a shadow stack for + * cases where CLONE_VM is specified and thus a different stack is specified by user. We + * thus need a separate shadow stack too. How does separate shadow stack is specified by + * user is still being debated. Once that's settled, remove this part of the comment. + * This function simply returns 0 if shadow stack are not supported or if separate shadow + * stack allocation is not needed (like in case of !CLONE_VM) + */ +unsigned long shstk_alloc_thread_stack(struct task_struct *tsk, + const struct kernel_clone_args *args) +{ + unsigned long addr, size; + + /* If shadow stack is not supported, return 0 */ + if (!cpu_supports_shadow_stack()) + return 0; + + /* + * If shadow stack is not enabled on the new thread, skip any + * switch to a new shadow stack. + */ + if (!is_shstk_enabled(tsk)) + return 0; + + /* + * For CLONE_VFORK the child will share the parents shadow stack. + * Set base = 0 and size = 0, this is special means to track this state + * so the freeing logic run for child knows to leave it alone. + */ + if (args->flags & CLONE_VFORK) { + set_shstk_base(tsk, 0, 0); + return 0; + } + + /* + * For !CLONE_VM the child will use a copy of the parents shadow + * stack. + */ + if (!(args->flags & CLONE_VM)) + return 0; + + /* + * reaching here means, CLONE_VM was specified and thus a separate shadow + * stack is needed for new cloned thread. Note: below allocation is happening + * using current mm. + */ + size = calc_shstk_size(args->stack_size); + addr = allocate_shadow_stack(0, size, 0, false); + if (IS_ERR_VALUE(addr)) + return addr; + + set_shstk_base(tsk, addr, size); + + return addr + size; +} + +void shstk_release(struct task_struct *tsk) +{ + unsigned long base = 0, size = 0; + /* If shadow stack is not supported or not enabled, nothing to release */ + if (!cpu_supports_shadow_stack() || !is_shstk_enabled(tsk)) + return; + + /* + * When fork() with CLONE_VM fails, the child (tsk) already has a + * shadow stack allocated, and exit_thread() calls this function to + * free it. In this case the parent (current) and the child share + * the same mm struct. Move forward only when they're same. + */ + if (!tsk->mm || tsk->mm != current->mm) + return; + + /* + * We know shadow stack is enabled but if base is NULL, then + * this task is not managing its own shadow stack (CLONE_VFORK). So + * skip freeing it. + */ + base = get_shstk_base(tsk, &size); + if (!base) + return; + + vm_munmap(base, size); + set_shstk_base(tsk, 0, 0); +} -- 2.43.0