linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Leon Hwang <leon.hwang@linux.dev>
Cc: stable@vger.kernel.org, akpm@linux-foundation.org,
	david@redhat.com, lorenzo.stoakes@oracle.com, shuah@kernel.org,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Lance Yang <lance.yang@linux.dev>
Subject: Re: [PATCH 6.1.y] selftests/mm: Move default_huge_page_size to vm_util.c
Date: Wed, 22 Oct 2025 09:40:49 +0200	[thread overview]
Message-ID: <2025102230-scoured-levitator-a530@gregkh> (raw)
In-Reply-To: <20251022055138.375042-1-leon.hwang@linux.dev>

On Wed, Oct 22, 2025 at 01:51:38PM +0800, Leon Hwang wrote:
> Fix the build error:
> 
> map_hugetlb.c: In function 'main':
> map_hugetlb.c:79:25: warning: implicit declaration of function 'default_huge_page_size' [-Wimplicit-function-declaration]
>    79 |         hugepage_size = default_huge_page_size();
>       |                         ^~~~~~~~~~~~~~~~~~~~~~
> /usr/bin/ld: /tmp/ccYOogvJ.o: in function 'main':
> map_hugetlb.c:(.text+0x114): undefined reference to 'default_huge_page_size'
> 
> According to the latest selftests, 'default_huge_page_size' has been
> moved to 'vm_util.c'. So fix the error by the same way.
> 
> Reviewed-by: Lance Yang <lance.yang@linux.dev>
> Signed-off-by: Leon Hwang <leon.hwang@linux.dev>
> ---
>  tools/testing/selftests/vm/Makefile      |  1 +
>  tools/testing/selftests/vm/userfaultfd.c | 24 ------------------------
>  tools/testing/selftests/vm/vm_util.c     | 21 +++++++++++++++++++++
>  tools/testing/selftests/vm/vm_util.h     |  1 +
>  4 files changed, 23 insertions(+), 24 deletions(-)


What commit id does this fix?  And again, why not just take the original
commits instead?

thanks,

greg k-h


  parent reply	other threads:[~2025-10-22  7:40 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-22  5:51 Leon Hwang
2025-10-22  6:01 ` Lance Yang
2025-10-22  6:07   ` Greg KH
2025-10-22  6:20     ` Leon Hwang
2025-10-22  7:35       ` Greg KH
2025-10-22  7:40 ` Greg KH [this message]
2025-10-22  8:08   ` Leon Hwang
2025-10-22  8:20     ` Greg KH
2025-10-22 13:34       ` Leon Hwang
2025-10-22 14:26         ` Greg KH
2025-10-22 15:35           ` Leon Hwang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025102230-scoured-levitator-a530@gregkh \
    --to=greg@kroah.com \
    --cc=akpm@linux-foundation.org \
    --cc=david@redhat.com \
    --cc=lance.yang@linux.dev \
    --cc=leon.hwang@linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=shuah@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox