linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: Andrew Morton <akpm@linux-foundation.org>,
	David Hildenbrand <david@redhat.com>,
	Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
	<linux-mm@kvack.org>
Cc: Zi Yan <ziy@nvidia.com>,
	Baolin Wang <baolin.wang@linux.alibaba.com>,
	Ryan Roberts <ryan.roberts@arm.com>, Dev Jain <dev.jain@arm.com>,
	Barry Song <baohua@kernel.org>, Lance Yang <lance.yang@linux.dev>,
	<Liam.Howlett@oracle.com>,
	Kefeng Wang <wangkefeng.wang@huawei.com>,
	Sidhartha Kumar <sidhartha.kumar@oracle.com>
Subject: [PATCH v4 1/4] mm: mprotect: always skip dma pinned folio in prot_numa_skip()
Date: Mon, 20 Oct 2025 14:18:42 +0800	[thread overview]
Message-ID: <20251020061845.3347258-2-wangkefeng.wang@huawei.com> (raw)
In-Reply-To: <20251020061845.3347258-1-wangkefeng.wang@huawei.com>

If the folio (even not CoW folio) is dma pinned, it can't be migrated
due to the elevated reference count. So always skip a pinned folio
to avoid wasting cycles when folios are migrated.

Acked-by: Zi Yan <ziy@nvidia.com>
Acked-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Dev Jain <dev.jain@arm.com>
Reviewed-by: Lance Yang <lance.yang@linux.dev>
Reviewed-by: Sidhartha Kumar <sidhartha.kumar@oracle.com>
Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
---
 mm/mprotect.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/mm/mprotect.c b/mm/mprotect.c
index 988c366137d5..056986d9076a 100644
--- a/mm/mprotect.c
+++ b/mm/mprotect.c
@@ -136,9 +136,12 @@ static bool prot_numa_skip(struct vm_area_struct *vma, unsigned long addr,
 	if (folio_is_zone_device(folio) || folio_test_ksm(folio))
 		goto skip;
 
-	/* Also skip shared copy-on-write pages */
-	if (is_cow_mapping(vma->vm_flags) &&
-	    (folio_maybe_dma_pinned(folio) || folio_maybe_mapped_shared(folio)))
+	/* Also skip shared copy-on-write folios */
+	if (is_cow_mapping(vma->vm_flags) && folio_maybe_mapped_shared(folio))
+		goto skip;
+
+	/* Folios are pinned and can't be migrated */
+	if (folio_maybe_dma_pinned(folio))
 		goto skip;
 
 	/*
-- 
2.27.0



  reply	other threads:[~2025-10-20  6:20 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-20  6:18 [PATCH v4 0/4] mm: some optimizations for prot numa Kefeng Wang
2025-10-20  6:18 ` Kefeng Wang [this message]
2025-10-21  3:06   ` [PATCH v4 1/4] mm: mprotect: always skip dma pinned folio in prot_numa_skip() Barry Song
2025-10-20  6:18 ` [PATCH v4 2/4] mm: mprotect: avoid unnecessary struct page accessing if pte_protnone() Kefeng Wang
2025-10-20 12:53   ` Lorenzo Stoakes
2025-10-20 13:08   ` David Hildenbrand
2025-10-20  6:18 ` [PATCH v4 3/4] mm: mprotect: convert to folio_needs_prot_numa() Kefeng Wang
2025-10-20 13:09   ` David Hildenbrand
2025-10-20 13:10   ` Lorenzo Stoakes
2025-10-20 15:14     ` Kefeng Wang
2025-10-20 17:34       ` David Hildenbrand
2025-10-20 17:49         ` Lorenzo Stoakes
2025-10-20 18:12           ` David Hildenbrand
2025-10-20 18:56             ` Lorenzo Stoakes
2025-10-21  8:41               ` Kefeng Wang
2025-10-21  9:13                 ` David Hildenbrand
2025-10-21  9:25                   ` Lorenzo Stoakes
2025-10-21  9:45                     ` Lorenzo Stoakes
2025-10-21 12:54                       ` Kefeng Wang
2025-10-21 14:56                         ` Lorenzo Stoakes
2025-10-21 15:01                           ` David Hildenbrand
2025-10-21 16:36                             ` Lorenzo Stoakes
2025-10-22  0:51                               ` Kefeng Wang
2025-10-20  6:18 ` [PATCH v4 4/4] mm: huge_memory: use folio_needs_prot_numa() for pmd folio Kefeng Wang
2025-10-20 13:11   ` David Hildenbrand
2025-10-20 13:15   ` Lorenzo Stoakes
2025-10-20 13:23     ` David Hildenbrand
2025-10-20 15:18       ` Kefeng Wang
2025-10-21 13:37         ` Kefeng Wang
2025-10-21 15:35           ` Lorenzo Stoakes
2025-10-21 15:29         ` Lorenzo Stoakes
2025-10-22  1:33           ` Kefeng Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251020061845.3347258-2-wangkefeng.wang@huawei.com \
    --to=wangkefeng.wang@huawei.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=baohua@kernel.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=david@redhat.com \
    --cc=dev.jain@arm.com \
    --cc=lance.yang@linux.dev \
    --cc=linux-mm@kvack.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=ryan.roberts@arm.com \
    --cc=sidhartha.kumar@oracle.com \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox