From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BE1CFCCD184 for ; Fri, 17 Oct 2025 08:16:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 183E48E0043; Fri, 17 Oct 2025 04:16:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 133BD8E0016; Fri, 17 Oct 2025 04:16:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F17088E0043; Fri, 17 Oct 2025 04:16:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C9EFB8E0016 for ; Fri, 17 Oct 2025 04:16:34 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6A5D8883C7 for ; Fri, 17 Oct 2025 08:16:34 +0000 (UTC) X-FDA: 84006899508.20.460355D Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf04.hostedemail.com (Postfix) with ESMTP id BDB244000C for ; Fri, 17 Oct 2025 08:16:32 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=fail ("body hash did not verify") header.d=linuxfoundation.org header.s=korg header.b=BZEDyglT; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf04.hostedemail.com: domain of gregkh@linuxfoundation.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1760688992; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:dkim-signature; bh=voLZugn2Gg+d/Q7qlBoPkQMP9u+oMz8HknDUZSLW1BQ=; b=BQu4mGIufvAIa4AvK2vvfCmw8GJ9g99ZB1DrV98bOpvjaeD/wkNxGcE1aQuMDd0OJF0Klb qoLl2QFfnHcMseYANNCdaOTDZSRy0EHKxr9terrucYUA3l8djWikcD1CFH+e6jVFQ82LII X3X8X2ISYuo+zrBUS/AXE1AsCONMRNo= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=fail ("body hash did not verify") header.d=linuxfoundation.org header.s=korg header.b=BZEDyglT; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf04.hostedemail.com: domain of gregkh@linuxfoundation.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1760688992; a=rsa-sha256; cv=none; b=BY1wThu0dQyftZlOZWxOdbvCoh8+4B7/vmMPi+SfmPrulCrLPYYKPd5EkzZLnIuYT816e3 J+HTldsYIS5D83nVzGZlHiTnUKFxP3lqA+10EeycTCS5a+csjejcZa5fPqSC70c4ECf/Iz 5TAzVUvQIm/F9q4mAKgOZPnlw77Ltpo= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id DD8936427E; Fri, 17 Oct 2025 08:16:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0BA2DC4CEE7; Fri, 17 Oct 2025 08:16:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1760688991; bh=tIPYursE6B5hvi4bKV5/Bcj25s2x5vz/BTH/uwrpS2I=; h=Subject:To:Cc:From:Date:In-Reply-To:From; b=BZEDyglTuy4kzXAqla9xcNEsT9KsSmKPHDPIlpqW8tJBFtFWdzn1a6+PLUak1z3qB FoOueT4d+amO1eErV0HoTQwLoP4faYilKp7w7r+LN8LAs6FWi6Iu+S685n71GLebw/ WZdYo/2W6raDXXdXNfNldopELV0bRiaZ+D/W1kfE= Subject: Patch "minmax: make generic MIN() and MAX() macros available everywhere" has been added to the 5.15-stable tree To: David.Laight@ACULAB.COM, David.Laight@aculab.com, adilger.kernel@dilger.ca, agk@redhat.com, airlied@linux.ie, akpm@linux-foundation.org, amd-gfx@lists.freedesktop.org, andriy.shevchenko@linux.intel.com, anton.ivanov@cambridgegreys.com, bp@alien8.de, clm@fb.com, coreteam@netfilter.org, daniel@ffwll.ch, dave.hansen@linux.intel.com, davem@davemloft.net, dm-devel@redhat.com, dmitry.torokhov@gmail.com, dri-devel@lists.freedesktop.org, dsahern@kernel.org, dsterba@suse.com, dushistov@mail.ru, farbere@amazon.com, freedreno@lists.freedesktop.org, fw@strlen.de, gregkh@linuxfoundation.org, hdegoede@redhat.com, herve.codina@bootlin.com, hpa@zytor.com, jack@suse.com, james.morse@arm.com, jdelvare@suse.com, jdike@addtoit.com, jejb@linux.ibm.com, jernej.skrabec@gmail.com, jmaloy@redhat.com, josef@toxicpanda.com, kadlec@netfilter.org, krzysztof.kozlowski@canonical.com, kuba@kernel.org, linus.walleij@linaro.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-staging@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.co, m@kvack.org, linux-sunxi@lists.linux.dev, linux-um@lists.infradead.org, linux@rasmusvillemoes.dk, linux@roeck-us.net, lorenzo.stoakes@oracle.com, luc.vanoostenryck@gmail.com, luto@kernel.org, maarten.lankhorst@linux.intel.com, malattia@linux.it, martin.petersen@oracle.com, maz@kernel.org, mcoquelin.stm32@gmail.com, mgross@linux.intel.com, minchan@kernel.org, mingo@redhat.com, mripard@kernel.org, ngupta@vflare.org, pablo@netfilter.org, peterz@infradead.org, pmladek@suse.com, qiuxu.zhuo@intel.com, quic_akhilpo@quicinc.com, richard@nod.at, robdclark@gmail.com, rostedt@goodmis.org, rric@kernel.org, ruanjinjie@huawei.com, sakari.ailus@linux.intel.com, sashal@kernel.org, sean@poorly.run, senozhatsky@chromium.org, shuah@kernel.org, snitzer@redhat.com, tglx@linutronix.de, tipc-discussion@lists.sourceforge.net, tony.luck@intel.com, torvalds@linux-foundation.org, tytso@mit.edu, tzimmermann@suse.de, wens@csie.org, willy@infradead.org, x86@kernel.org, ying.xue@windriver.com, yoshfuji@linux-ipv6.org Cc: From: Date: Fri, 17 Oct 2025 10:16:16 +0200 In-Reply-To: <20251008152946.29285-9-farbere@amazon.com> Message-ID: <2025101716-sufferer-penknife-d025@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit X-stable: commit X-Patchwork-Hint: ignore X-Rspam-User: X-Rspamd-Queue-Id: BDB244000C X-Rspamd-Server: rspam03 X-Stat-Signature: oyykt83kgno8s9tex94air4itniupqoh X-HE-Tag: 1760688992-589462 X-HE-Meta: U2FsdGVkX18L0/i9r/KbJWuHT4TxEPK2CeIGaGvGoVbSS7PWn6lXauv+nlsAWwJs89UKEdgZ6vMIqUGoRpt3EPwmmRY4z7ltOVS609PnFMD6s9KbgbtF+4XcTkiAtUFoP4OauFO+JoE6pTutoBtuxecKYfD6uL3fV1k38NroNQ+ISq3co4DWgZ+PHnrUDeKDGUqUucmm9l3lbpoyodvJpxaXND86/Qv9HXfNhKj6TWKGdES2HcgG4YSYe8SAV84plr8Y7zm0uyLrC/s7/OmJaY6ZnxYylwGoat0uNEOfqDsu0iB4GThSRqLOcpp2fDNd82wr3zSe3M93ldvnabluefIWtf5899Fx+jQlyNTMrly/DACT1JPnt6cUFzQq2jO0zPs46odjzIq/N1gBOMVcwgqZIzoE3/xsDQTNgEjsClbGxATCK8fWCDb8l3Lqps1T/FURAs+xNmUNlAFjBQ6Rl+cwGUS5V1uxsUuk8NLqGxM6T0Vh3CfVaIJaWvixY+VDs14XPLRgUjXXEf0MYEjgVnqZ3mJ5WW4c6lJ1v2zIExKMRKUFfl/JrcxtCOKjic5VlJdJKFxU7mv/BpM0m6R9li+6ZwJgYA15t4KUd2zuLMepjbFwtcmIKC/vhGBAtOT7moPKnX/Ok1azzCBe4I+riWCZKhrg/VZY2KQcALcE4WR7FSitUXMi//i8bePJUYdRMVwg6MOvB1yZ0aoSs76CHXpB0NKvXG+gMnPx8VcmqzIZoltEtEkXnLqYoozet3QUyUj0EOzmoI8BmJQmldiPbjgPL8Oi86RXtzTWyVjP4ZzaENTIuzGkNvBINhvDu8C9TBP3GTy3Ixp6FwnwPVOYuKIPBaJ8Ltp6NUYRTCeB3K8Gil8qknaUIgsUh3SqDIsIFdJz/3dxnMXUGxhh2Vwa7BflqRHD7vF00aopNYMU2CGc83QCVOMrc6Qk4RgBLC8PkhKpJywLKE5VwG5446C ZwfQJKf0 NmFsOBtmbK9Hf8gbrEB+68YlRH3hh29GyrLFvqrbdVW6x8wxb3Gf2/NX2PIyjbO5PKHqxjJ9DVjoHcro5BS5Kcnz0DGagHiSdH938viyqJIUD8pmaNyKtnt61rDxufFOAz95SSZamGBRiEnkWEH7kVRpHAmtzGkd4RMSTgLN39ayP1EjEptXirqBu+YsYmOhyQ5ORXctefVSR3a298PcWpPfKeYZmek+udJIEZqmzrSlUnQpQljRxZjDnP91M+Wf7zD+oTdF9U0sBn0SbzxqzwLRejjkSDJfxf3vjVJVQyhpOsF99QqrNs1Z/Is9wQuayK+uPp2+AefYAp7GU4hOOW34c4ut7xo2mqxJjp6nzYAlQBBX2nY3gDkCGfEbWaflXuOF9Yw4w5ZhIljuWG5TlpfvLFqalcvqqtsx33hif/3Irpr5DWrnJM5JlQi011zeMywMFhEVPlOujV3mAIgMScnUE0Sp7qVjMSs9DigvJJJ92yT0GxMlvNvBtOLaUXutGm22gA0abrYy4/MSW8KQGj5I0okOBuOvFrZeSdgQ2Zszw0k2Ly5fwzcXoPZn916b6Rj1/mvPUxMbYlj/os+DVHk0U5cztndoH8/Pnf6iIwFNYztkCRomxiqvgwld1hdCsnP4eyYRxi/cqAJQd3V4zrQOGO6MvmfJyqGk5bn5FC2ZEMAtcJyWfBER4LmZnAVgMl1GLudGj0v7XBcMQtmyipYHy1GHB+vkSRY/X7ouiOBAfCePuYRO3MkQgCz0fThRbMoIg6gJwPSsRP4ARsZP9VqabAwz2PakJyMoJCG6ajtEd+q/QVoQkM2840dtwHcFVcHbpXRT/tMP5ZeBRHwN8Ujn7EG6QSaPX5xabnIaFY1kvPNYW1YgUqzr+o3iNhdfvV3ufFpwHx2869yvnNP+JWZIapvOE0MCDIGKXRUkus8Sg6V8eoiPVMCGGiaQ1EoSOHS7cU+b2vY1TKXyha8oDprVlLk9u u9iUgUm8 TGMaiYHVY/YqbkLJQGbrIRf7rEo0h24J60GGf6NrwXIwx85DNprdimDulk3ogFWsS1nZi7WmIRI5/wZoaj6YXHdym78krt01p/0oLUHNXttv5PZ4CUNZ0RZXNCEJ7pSplOSRRrwk+wZcfZIUE11xC8ur2dh9SCPDytgZWFBAVcA9zuW/mPOYPsqLvetNea5F0cthLYUJVxR0EZxBnUOFI7+2EJFgEfaDEw9BjcivgdI1t0MSIFG38QP3r6M8s8jRuCY69rUcW2AQXShIZ8zywE4rLM3uzgTbiSSN4scbnngw1IRys63IWDdLsA7TCiit4ahUYei3cqmWK6uiqEhC4xoIet/tYwBTR6o58or5EcET4Ny6hjyHrNHVBfFGdVogiiAqAgSB17szPCj9j45pbLwyF6GQgkX3kZBTsKz8CvsOQVV9oK86AXBuo9BK+Yy7vKyHiteId7VTweMO16GqENqSodPnCXgTmcgFiLLqjFQsSzI3/MNfoeIsLMNTm2dpVXxYD6FUJAs/xYgnn+ycvEu9ofyNM2qu01zVeQOLOLleDv92rsnI137cGpMPRolvw+9SxewK0QVnJD3AdBBLSf/h+k5+La/NjTS5AF7eKW4GTfQEVE7mWFCYa384ZydR6FfBGlYfETtAuz3TWWtKKvJLn0pyfT/fBWSWE13lvhgSSz53xEUzTTvo+2RsImI4gQ24vGGAq8GGdYT6xaXpsMx8d1phW7ovDO4zdjWFEXv2hs5eo2aEp4Y/J0ul7H2XcNZOV9U92SkoGzfqZ5NJ/EhJtVDeOpiNxUEW5CYFCUDaAtg4XkHhNriJ7fc3Od4M8Iz7j4FEttI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: This is a note to let you know that I've just added the patch titled minmax: make generic MIN() and MAX() macros available everywhere to the 5.15-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: minmax-make-generic-min-and-max-macros-available-everywhere.patch and it can be found in the queue-5.15 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >From prvs=36971892a=farbere@amazon.com Wed Oct 8 17:32:16 2025 From: Eliav Farber Date: Wed, 8 Oct 2025 15:29:33 +0000 Subject: minmax: make generic MIN() and MAX() macros available everywhere To: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Cc: Linus Torvalds , David Laight , Lorenzo Stoakes Message-ID: <20251008152946.29285-9-farbere@amazon.com> From: Linus Torvalds [ Upstream commit 1a251f52cfdc417c84411a056bc142cbd77baef4 ] This just standardizes the use of MIN() and MAX() macros, with the very traditional semantics. The goal is to use these for C constant expressions and for top-level / static initializers, and so be able to simplify the min()/max() macros. These macro names were used by various kernel code - they are very traditional, after all - and all such users have been fixed up, with a few different approaches: - trivial duplicated macro definitions have been removed Note that 'trivial' here means that it's obviously kernel code that already included all the major kernel headers, and thus gets the new generic MIN/MAX macros automatically. - non-trivial duplicated macro definitions are guarded with #ifndef This is the "yes, they define their own versions, but no, the include situation is not entirely obvious, and maybe they don't get the generic version automatically" case. - strange use case #1 A couple of drivers decided that the way they want to describe their versioning is with #define MAJ 1 #define MIN 2 #define DRV_VERSION __stringify(MAJ) "." __stringify(MIN) which adds zero value and I just did my Alexander the Great impersonation, and rewrote that pointless Gordian knot as #define DRV_VERSION "1.2" instead. - strange use case #2 A couple of drivers thought that it's a good idea to have a random 'MIN' or 'MAX' define for a value or index into a table, rather than the traditional macro that takes arguments. These values were re-written as C enum's instead. The new function-line macros only expand when followed by an open parenthesis, and thus don't clash with enum use. Happily, there weren't really all that many of these cases, and a lot of users already had the pattern of using '#ifndef' guarding (or in one case just using '#undef MIN') before defining their own private version that does the same thing. I left such cases alone. Cc: David Laight Cc: Lorenzo Stoakes Signed-off-by: Linus Torvalds Signed-off-by: Eliav Farber Signed-off-by: Greg Kroah-Hartman --- arch/um/drivers/mconsole_user.c | 2 drivers/edac/skx_common.h | 1 drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 drivers/gpu/drm/amd/display/modules/hdcp/hdcp_ddc.c | 2 drivers/gpu/drm/amd/pm/powerplay/hwmgr/ppevvmath.h | 14 ++++- drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c | 2 drivers/gpu/drm/radeon/evergreen_cs.c | 2 drivers/hwmon/adt7475.c | 24 +++++----- drivers/media/dvb-frontends/stv0367_priv.h | 3 + drivers/net/fjes/fjes_main.c | 4 - drivers/nfc/pn544/i2c.c | 2 drivers/platform/x86/sony-laptop.c | 1 drivers/scsi/isci/init.c | 6 -- drivers/staging/media/atomisp/pci/hive_isp_css_include/math_support.h | 5 -- include/linux/minmax.h | 2 kernel/trace/preemptirq_delay_test.c | 2 lib/btree.c | 1 lib/decompress_unlzma.c | 2 lib/zstd/zstd_internal.h | 2 mm/zsmalloc.c | 1 tools/testing/selftests/vm/mremap_test.c | 2 21 files changed, 43 insertions(+), 39 deletions(-) --- a/arch/um/drivers/mconsole_user.c +++ b/arch/um/drivers/mconsole_user.c @@ -71,7 +71,9 @@ static struct mconsole_command *mconsole return NULL; } +#ifndef MIN #define MIN(a,b) ((a)<(b) ? (a):(b)) +#endif #define STRINGX(x) #x #define STRING(x) STRINGX(x) --- a/drivers/edac/skx_common.h +++ b/drivers/edac/skx_common.h @@ -44,7 +44,6 @@ #define I10NM_NUM_CHANNELS MAX(I10NM_NUM_DDR_CHANNELS, I10NM_NUM_HBM_CHANNELS) #define I10NM_NUM_DIMMS MAX(I10NM_NUM_DDR_DIMMS, I10NM_NUM_HBM_DIMMS) -#define MAX(a, b) ((a) > (b) ? (a) : (b)) #define NUM_IMC MAX(SKX_NUM_IMC, I10NM_NUM_IMC) #define NUM_CHANNELS MAX(SKX_NUM_CHANNELS, I10NM_NUM_CHANNELS) #define NUM_DIMMS MAX(SKX_NUM_DIMMS, I10NM_NUM_DIMMS) --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h @@ -1277,7 +1277,9 @@ int emu_soc_asic_init(struct amdgpu_devi #define amdgpu_inc_vram_lost(adev) atomic_inc(&((adev)->vram_lost_counter)); +#ifndef MIN #define MIN(X, Y) ((X) < (Y) ? (X) : (Y)) +#endif /* Common functions */ bool amdgpu_device_has_job_running(struct amdgpu_device *adev); --- a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_ddc.c +++ b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_ddc.c @@ -25,7 +25,9 @@ #include "hdcp.h" +#ifndef MIN #define MIN(a, b) ((a) < (b) ? (a) : (b)) +#endif #define HDCP_I2C_ADDR 0x3a /* 0x74 >> 1*/ #define KSV_READ_SIZE 0xf /* 0x6803b - 0x6802c */ #define HDCP_MAX_AUX_TRANSACTION_SIZE 16 --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/ppevvmath.h +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/ppevvmath.h @@ -22,12 +22,18 @@ */ #include -#define SHIFT_AMOUNT 16 /* We multiply all original integers with 2^SHIFT_AMOUNT to get the fInt representation */ +enum ppevvmath_constants { + /* We multiply all original integers with 2^SHIFT_AMOUNT to get the fInt representation */ + SHIFT_AMOUNT = 16, -#define PRECISION 5 /* Change this value to change the number of decimal places in the final output - 5 is a good default */ + /* Change this value to change the number of decimal places in the final output - 5 is a good default */ + PRECISION = 5, -#define SHIFTED_2 (2 << SHIFT_AMOUNT) -#define MAX (1 << (SHIFT_AMOUNT - 1)) - 1 /* 32767 - Might change in the future */ + SHIFTED_2 = (2 << SHIFT_AMOUNT), + + /* 32767 - Might change in the future */ + MAX = (1 << (SHIFT_AMOUNT - 1)) - 1, +}; /* ------------------------------------------------------------------------------- * NEW TYPE - fINT --- a/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c +++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c @@ -1964,7 +1964,9 @@ static void sienna_cichlid_get_override_ } } +#ifndef MAX #define MAX(a, b) ((a) > (b) ? (a) : (b)) +#endif static int sienna_cichlid_update_pcie_parameters(struct smu_context *smu, uint32_t pcie_gen_cap, --- a/drivers/gpu/drm/radeon/evergreen_cs.c +++ b/drivers/gpu/drm/radeon/evergreen_cs.c @@ -33,8 +33,10 @@ #include "evergreen_reg_safe.h" #include "cayman_reg_safe.h" +#ifndef MIN #define MAX(a,b) (((a)>(b))?(a):(b)) #define MIN(a,b) (((a)<(b))?(a):(b)) +#endif #define REG_SAFE_BM_SIZE ARRAY_SIZE(evergreen_reg_safe_bm) --- a/drivers/hwmon/adt7475.c +++ b/drivers/hwmon/adt7475.c @@ -23,23 +23,23 @@ #include /* Indexes for the sysfs hooks */ - -#define INPUT 0 -#define MIN 1 -#define MAX 2 -#define CONTROL 3 -#define OFFSET 3 -#define AUTOMIN 4 -#define THERM 5 -#define HYSTERSIS 6 - +enum adt_sysfs_id { + INPUT = 0, + MIN = 1, + MAX = 2, + CONTROL = 3, + OFFSET = 3, // Dup + AUTOMIN = 4, + THERM = 5, + HYSTERSIS = 6, /* * These are unique identifiers for the sysfs functions - unlike the * numbers above, these are not also indexes into an array */ + ALARM = 9, + FAULT = 10, +}; -#define ALARM 9 -#define FAULT 10 /* 7475 Common Registers */ --- a/drivers/media/dvb-frontends/stv0367_priv.h +++ b/drivers/media/dvb-frontends/stv0367_priv.h @@ -25,8 +25,11 @@ #endif /* MACRO definitions */ +#ifndef MIN #define MAX(X, Y) ((X) >= (Y) ? (X) : (Y)) #define MIN(X, Y) ((X) <= (Y) ? (X) : (Y)) +#endif + #define INRANGE(X, Y, Z) \ ((((X) <= (Y)) && ((Y) <= (Z))) || \ (((Z) <= (Y)) && ((Y) <= (X))) ? 1 : 0) --- a/drivers/net/fjes/fjes_main.c +++ b/drivers/net/fjes/fjes_main.c @@ -14,9 +14,7 @@ #include "fjes.h" #include "fjes_trace.h" -#define MAJ 1 -#define MIN 2 -#define DRV_VERSION __stringify(MAJ) "." __stringify(MIN) +#define DRV_VERSION "1.2" #define DRV_NAME "fjes" char fjes_driver_name[] = DRV_NAME; char fjes_driver_version[] = DRV_VERSION; --- a/drivers/nfc/pn544/i2c.c +++ b/drivers/nfc/pn544/i2c.c @@ -126,8 +126,6 @@ struct pn544_i2c_fw_secure_blob { #define PN544_FW_CMD_RESULT_COMMAND_REJECTED 0xE0 #define PN544_FW_CMD_RESULT_CHUNK_ERROR 0xE6 -#define MIN(X, Y) ((X) < (Y) ? (X) : (Y)) - #define PN544_FW_WRITE_BUFFER_MAX_LEN 0x9f7 #define PN544_FW_I2C_MAX_PAYLOAD PN544_HCI_I2C_LLC_MAX_SIZE #define PN544_FW_I2C_WRITE_FRAME_HEADER_LEN 8 --- a/drivers/platform/x86/sony-laptop.c +++ b/drivers/platform/x86/sony-laptop.c @@ -757,7 +757,6 @@ static union acpi_object *__call_snc_met return result; } -#define MIN(a, b) (a > b ? b : a) static int sony_nc_buffer_call(acpi_handle handle, char *name, u64 *value, void *buffer, size_t buflen) { --- a/drivers/scsi/isci/init.c +++ b/drivers/scsi/isci/init.c @@ -65,11 +65,7 @@ #include "task.h" #include "probe_roms.h" -#define MAJ 1 -#define MIN 2 -#define BUILD 0 -#define DRV_VERSION __stringify(MAJ) "." __stringify(MIN) "." \ - __stringify(BUILD) +#define DRV_VERSION "1.2.0" MODULE_VERSION(DRV_VERSION); --- a/drivers/staging/media/atomisp/pci/hive_isp_css_include/math_support.h +++ b/drivers/staging/media/atomisp/pci/hive_isp_css_include/math_support.h @@ -31,11 +31,6 @@ /* A => B */ #define IMPLIES(a, b) (!(a) || (b)) -/* for preprocessor and array sizing use MIN and MAX - otherwise use min and max */ -#define MAX(a, b) (((a) > (b)) ? (a) : (b)) -#define MIN(a, b) (((a) < (b)) ? (a) : (b)) - #define ROUND_DIV(a, b) (((b) != 0) ? ((a) + ((b) >> 1)) / (b) : 0) #define CEIL_DIV(a, b) (((b) != 0) ? ((a) + (b) - 1) / (b) : 0) #define CEIL_MUL(a, b) (CEIL_DIV(a, b) * (b)) --- a/include/linux/minmax.h +++ b/include/linux/minmax.h @@ -277,6 +277,8 @@ static inline bool in_range32(u32 val, u * Use these carefully: no type checking, and uses the arguments * multiple times. Use for obvious constants only. */ +#define MIN(a,b) __cmp(min,a,b) +#define MAX(a,b) __cmp(max,a,b) #define MIN_T(type,a,b) __cmp(min,(type)(a),(type)(b)) #define MAX_T(type,a,b) __cmp(max,(type)(a),(type)(b)) --- a/kernel/trace/preemptirq_delay_test.c +++ b/kernel/trace/preemptirq_delay_test.c @@ -34,8 +34,6 @@ MODULE_PARM_DESC(cpu_affinity, "Cpu num static struct completion done; -#define MIN(x, y) ((x) < (y) ? (x) : (y)) - static void busy_wait(ulong time) { u64 start, end; --- a/lib/btree.c +++ b/lib/btree.c @@ -43,7 +43,6 @@ #include #include -#define MAX(a, b) ((a) > (b) ? (a) : (b)) #define NODESIZE MAX(L1_CACHE_BYTES, 128) struct btree_geo { --- a/lib/decompress_unlzma.c +++ b/lib/decompress_unlzma.c @@ -37,7 +37,9 @@ #include +#ifndef MIN #define MIN(a, b) (((a) < (b)) ? (a) : (b)) +#endif static long long INIT read_int(unsigned char *ptr, int size) { --- a/lib/zstd/zstd_internal.h +++ b/lib/zstd/zstd_internal.h @@ -36,8 +36,6 @@ /*-************************************* * shared macros ***************************************/ -#define MIN(a, b) ((a) < (b) ? (a) : (b)) -#define MAX(a, b) ((a) > (b) ? (a) : (b)) #define CHECK_F(f) \ { \ size_t const errcod = f; \ --- a/mm/zsmalloc.c +++ b/mm/zsmalloc.c @@ -126,7 +126,6 @@ #define ISOLATED_BITS 3 #define MAGIC_VAL_BITS 8 -#define MAX(a, b) ((a) >= (b) ? (a) : (b)) /* ZS_MIN_ALLOC_SIZE must be multiple of ZS_ALIGN */ #define ZS_MIN_ALLOC_SIZE \ MAX(32, (ZS_MAX_PAGES_PER_ZSPAGE << PAGE_SHIFT >> OBJ_INDEX_BITS)) --- a/tools/testing/selftests/vm/mremap_test.c +++ b/tools/testing/selftests/vm/mremap_test.c @@ -22,7 +22,9 @@ #define VALIDATION_DEFAULT_THRESHOLD 4 /* 4MB */ #define VALIDATION_NO_THRESHOLD 0 /* Verify the entire region */ +#ifndef MIN #define MIN(X, Y) ((X) < (Y) ? (X) : (Y)) +#endif struct config { unsigned long long src_alignment; Patches currently in stable-queue which might be from farbere@amazon.com are queue-5.15/minmax-add-a-few-more-min_t-max_t-users.patch queue-5.15/minmax-improve-macro-expansion-and-type-checking.patch queue-5.15/minmax-fix-indentation-of-__cmp_once-and-__clamp_once.patch queue-5.15/minmax.h-simplify-the-variants-of-clamp.patch queue-5.15/minmax-add-in_range-macro.patch queue-5.15/minmax.h-move-all-the-clamp-definitions-after-the-min-max-ones.patch queue-5.15/minmax-don-t-use-max-in-situations-that-want-a-c-constant-expression.patch queue-5.15/minmax.h-remove-some-defines-that-are-only-expanded-once.patch queue-5.15/minmax.h-use-build_bug_on_msg-for-the-lo-hi-test-in-clamp.patch queue-5.15/minmax-simplify-min-max-clamp-implementation.patch queue-5.15/minmax-deduplicate-__unconst_integer_typeof.patch queue-5.15/minmax-simplify-and-clarify-min_t-max_t-implementation.patch queue-5.15/minmax.h-add-whitespace-around-operators-and-after-commas.patch queue-5.15/minmax-avoid-overly-complicated-constant-expressions-in-vm-code.patch queue-5.15/minmax-make-generic-min-and-max-macros-available-everywhere.patch queue-5.15/minmax-fix-up-min3-and-max3-too.patch queue-5.15/minmax.h-reduce-the-define-expansion-of-min-max-and-clamp.patch queue-5.15/minmax-introduce-min-max-_array.patch queue-5.15/minmax.h-update-some-comments.patch