Re: [PATCH] tools/mm/page_owner_sort: add help option support

[SeongJae Park <sj@kernel.org>]

On Fri, 17 Oct 2025 09:19:09 +0800 Ye Liu <ye.liu@linux.dev> wrote:

> 
> 
> 在 2025/10/17 04:10, SeongJae Park 写道:
> > On Thu, 16 Oct 2025 13:49:25 +0800 Ye Liu <ye.liu@linux.dev> wrote:
> > 
> >> From: Ye Liu <liuye@kylinos.cn>
> >>
> >> Add -h/--help option to display usage information and improve code style.
> > 
> > Looks good to me, though I have a trivial comment below.
> > 
> >>
> >> Signed-off-by: Ye Liu <liuye@kylinos.cn>
> >> ---
> >>  tools/mm/page_owner_sort.c | 10 +++++++---
> >>  1 file changed, 7 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/tools/mm/page_owner_sort.c b/tools/mm/page_owner_sort.c
> >> index 880e36df0c11..202eafed66a9 100644
> >> --- a/tools/mm/page_owner_sort.c
> >> +++ b/tools/mm/page_owner_sort.c
> >> @@ -669,14 +669,15 @@ int main(int argc, char **argv)
> >>  		{ "pid", required_argument, NULL, 1 },
> >>  		{ "tgid", required_argument, NULL, 2 },
> >>  		{ "name", required_argument, NULL, 3 },
> >> -		{ "cull",  required_argument, NULL, 4 },
> >> -		{ "sort",  required_argument, NULL, 5 },
> >> +		{ "cull", required_argument, NULL, 4 },
> >> +		{ "sort", required_argument, NULL, 5 },
> > 
> > Seems unnecessary changes.
> The spacing changes fix inconsistent formatting in longopts array.
> Since the format fixes are simple and in the same context, I put them together.

Thank you for clarifying.

> If you insist on removing these changes, I will drop them in the next version.

I have no strong opinion, plese do whatever you prefer :)


Thanks,
SJ

[...]